From: Robert Pluim <rpluim@gmail.com>
To: Po Lu <luangruo@yahoo.com>
Cc: larsi@gnus.org, 50660@debbugs.gnu.org
Subject: bug#50660: 28.0.50; Text artifacting when the cursor moves over text under mouse face that originally displayed a box
Date: Thu, 14 Oct 2021 13:11:47 +0200 [thread overview]
Message-ID: <87lf2v7te4.fsf@gmail.com> (raw)
In-Reply-To: <878ryvnain.fsf@yahoo.com> (Po Lu via's message of "Thu, 14 Oct 2021 18:52:48 +0800")
>>>>> On Thu, 14 Oct 2021 18:52:48 +0800, Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org> said:
Po Lu> + struct face *face_for_box_line = s->face;
Po Lu> +
Po Lu> + if (s->hl == DRAW_CURSOR && cursor_in_mouse_face_p (s->w))
Po Lu> + {
Po Lu> + /* In this situation, the cursor is in the mouse face, but
Po Lu> + s->face hasn't been updated with the mouse face yet. */
Po Lu> + face_for_box_line =
Po Lu> + FACE_FROM_ID_OR_NULL (s->f, MOUSE_HL_INFO (s->f)->mouse_face_face_id);
Po Lu> +
Po Lu> + if (!face_for_box_line)
Po Lu> + face_for_box_line = FACE_FROM_ID (s->f, MOUSE_FACE_ID);
Po Lu> + }
This chunk looks like itʼs repeated a lot, perhaps break it out into a
function?
Robert
--
next prev parent reply other threads:[~2021-10-14 11:11 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87czp6ysw7.fsf.ref@yahoo.com>
2021-09-18 12:23 ` bug#50660: 28.0.50; Text artifacting when the cursor moves over text under mouse face that originally displayed a box Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-18 13:48 ` Lars Ingebrigtsen
2021-09-19 0:33 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-19 5:47 ` Eli Zaretskii
2021-09-19 13:55 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-19 15:13 ` Lars Ingebrigtsen
2021-09-19 17:01 ` Eli Zaretskii
2021-09-20 1:00 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-20 5:19 ` Eli Zaretskii
2021-09-20 5:34 ` Eli Zaretskii
2021-09-20 8:02 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-20 7:07 ` Eli Zaretskii
2021-09-20 7:34 ` Eli Zaretskii
2021-09-20 8:18 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-20 9:47 ` Eli Zaretskii
2021-09-20 10:27 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-20 10:51 ` Eli Zaretskii
2021-09-20 11:08 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-20 12:07 ` Eli Zaretskii
2021-09-20 12:36 ` Eli Zaretskii
2021-09-21 0:38 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-21 6:11 ` Eli Zaretskii
2021-09-21 7:34 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-21 8:45 ` Eli Zaretskii
2021-09-21 9:20 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-21 9:37 ` Eli Zaretskii
2021-09-21 9:45 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-21 10:17 ` Eli Zaretskii
2021-09-21 10:41 ` Eli Zaretskii
2021-09-21 12:26 ` Eli Zaretskii
2021-09-20 11:09 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-21 12:46 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-21 13:10 ` Eli Zaretskii
2021-09-21 13:36 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-21 13:47 ` Eli Zaretskii
2021-09-23 23:53 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-24 6:47 ` Eli Zaretskii
2021-09-26 6:46 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-26 7:04 ` Eli Zaretskii
2021-09-26 9:56 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-27 11:52 ` Eli Zaretskii
2021-09-29 1:35 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-02 8:43 ` Eli Zaretskii
2021-10-02 9:46 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-02 12:52 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-14 8:58 ` Eli Zaretskii
2021-10-14 10:52 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-14 11:11 ` Robert Pluim [this message]
2021-10-14 11:25 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-14 11:35 ` Eli Zaretskii
2021-10-14 11:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-14 12:10 ` Eli Zaretskii
2021-10-14 12:16 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-14 12:20 ` Eli Zaretskii
2021-10-14 12:27 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-14 12:44 ` Eli Zaretskii
2021-10-14 13:11 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-14 15:51 ` Eli Zaretskii
2021-10-15 1:28 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-15 13:43 ` Eli Zaretskii
2021-10-16 0:18 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-16 6:09 ` Eli Zaretskii
2021-10-16 6:16 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-16 6:28 ` Eli Zaretskii
2021-10-16 6:39 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-16 7:00 ` Eli Zaretskii
2021-10-16 7:13 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-16 7:26 ` Eli Zaretskii
2021-10-16 7:52 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-16 10:10 ` Eli Zaretskii
2021-10-16 12:12 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-16 12:25 ` Eli Zaretskii
2021-10-16 12:36 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-16 12:45 ` Eli Zaretskii
2021-10-16 13:18 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-16 13:46 ` Eli Zaretskii
2021-10-17 0:32 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-17 12:15 ` Eli Zaretskii
2021-10-17 12:39 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-20 8:02 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-20 6:33 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-19 0:50 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-19 15:10 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf2v7te4.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=50660@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).