From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Alan Third <alan@idiocy.org>
Cc: 51411@debbugs.gnu.org
Subject: bug#51411: NS port cleanups
Date: Sun, 31 Oct 2021 18:34:15 +0800 [thread overview]
Message-ID: <87lf29jxeg.fsf@yahoo.com> (raw)
In-Reply-To: <YX5uejCzaUNdc222@idiocy.org> (Alan Third's message of "Sun, 31 Oct 2021 10:22:50 +0000")
Alan Third <alan@idiocy.org> writes:
> I think what you'll need to do is union the two rectangles and then
> clip to that, rather than clipping them both separately. That will
> then provide the same clipping as the NSClipRect code does.
I meant to say that DPSrectclip intersects (IOW, behaves just as
NSClipRect does). Unless that's incorrect, I think what I'm doing right
now should work fine.
> I must be failing to communicate well, we keep seeming to
> misunderstand each other.
It could be my problem as well: my reading comprehension is nowhere near
as good as I would rather it be. Thanks a lot for tolerating it.
> You still need to focus, however you don't have to clip when you
> focus.
After I unfocus here:
/* Draw box if not done already. */
if (!s->for_overlaps && !box_drawn_p && s->face->box != FACE_NO_BOX)
ns_dumpglyphs_box_or_relief (s);
-> ns_unfocus (s->f);
I make sure to focus again if an overhang might be drawn again (inside
if (s->prev) and if (s->next)), like so:
/* Draw surrounding overhangs. */
if (s->prev)
{
-> ns_focus (s->f, NULL, 0);
struct glyph_string *prev;
There is, of course, a matching unfocus. Is that not adequate, and if
so, could you please explain how?
Thanks for the feedback, I really appreciate it.
next prev parent reply other threads:[~2021-10-31 10:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87mtmwt3mc.fsf.ref@yahoo.com>
2021-10-26 11:41 ` bug#51411: NS port cleanups Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-26 12:39 ` Alan Third
2021-10-26 12:50 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-27 17:20 ` Alan Third
2021-10-28 1:09 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-28 10:17 ` Alan Third
2021-10-28 11:25 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-31 10:22 ` Alan Third
2021-10-31 10:34 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-10-31 10:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-31 10:59 ` Alan Third
2021-10-31 11:20 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-31 11:26 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-31 12:55 ` Alan Third
2021-10-31 13:12 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-05 7:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-06 0:20 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-06 13:02 ` Alan Third
[not found] <CADwFkmnHko5UrsuNBKjTtt1LjgXet37zP+U9DTMv++njRHePmQ@mail.gmail.com>
2021-10-31 2:38 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-31 2:56 ` Stefan Kangas
2021-10-31 3:13 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-31 3:59 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf29jxeg.fsf@yahoo.com \
--to=bug-gnu-emacs@gnu.org \
--cc=51411@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).