From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51712: 29.0.50; [PATCH] New function `xwidget-webkit-load-html' Date: Thu, 11 Nov 2021 08:31:34 +0800 Message-ID: <87lf1v353t.fsf@yahoo.com> References: <878rxx8w1i.fsf.ref@yahoo.com> <878rxx8w1i.fsf@yahoo.com> <83h7cl5urs.fsf@gnu.org> <87y25x5tu9.fsf@yahoo.com> <831r3p5sn4.fsf@gnu.org> <87wnlgyjcd.fsf@yahoo.com> <87r1bolvx1.fsf@gnus.org> <87czn8yii2.fsf@yahoo.com> <877ddgluzr.fsf@gnus.org> <87fss4ohjv.fsf@yahoo.com> <87sfw4h7pt.fsf@gnus.org> <87zgqcczk4.fsf@yahoo.com> <83bl2s41kb.fsf@gnu.org> <87fss440yp.fsf@yahoo.com> <83r1bo2ilp.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33803"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: larsi@gnus.org, 51712@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 11 01:32:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mky0e-0008XC-Um for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 01:32:09 +0100 Original-Received: from localhost ([::1]:38322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mky0e-0006FJ-20 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Nov 2021 19:32:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mky0Y-0006F1-Bn for bug-gnu-emacs@gnu.org; Wed, 10 Nov 2021 19:32:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56210) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mky0Y-0002AQ-32 for bug-gnu-emacs@gnu.org; Wed, 10 Nov 2021 19:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mky0Y-0007Cc-09 for bug-gnu-emacs@gnu.org; Wed, 10 Nov 2021 19:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Nov 2021 00:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51712 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51712-submit@debbugs.gnu.org id=B51712.163659071327669 (code B ref 51712); Thu, 11 Nov 2021 00:32:01 +0000 Original-Received: (at 51712) by debbugs.gnu.org; 11 Nov 2021 00:31:53 +0000 Original-Received: from localhost ([127.0.0.1]:39523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mky0O-0007CD-Rm for submit@debbugs.gnu.org; Wed, 10 Nov 2021 19:31:53 -0500 Original-Received: from sonic306-22.consmr.mail.ne1.yahoo.com ([66.163.189.84]:42034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mky0L-0007Bv-Vf for 51712@debbugs.gnu.org; Wed, 10 Nov 2021 19:31:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636590703; bh=F2jMoUbc8Ta/zckAQTTFT2UtdTHHK2kHp2nCx503B/g=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=HOSRLDSOcqhN/kYu7/iafLcEQ5r80tzUhkX7f4qTQh9YKX+sdbh/+JDqGqkVGvh023ZQyB4DniqdLcl5rYCLM3Br9KXwFBz1ERdC+TvPYldL2uKCTjL4cnKVKETVfbMEhjr+pYi/hYCEoL76Zwj6aEQkJ8bqtGK+GkLUvy/eSZMA1MX5fbLNh8Zq8H1DKqfYmuDM7GudK0b47gjjN3mFKrMt37xAE8y7HPKEKlg7/Yd68ijii2zQ+Nay7InsZJxielgOteY03umBzW+RyOgKcfq51DQs2M1eQZxcnlFQdBcKi20SnCwnHExDASpywW9yeW03VGIZdg7unF1nunCT2g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636590703; bh=93bRvVYLroGyYYlFbHT8UrZk840BitD/PVHz1CWgl4M=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=NXuyUOD/pwwcfgo+Pk77cjkeyVt1RTRuhyPiUa03mYFhWhdeR09QaRlA6GgKkeq2JCiI+vK7c3Z4pv2MfLqgEPGbhypqB4+Yer94Z7x/cvgEfI3rQgZA+BWFphRgXQUPujgIDmUlRhdmCml+n4GAVw/wTgcsjwfiEwSs/C1lZH5z6LjorDnPRmQDl/am7sq8XHnLrtLDE9ps0S5MrGFwaA0lE/2XwrjFUeiJbehek4krhTiYWyNJKMSvRHbsdgohp4JB7hK9NIFNswmSGzsaD+kBND01L9RfxCpU+WwBr0lmH9SlnkF8OSsF3FobXBqdrVvYb3N82Alv6ls0OOb/Gg== X-YMail-OSG: qnVebN8VM1kWBCFPkXxXCJGjKOT4MQgdWmSDMohlMETYVT_KFJkGgK46OIHrUXf v_hgkG3_1nuNYfcWmlDvkoL.q8Y5cDd21uvnYYyJZAiO.SQ6bFOYBI6hLEhKvib_GOPcuK11dUNw YDlKkvWHuEY_bbGmWMeWKI_4Q1Puis3ZF6rYIKXMhCNaKuaqtcT_OoG71ML68Zng1SBpx2v.tf4A L5CObzl.IfggwPqWi9yChZ4NszF4pAFMxd0RYgSsJHbgIgywEQK8N1W059vsveaNzF3NwpINb70w 0YvT5F9uEFhAGvrsygIYjeTQt8aV21eby19cyvigze7JoOsc72_l64izV3ByIyD5sFCOwTROkjr8 .nId94JLgTiw5.DaIgyIZk6ZJ1Xh1w2QrQ0dnlkDz.VhUicrtduXflIT.JUMHpEhQt07Rlky0Nzk Q_RBNGCNkci1wkawJEV1NcMPsITdb6jqeLR7KXkGE2YXXP1iILKwZMltSOdvK0Fak.xutqtuM9iq Y99Xq4Ltraok0YjHXBrw82MyPD9BeT7FRPOOLjBuEnfCXOvYsr0rbMU1Ma9xbwL4wzylu9kedK5o hJuPZis7OscVLm1JdAOuwPIIFrc74qSsOsQPEcT.0mDCxV.YFnnIZMfKOnjJjFJqhTw59ze4lbbC 2p_p.hz35r5YfnacoVuDRwNj41ndMcMXCR2YoIhFEuqWvkkbIH17JVilnpzibG3mcdhnyeOzYe7j kia2RAIDLRfF581XbH0Hc5m71Mi3WZevty1j27Nq.9hggEq_SFXCRpI8RWNnYJqKd.T.Zq3DreBR yQ281cQ3WRgndmpUV99loKQi2_KtE5_yyiXoXsQHWt X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Thu, 11 Nov 2021 00:31:43 +0000 Original-Received: by kubenode501.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 14c0f39f384a53fa9ab70fd52dad73c0; Thu, 11 Nov 2021 00:31:37 +0000 (UTC) In-Reply-To: <83r1bo2ilp.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 10 Nov 2021 16:25:22 +0200") X-Mailer: WebService/1.1.19306 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219566 Archived-At: Eli Zaretskii writes: >> From: Po Lu >> Cc: larsi@gnus.org, 51712@debbugs.gnu.org >> Date: Wed, 10 Nov 2021 21:03:26 +0800 >> >> Thank you! How does the attached patch look to you? > > LGTM, thanks. But please fix this gotcha when you push: > >> +@defun xwidget-webkit-load-html xwidget text &optional base-uri >> +Load @var{text}, a string, into @var{xwidget}, which should be a >> +WebKit xwidget. Any HTML markup in @var{text} will be processed >> +by @var{xwidget} while rendering the text. >> + >> +Optional argument @var{base-uri}, which should be a string, specifies >> +the absolute location of the web resources referenced by @var{text}, >> +to be used for resolving relative links in @var{text}. >> + > > This lacks "@end defun" at the end. Thanks, fixed and pushed.