From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#53242: [PATCH] unify reads from local_var_alist Date: Fri, 14 Jan 2022 08:49:48 +0100 Message-ID: <87leziu57n.fsf@gnus.org> References: <50d65dbc-f3d6-86fb-6a7c-9200a6525ec2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26151"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 53242@debbugs.gnu.org To: Sergey Vinokurov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 14 09:27:57 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8HwD-0006Yi-JI for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jan 2022 09:27:57 +0100 Original-Received: from localhost ([::1]:33082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8HwC-0006k0-NC for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jan 2022 03:27:56 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58542) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8HLW-0003Bb-TP for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 02:50:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42427) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8HLW-0006bs-JM for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 02:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8HLW-0001Gs-Eo for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 02:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jan 2022 07:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53242 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53242-submit@debbugs.gnu.org id=B53242.16421466014881 (code B ref 53242); Fri, 14 Jan 2022 07:50:02 +0000 Original-Received: (at 53242) by debbugs.gnu.org; 14 Jan 2022 07:50:01 +0000 Original-Received: from localhost ([127.0.0.1]:35330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8HLV-0001GZ-1I for submit@debbugs.gnu.org; Fri, 14 Jan 2022 02:50:01 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:34180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8HLS-0001GJ-NU for 53242@debbugs.gnu.org; Fri, 14 Jan 2022 02:49:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eE7i7ldBge7GQiYiZDsUB59mu1m6SdoFAYrJSrkDyao=; b=eG6eTkj50wsOrOi7GwW10PmOzo keh7WUUZBuiR2/N8IFMeNW99BMtIy/4i96X3WaWCrnfIgdM4DtkZ+UQa/AHRzonUUBlbrebfsQJAD Hxuty70eEafM/nFEV3t6GQqvTb474pIgdebmuvDTumJoSXyIa7UaTURVcUNTSgB22JUs=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8HLJ-0001P9-FO; Fri, 14 Jan 2022 08:49:51 +0100 X-Now-Playing: Various's _I Wanna Be Kate: The Songs of Kate Bush_: "Love And Anger (2020 Remaster)" In-Reply-To: <50d65dbc-f3d6-86fb-6a7c-9200a6525ec2@gmail.com> (Sergey Vinokurov's message of "Fri, 14 Jan 2022 00:23:42 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224166 Archived-At: Sergey Vinokurov writes: > I've noticed that local_var_alist field of the buffer structure is > accessed inconsistently. Sometimes it's Fassoc, sometimes it's Fassq > and other times it's assq_no_quit and even an explicit loop. > > I think it's safe to unify all the accesses via assq_no_quit since > it's an internaly maintained alist that definitely has no cycles and > elements are cons cells with symbol as their car. Makes sense to me, so I've now applied your patch to Emacs 29 (and added a ChangeLog-format commit message). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no