unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#52971: Tests warn after eieio-compat.el was moved to obsolete/
@ 2022-01-03  1:29 Stefan Kangas
  2022-01-03  4:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2022-01-03  1:29 UTC (permalink / raw)
  To: 52971; +Cc: Stefan Monnier

> branch: master
> commit d65534d254b3965ea82a9300c12c5c07f88818b7
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     * lisp/emacs-list/eieio-compat.el: Really move to obsolete

After this or some other recent and related commit, we get these
warnings:

  In toplevel form:
  lisp/emacs-lisp/eieio-tests/eieio-test-methodinvoke.el:58:1:
Warning: Package eieio-compat is deprecated
    GEN      lisp/emacs-lisp/ert-x-tests.log

  In toplevel form:
  lisp/emacs-lisp/eieio-tests/eieio-tests.el:30:1: Warning: Package
eieio-compat is deprecated

I'm not sure about the best way to fix them.  Could we just move those
parts that require eieio-compat.el to a new file eieio-compat-tests.el?

I will silence these warnings using `with-no-warnings' for now, and we
can track progress on this here instead.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#52971: Tests warn after eieio-compat.el was moved to obsolete/
  2022-01-03  1:29 bug#52971: Tests warn after eieio-compat.el was moved to obsolete/ Stefan Kangas
@ 2022-01-03  4:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2022-01-03 16:48   ` Stefan Kangas
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2022-01-03  4:22 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: 52971

> I'm not sure about the best way to fix them.  Could we just move those
> parts that require eieio-compat.el to a new file eieio-compat-tests.el?

That will just move the warnings.

> I will silence these warnings using `with-no-warnings' for now,

Sounds good.

> and we can track progress on this here instead.

Thanks,


        Stefan






^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#52971: Tests warn after eieio-compat.el was moved to obsolete/
  2022-01-03  4:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2022-01-03 16:48   ` Stefan Kangas
  2022-01-14  8:59     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2022-01-03 16:48 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 52971

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> I'm not sure about the best way to fix them.  Could we just move those
>> parts that require eieio-compat.el to a new file eieio-compat-tests.el?
>
> That will just move the warnings.

My thinking was that if these tests are only for obsolete code, it would
be better to isolate them all in one file.  But I have no real opinion
either way.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#52971: Tests warn after eieio-compat.el was moved to obsolete/
  2022-01-03 16:48   ` Stefan Kangas
@ 2022-01-14  8:59     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2022-01-14  8:59 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: 52971, Stefan Monnier

Stefan Kangas <stefan@marxist.se> writes:

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> I'm not sure about the best way to fix them.  Could we just move those
>>> parts that require eieio-compat.el to a new file eieio-compat-tests.el?
>>
>> That will just move the warnings.
>
> My thinking was that if these tests are only for obsolete code, it would
> be better to isolate them all in one file.  But I have no real opinion
> either way.

I think isolating them in a new test file makes sense -- makes things
clearer.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-14  8:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-03  1:29 bug#52971: Tests warn after eieio-compat.el was moved to obsolete/ Stefan Kangas
2022-01-03  4:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-03 16:48   ` Stefan Kangas
2022-01-14  8:59     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).