bug#52925: NonGNU ELPA: GitHub badge incorrectly displayed

bug#52925: NonGNU ELPA: GitHub badge incorrectly displayed

[Stefan Kangas]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

Severity: minor

On this page:

    http://elpa.nongnu.org/nongnu/webpaste.html

Above the headline "1 Webpaste.el – Paste text to pastebin-like
services", there are two squares where we should show a badge, but
currently don't.

See this screenshot:

[-- Attachment #2: Type: text/plain, Size: 403 bytes --]


The text in those squares is:

    Firefox Can’t Open This Page
    
    To protect your security, github.com will not allow Firefox to
    display the page if another site has embedded it.  To see this page,
    you need to open it in a new window.

I'm not sure what the fix is; it looks like a limitation with GitHub.
Perhaps we should just filter out those specific badges from the final
output?

[-- Attachment #3: screenshot.png --]
[-- Type: image/png, Size: 63669 bytes --]

bug#52925: NonGNU ELPA: GitHub badge incorrectly displayed

[Andreas Schwab]

On Dez 31 2021, Stefan Kangas wrote:

> On this page:
>
>     http://elpa.nongnu.org/nongnu/webpaste.html
>
> Above the headline "1 Webpaste.el – Paste text to pastebin-like
> services", there are two squares where we should show a badge, but
> currently don't.

WFM with eww.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

bug#52925: NonGNU ELPA: GitHub badge incorrectly displayed

[Lars Ingebrigtsen]

[-- Attachment #1: Type: text/plain, Size: 422 bytes --]

Stefan Kangas <stefan@marxist.se> writes:

> Severity: minor
>
> On this page:
>
>     http://elpa.nongnu.org/nongnu/webpaste.html
>
> Above the headline "1 Webpaste.el – Paste text to pastebin-like
> services", there are two squares where we should show a badge, but
> currently don't.

Like Andreas said, this works in eww, but I also get an error in
Firefox.  But a different one than you're getting:


[-- Attachment #2: Type: image/png, Size: 115272 bytes --]

[-- Attachment #3: Type: text/plain, Size: 424 bytes --]


Which is...  very strange.  Loading the SVG directly does display
correctly in Firefox:

https://s3.amazonaws.com/assets.coveralls.io/badges/coveralls_unknown.svg

Could it somehow be something with same origin policy that makes Firefox
refuse to read the SVGs?  (I haven't actually examined the web page or
the SVGs.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#52925: NonGNU ELPA: GitHub badge incorrectly displayed

[Stefan Kangas]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Could it somehow be something with same origin policy that makes Firefox
> refuse to read the SVGs?  (I haven't actually examined the web page or
> the SVGs.)

My guess is that Firefox is more conscientious than eww with sending
some of the correct headers (referrer, etc.) to let Github now that we
are getting this file to render it on a different page.  And then Github
blocks it.

But I don't know.

bug#52925: NonGNU ELPA: GitHub badge incorrectly displayed

[Lars Ingebrigtsen]

Stefan Kangas <stefan@marxist.se> writes:

> My guess is that Firefox is more conscientious than eww with sending
> some of the correct headers (referrer, etc.) to let Github now that we
> are getting this file to render it on a different page.  And then Github
> blocks it.

Ah, yes, that's possible.  If I remember correctly, eww/shr isn't
sending refe{r,rr}er at all when fetching images.  Which should be
fixed, I guess.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#52925: NonGNU ELPA: GitHub badge incorrectly displayed

[Stefan Kangas]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> If I remember correctly, eww/shr isn't sending refe{r,rr}er at all
> when fetching images.  Which should be fixed, I guess.

There are some privacy and security implications to consider, so the fix
might not be trivial.  FWIW, I wouldn't spend time on it without a clear
use case in mind.

bug#52925: NonGNU ELPA: GitHub badge incorrectly displayed

[Lars Ingebrigtsen]

Stefan Kangas <stefan@marxist.se> writes:

> There are some privacy and security implications to consider, so the fix
> might not be trivial.  FWIW, I wouldn't spend time on it without a clear
> use case in mind.

I think eww does send over referrer when doing non-image stuff, so it's
a bit inconsistent.  But this should be redone more generally -- for
privacy reasons, eww shouldn't send referrer on cross-site requests, for
instance.  And there should be a way to customise this.

I've been meaning to fix this, but I keep forgetting.  I'll open a new
bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no