From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Kenichi Handa <handa@gnu.org>,
Stromeko@nexgo.de, Michael Albinus <michael.albinus@gmx.de>,
12598@debbugs.gnu.org
Subject: bug#12598: 24.2; utf-8 codepoints in doc-strings and compression of .el and .elc files
Date: Sat, 23 Apr 2022 18:18:26 +0200 [thread overview]
Message-ID: <87levvept9.fsf@gnus.org> (raw)
In-Reply-To: <jwvsip4u4ge.fsf-monnier+bug#12598@gnu.org> (Stefan Monnier's message of "Tue, 22 Apr 2014 23:11:37 -0400")
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
> So re-enabling the
>
> handler = Ffind_file_name_handler (file, Qload);
>
> code might be the best fix. But does it really work? I mean, with
> byte-compile-dynamic file for example (or to find the docstrings after
> loading the file)?
I've added a failing test case to Emacs 29. If we re-enable that bit in
Fload, the test no longer fails (but there may be other test cases; feel
free to amend).
However, this makes files-tests-file-name-non-special-load fail --
perhaps Michael has some insights here; added to the CCs.
But the logic of Fload is pretty unclear. It seems we do end up calling
find-file-name-handler anyway, but later:
/* If FD is -2, that means openp found a magic file. */
if (fd == -2)
{
if (NILP (Fequal (found, file)))
/* If FOUND is a different file name from FILE,
find its handler even if we have already inhibited
the `load' operation on FILE. */
handler = Ffind_file_name_handler (found, Qt);
else
handler = Ffind_file_name_handler (found, Qload);
if (! NILP (handler))
return call5 (handler, Qload, found, noerror, nomessage, Qt);
Hm... is this just because of the way that test is set up?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-04-23 16:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 17:44 bug#12598: 24.2; utf-8 codepoints in doc-strings and compression of .el and .elc files Achim Gratz
2012-10-07 19:40 ` Stefan Monnier
2012-10-07 20:05 ` Achim Gratz
2012-10-07 21:15 ` Andreas Schwab
2012-10-08 5:24 ` Achim Gratz
2012-10-08 5:36 ` Achim Gratz
2013-01-31 18:15 ` Stefan Monnier
2013-01-31 18:37 ` Achim Gratz
2013-02-01 9:23 ` Kenichi Handa
2013-02-01 14:06 ` Stefan Monnier
2013-02-03 11:44 ` Kenichi Handa
2013-02-03 16:04 ` Stefan Monnier
2013-02-05 13:40 ` Kenichi Handa
2013-02-05 17:43 ` Stefan Monnier
2013-02-06 0:46 ` Kenichi Handa
2013-02-03 16:06 ` Stefan Monnier
2013-02-06 15:02 ` Stefan Monnier
2013-02-09 5:05 ` Kenichi Handa
2013-02-09 9:16 ` Eli Zaretskii
2013-02-09 14:51 ` Kenichi Handa
2014-04-23 3:11 ` Stefan Monnier
2022-04-23 16:18 ` Lars Ingebrigtsen [this message]
2022-04-25 9:19 ` Michael Albinus
2022-04-25 9:45 ` Lars Ingebrigtsen
2022-06-02 9:51 ` Lars Ingebrigtsen
2013-02-08 17:43 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87levvept9.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=12598@debbugs.gnu.org \
--cc=Stromeko@nexgo.de \
--cc=handa@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).