From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#55386: 29.0.50; check-declare-directory doesn't work on Windows Date: Sat, 14 May 2022 13:40:11 +0200 Message-ID: <87lev4l4v8.fsf@gnus.org> References: <20220513.002244.1042559713148422728.yasu@utahime.org> <878rr6ycaa.fsf@gnus.org> <835ymapupz.fsf@gnu.org> <878rr5wrma.fsf@gnus.org> <83pmkhmwyv.fsf@gnu.org> <87a6bl305x.fsf@gnus.org> <83o800lbtn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37017"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: yasu@utahime.org, 55386@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 14 13:41:50 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1npq9e-0009SW-KM for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 May 2022 13:41:50 +0200 Original-Received: from localhost ([::1]:52190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npq9d-0002hZ-Io for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 May 2022 07:41:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39294) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npq8v-0002ew-Kd for bug-gnu-emacs@gnu.org; Sat, 14 May 2022 07:41:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52007) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1npq8s-0001us-Hc for bug-gnu-emacs@gnu.org; Sat, 14 May 2022 07:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1npq8s-0003hE-FX for bug-gnu-emacs@gnu.org; Sat, 14 May 2022 07:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 May 2022 11:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55386 X-GNU-PR-Package: emacs Original-Received: via spool by 55386-submit@debbugs.gnu.org id=B55386.165252842414141 (code B ref 55386); Sat, 14 May 2022 11:41:02 +0000 Original-Received: (at 55386) by debbugs.gnu.org; 14 May 2022 11:40:24 +0000 Original-Received: from localhost ([127.0.0.1]:45904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npq8G-0003g1-0v for submit@debbugs.gnu.org; Sat, 14 May 2022 07:40:24 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:48396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npq8E-0003fh-1b for 55386@debbugs.gnu.org; Sat, 14 May 2022 07:40:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BQLDxp8Js/x77w3mZzkKM/bJiHjcqb0WsAXAglxa0Mg=; b=jKwuR1KDpCkYZIeheHyKVkEjjQ 8G/yEhrrs0G/vNGrpoEKY7YXjNcZX3XNSqvAeO2ozyElGFt7u3N+ZFn4aS+UywCbOtuP/4YprAkUw yquYlBEw13rezdIOjnYJdipHyZDftnFrSZdqFkwtY4FGcsjBxqMgAwdVdR7k8UjVZyZM=; Original-Received: from 77.18.168.214.tmi.telenormobil.no ([77.18.168.214] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1npq84-0003Xz-S1; Sat, 14 May 2022 13:40:15 +0200 In-Reply-To: <83o800lbtn.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 May 2022 12:09:56 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232229 Archived-At: Eli Zaretskii writes: > How about the below? It's 3% to 9% slower than the find/grep version > (because it examines more files, I think), but much simpler (IMNSHO), > and works on any platform without any caveats. [...] > - (let ((files (process-lines-ignore-status > - find-program root > - "-name" "*.el" > - "-exec" grep-program > - "-l" "^[ \t]*(declare-function" "{}" "+"))) > + (let ((files (directory-files-recursively root "\\.el\\'"))) > (when files > (apply #'check-declare-files files)))) I'm surprised that it's just 9% slower -- there's 2K files in the Emacs tree, and only one a quarter of them have a declare-function. Is process-lines-ignore-status really slow or something? But the change looks fine to me in any case. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no