From: Damien Cassou <damien@cassou.me>
To: 55571@debbugs.gnu.org
Subject: bug#55571: [PATCH] Fix submit-emacs-patch
Date: Sun, 22 May 2022 08:40:53 +0200 [thread overview]
Message-ID: <87leuujci2.fsf@cassou.me> (raw)
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
Tags: patch
Hi,
submit-emacs-patch creates a new message and immediately inserts new
lines without first moving the point to the message body. This doesn't
work with notmuch (and its notmuch-user-agent symbol) because the point
starts in the headers and nothing in Emacs specifies that the mua should
move point to the body automatically.
* lisp/mail/emacsbug.el (submit-emacs-patch): Make sure point is in
the body before inserting new lines.
Best
--
Damien Cassou
"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-submit-emacs-patch.patch --]
[-- Type: text/patch, Size: 1127 bytes --]
From ad98101fce092b8f0f02c2a3eabdea41d833441d Mon Sep 17 00:00:00 2001
From: Damien Cassou <damien@cassou.me>
Date: Sun, 22 May 2022 08:32:38 +0200
Subject: [PATCH] Fix submit-emacs-patch
submit-emacs-patch creates a new message and immediately inserts new
lines without first moving the point to the message body. This
doesn't work with notmuch (and its notmuch-user-agent symbol) because
the point starts in the headers and nothing in Emacs specifies that
the mua should move point to the body automatically.
* lisp/mail/emacsbug.el (submit-emacs-patch): Make sure point is in
the body before inserting new lines.
---
lisp/mail/emacsbug.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el
index 8cb4a00009..df2b7a7453 100644
--- a/lisp/mail/emacsbug.el
+++ b/lisp/mail/emacsbug.el
@@ -516,6 +516,7 @@ submit-emacs-patch
(view-mode 1)
(button-mode 1))
(message-mail-other-window report-emacs-bug-address subject)
+ (message-goto-body)
(insert "\n\n\n")
(emacs-bug--system-description)
(mml-attach-file file "text/patch" nil "attachment")
--
2.36.0
next reply other threads:[~2022-05-22 6:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 6:40 Damien Cassou [this message]
2022-05-22 11:24 ` bug#55571: [PATCH] Fix submit-emacs-patch Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87leuujci2.fsf@cassou.me \
--to=damien@cassou.me \
--cc=55571@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).