From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#55946: 29.0.50; minibuffer-mode lacks an abbrev table Date: Mon, 13 Jun 2022 17:27:45 -0500 Message-ID: <87leu0mc66.fsf@melete.silentflame.com> References: <87y1y0tt64.fsf@melete.silentflame.com> <83o7ywtrzo.fsf@gnu.org> <87y1y0mpow.fsf@melete.silentflame.com> <83leu0tpua.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23550"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.36 Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 55946@debbugs.gnu.org To: Stefan Monnier , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 14 00:28:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o0sXg-0005pC-Sq for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Jun 2022 00:28:18 +0200 Original-Received: from localhost ([::1]:50210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o0sXf-0004Kd-6m for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Jun 2022 18:28:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o0sXS-0004KU-1z for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 18:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38551) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o0sXR-0002pJ-ON for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 18:28:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o0sXR-0008HE-Il for bug-gnu-emacs@gnu.org; Mon, 13 Jun 2022 18:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Jun 2022 22:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55946 X-GNU-PR-Package: emacs Original-Received: via spool by 55946-submit@debbugs.gnu.org id=B55946.165515927931806 (code B ref 55946); Mon, 13 Jun 2022 22:28:01 +0000 Original-Received: (at 55946) by debbugs.gnu.org; 13 Jun 2022 22:27:59 +0000 Original-Received: from localhost ([127.0.0.1]:60681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0sXP-0008Gw-Df for submit@debbugs.gnu.org; Mon, 13 Jun 2022 18:27:59 -0400 Original-Received: from new3-smtp.messagingengine.com ([66.111.4.229]:59465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o0sXM-0008Gg-07 for 55946@debbugs.gnu.org; Mon, 13 Jun 2022 18:27:57 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id DD91B580C54; Mon, 13 Jun 2022 18:27:50 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 13 Jun 2022 18:27:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1655159270; x=1655166470; bh=+U 6q57FKAMQ5G6KQqBMppTgxjWhOdo5L3s20thDKLlA=; b=3amSDr99nB5e3Y+3Cb 2W3RClUyFASb0MOG6cqCNU0ttVFA4Jp8XuQoolxyIL8V5YfhgHm/gj8beieQzQPu vlWSjIt4hIFgZ6hpilLSsCBsmxQDvzs8YkIs5wMn4D2rcQVBOiXqNsazsOwYbiw2 JYOd/uhRKNGt4I+an+H0/eMgEQmND9lpX0yRgb/6hqzbpfJHFxRTZF97wfgCQVlt qeENdMF4MzW4NeWNNZxdDi81ElBm4Row5R7loi2ITxDvgjicHah5kCxmyY9VUctx 0XAYSeQ2RtipN46gODRj53trB9dHiZPZwez0cR89JRU5fTlpV5qCXvtHUWOay6vK yphg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1655159270; x=1655166470; bh=+U6q57FKAMQ5G6KQqBMppTgxjWhO do5L3s20thDKLlA=; b=e9pHE96RmS7pLzkCy73Ihhdlqlf2lSUnWk3SG6BzvvY8 ECdtVoznMWf7RnE+PCZ+mMuwT14E1WdK/ZG4L3RKrsN55oiTanjhII1HeFlfF7SF R/qgnPQlxhDOmxyTn8etQD1FqSGcfzcnnVGA2n1fkO62Ev3vnrWMqfFzkZ+AB9IC YnrPCMtr2adMZJMVbtNqFlz5fYz/t74xJhMTMoKJuFID/LBZQszKSWM40CK1bZnw Qr8lVCArF7QNq4pAUoGb4y93BOUwqEIZMe8fpYhzTKa5neveQkMOSKNZBSZPdLlT 7Of/69jKFd2n5879wf0rA9rk1EmXtYrT7S8dMaF4kQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddukedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffgffkfggtgesmhdttdertdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeeffffhgeduueeuheekjeejhfegleffvdevfeehkeevudek ueekueehvdeujedvhfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 13 Jun 2022 18:27:49 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 14B2E7E06CB; Mon, 13 Jun 2022 17:27:45 -0500 (CDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234448 Archived-At: --=-=-= Content-Type: text/plain Hello, On Mon 13 Jun 2022 at 05:26PM -04, Stefan Monnier wrote: >>> >> I'd like to define an abbrev for minibuffer-mode but it doesn't have an >>> >> abbrev table. There's a comment in minibuffer.el saying that this is >>> >> because abbrev.el is not loaded early enough. >>> > >>> > AFAICT, we only invoke this mode from C if it is fboundp. So maybe >>> > try changing that, and see if both a bootstrap and a simple build run >>> > to completion OK. >>> >>> Thanks. I see what you mean. Tested both of those and it works. Shall >>> I push to master so it can receive wider testing? >> >> Let's see what Stefan thinks about this. >> Stefan, any comments? > > I couldn't find the corresponding patch, so I don't know what to say. Just the attached simple change. > The comment only refers to defining an abbrev table while loading > `minibuffer.el` because `minibuffer.el` was loaded by `abbrev.el`. > But AFAICT nowadays `abbrev.el` is loaded before `minibuffer.el`, so the > problem seems to have disappeared. Cool. -- Sean Whitton --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-abbrev-tables-for-minibuffer-mode-and-minibuffer.patch >From 791f4991873d4eba25ae608bedb67190f347074f Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Mon, 13 Jun 2022 12:24:17 -0500 Subject: [PATCH] Add abbrev tables for minibuffer-mode and minibuffer-inactive-mode * lisp/minibuffer.el (minibuffer-mode, minibuffer-inactive-mode): Add an abbrev table for each of these modes (bug#55946). --- lisp/minibuffer.el | 2 -- 1 file changed, 2 deletions(-) diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index bf89874ecc..2fd4902ef2 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -2837,7 +2837,6 @@ minibuffer-inactive-mode-map "" #'ignore) (define-derived-mode minibuffer-inactive-mode nil "InactiveMinibuffer" - :abbrev-table nil ;abbrev.el is not loaded yet during dump. ;; Note: this major mode is called from minibuf.c. "Major mode to use in the minibuffer when it is not active. This is only used when the minibuffer area has no active minibuffer. @@ -2859,7 +2858,6 @@ minibuffer-mode `minibuffer-setup-hook' and `minibuffer-exit-hook' rather than the mode hook of this mode." :syntax-table nil - :abbrev-table nil :interactive nil) ;;; Completion tables. -- 2.30.2 --=-=-=--