From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56561: 29.0.50; Infloop in try_window Date: Sat, 16 Jul 2022 14:42:09 +0800 Message-ID: <87lestk18e.fsf@yahoo.com> References: <874jzjwmhn.fsf@md5i.com> <83v8rzsdd1.fsf@gnu.org> <878rovxqjo.fsf@md5i.com> <83sfn2sy19.fsf@gnu.org> <83lesusl4w.fsf@gnu.org> <87lesumqgf.fsf@yahoo.com> <83ilnysbc5.fsf@gnu.org> <83fsj2s8fg.fsf@gnu.org> <83cze6s7xt.fsf@gnu.org> <83bktqs724.fsf@gnu.org> <878rotlpck.fsf@yahoo.com> <834jzhsj1a.fsf@gnu.org> <87v8rxk3eb.fsf@yahoo.com> <83zgh9r2he.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7425"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: mwd@md5i.com, 56561@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 16 08:43:09 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCbW9-0001n8-Ie for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Jul 2022 08:43:09 +0200 Original-Received: from localhost ([::1]:37166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCbW8-0002f9-GS for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Jul 2022 02:43:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCbW2-0002em-9Q for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 02:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45030) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oCbW2-0000rj-0R for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 02:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oCbW1-00006e-R3 for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 02:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jul 2022 06:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56561 X-GNU-PR-Package: emacs Original-Received: via spool by 56561-submit@debbugs.gnu.org id=B56561.1657953751369 (code B ref 56561); Sat, 16 Jul 2022 06:43:01 +0000 Original-Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 06:42:31 +0000 Original-Received: from localhost ([127.0.0.1]:42789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCbVX-00005t-GC for submit@debbugs.gnu.org; Sat, 16 Jul 2022 02:42:31 -0400 Original-Received: from sonic305-20.consmr.mail.ne1.yahoo.com ([66.163.185.146]:36095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCbVV-00005g-PH for 56561@debbugs.gnu.org; Sat, 16 Jul 2022 02:42:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657953742; bh=iukbqjvkDxw4FzjJno0VdprVUkV1c8i6pkjXXbVVIRw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=onEWzWOQSeWnp1w3N3L+v2BTdINmJXlxv/Y/FMsixBOzs887xDGrMSCcI6InAfbR2A/CL+g6TvGpVC8tCzzS4jCtjo7LGpdwc04DU8z36ycckIZHsHjiJOLE/PG6Hz3QDE5aSw8AcHoJK4p9KbUswSwbkPJSrSEzlgFTRr3oPQ04of9b9ufqRlIbCd+sAXBVU2Qs/32AEpBO5zHSTrd5lzis2W3EXg04v7r0EyWuWLKFcUW1Tea0hqW5mZ1IHR1JQsPt2EfxWsw8azuwDGCxCWatB9zfMVhwNMsXode4SLiy4SWgJKx1W08TVt6NtsXwYFx7Vf/hLvZGKp4gOZFDUQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657953742; bh=Yh2vXpfyME5lVU9erdZlxGZu+HEYKOizny/349WXOux=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=MsOeWKsEkBoHJYx598BSYj7lZZr0XZO57LK/GwhO4IyAkx0KjBRJOsBN8xaRxAYv4oefDaualyG6LfWk4TzJN1bR+q+VevcIZ3GSDKgm4+P0oOOlYgQ4hcb96OefyecBbPguRZC4NeQ84YXo0ZQ7pMLxz/0OytLdKHqcILBroJI9ouiX/OIkhAUax2+VR/p1+fKtOgzmAY38E9EtLVxyiL+u+ukoAZTuEdbfOTnY08+1w/TKw3+rOAdW31MckV3WUE64Olnd1cfCaiwf48yKtIiq3K5WIKry4i6mbZIWJmMyhSJAMnbkOBhd5EmpqybHdz/NxiZ16zevEeudCIl+wQ== X-YMail-OSG: 7TG.7wcVM1k43w6nkMSwGda3jCoOqvabwYz22lVSo8KWWBJ_k3kFcFowes0KRYc hKRGX6EOhwqJ2dyfv6ZLbkvPrJuZ.V5789rStLPf6zcYk..DOUnSVKI4sGV8txuRzoveCWw64oAq oP.1uzP.qGNIXQ9vW50qBbMDsNTDtXhBuRp8m59.ZH0WyOqXvczlefBgRXz5qS9sRJCZmtEyXTkk q0oVWtc_ss889hcWGNOGNNmcdedEb1m7Q0ypJbJsu0.XYw5yN_VzKhLDvMAMzt2ZOliEGu9IS.g4 SkQwbQlB4CjU7ecN6ctrOf2OcdzFh7rt3jQbKOLzlICImPh37ujUTMdD0PbHfONiisFcrAD89wvw wGJMf77TOlcDHaSlOdLiv8wygcO_XyDlqKcvSftLQvcVUo4ddHpGucbI24qHQ4wZO9v5kySwPNQg IWXr9YJrGMViKB.7S8thCPn.vUYNeTDxawzc6ssndGmkwyhBX2AOVz5r083eAgptMnU907RxEe9i Owor53YCwZa.YcamqWNMimEBurUipDcVVZMj5LyGKRnHXGzBFNrecD4HaIgbPj4wYZDHc6n6s7Av OexxzTfFrtY8KpSUj5u9dayz18Y5xPTGI4aNaohCSRSZXJmBfpfaWE_LB679kuK30384jVj4JFis lKmLsphqRfioZlGfeQGfLFLIA67M7NKUYQwqpjmXvwWUr_gGgoNP6PhYb6UYHhYnI2Nbxr9NG8hN a5KEA2xz0P2YfNndxoQ_q2aQUbUZphcuCKYnidBoFHTuRqpa_R5zDnUZv4t4nbBiylxwiEmgoZem vUb2ZxOVjo3hDQpisl9Ev7JlF5Jtv8fasJ_QS__RUN X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ne1.yahoo.com with HTTP; Sat, 16 Jul 2022 06:42:22 +0000 Original-Received: by hermes--canary-production-sg3-67975bbd4b-w2clr (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID bc1f1d4e1b7eb945fba20f0672eb1368; Sat, 16 Jul 2022 06:42:15 +0000 (UTC) In-Reply-To: <83zgh9r2he.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 16 Jul 2022 09:33:17 +0300") X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237144 Archived-At: Eli Zaretskii writes: > if (CONSP (Vx_max_tooltip_size) > && RANGED_FIXNUMP (1, XCAR (Vx_max_tooltip_size), INT_MAX) > && RANGED_FIXNUMP (1, XCDR (Vx_max_tooltip_size), INT_MAX)) > { > w->total_cols = XFIXNAT (XCAR (Vx_max_tooltip_size)); > w->total_lines = XFIXNAT (XCDR (Vx_max_tooltip_size)); > } > else > { > w->total_cols = 80; > w->total_lines = 40; > } > > w->pixel_width = w->total_cols * FRAME_COLUMN_WIDTH (tip_f); > w->pixel_height = w->total_lines * FRAME_LINE_HEIGHT (tip_f); > FRAME_TOTAL_COLS (tip_f) = WINDOW_TOTAL_COLS (w); > adjust_frame_glyphs (tip_f); Hmm, right. But what if Vx_max_tooltip_size makes the window too small to hold the entire tooltip? > Or maybe I don't understand what you mean by "the size can be changed > by the window manager", please explain and show the code to which you > allude. > > As for toolkits: we don't use this code when toolkit tooltips are > used. I wasn't talking about X specifically. The code in nsfns.m calls [NSWindow setFrame: display:], which can end up calling adjust_frame_size if NS decides for whatever reason to resize the tooltip frame. But you're right. It is called after we compute the window dimensions and then call try_window. > That would trigger unnecessarily, creating false positives. How so? We pass TRY_WINDOW_IGNORE_FONTS_CHANGE, so try_window can only return 0 if the glyph matrices are too small. > The situation that started this bug report is one such case: my fix > will cause try_window to return zero in that case. But if the entire > text was processed and is in the glyph matrix, that zero return value > doesn't mean a failure. That isn't what the comment above try_window says about its return value: Value is 1 if successful. It is zero if fonts were loaded during redisplay which makes re-adjusting glyph matrices necessary, and -1 if point would appear in the scroll margins. (We check the former only if TRY_WINDOW_IGNORE_FONTS_CHANGE is unset in FLAGS, and the latter only if TRY_WINDOW_CHECK_MARGINS is set in FLAGS.)