From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#57079: 29.0.50; Performance of seq-uniq is not very good Date: Sat, 13 Aug 2022 01:59:11 +0200 Message-ID: <87lertnhdc.fsf@web.de> References: <83tu6ltlcq.fsf@gnu.org> <87y1vxwe0y.fsf@gnus.org> <83k07htjxf.fsf@gnu.org> <87o7wtwcu9.fsf@gnus.org> <83fsi5tj31.fsf@gnu.org> <87k07hwbgs.fsf@gnus.org> <838rnxti1k.fsf@gnu.org> <878rnxwayl.fsf@gnus.org> <837d3hth7r.fsf@gnu.org> <86mtcdnrad.fsf@mail.linkov.net> <878rntr49y.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28424"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , 57079@debbugs.gnu.org, stefan@marxist.se, Juri Linkov To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 13 02:00:34 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMeZu-0007Bm-Ov for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Aug 2022 02:00:34 +0200 Original-Received: from localhost ([::1]:53260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oMeZt-0002cF-Mz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Aug 2022 20:00:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oMeZO-0002Zr-Vb for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2022 20:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41265) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oMeZO-0001jk-M8 for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2022 20:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oMeZO-0002Ys-GB for bug-gnu-emacs@gnu.org; Fri, 12 Aug 2022 20:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Aug 2022 00:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57079 X-GNU-PR-Package: emacs Original-Received: via spool by 57079-submit@debbugs.gnu.org id=B57079.16603487679773 (code B ref 57079); Sat, 13 Aug 2022 00:00:02 +0000 Original-Received: (at 57079) by debbugs.gnu.org; 12 Aug 2022 23:59:27 +0000 Original-Received: from localhost ([127.0.0.1]:59247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMeYp-0002XY-Ed for submit@debbugs.gnu.org; Fri, 12 Aug 2022 19:59:27 -0400 Original-Received: from mout.web.de ([212.227.17.12]:57367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMeYk-0002XH-GK for 57079@debbugs.gnu.org; Fri, 12 Aug 2022 19:59:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1660348753; bh=VOQqp93dPmeIsRP649/bUTTlZD4xnVARUwKlJ1Jj4iw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=SqtxDKepoHYtTqeRV+CpIERQC5ZVs2KhZ9z+dK3xslKfs6wjWn+tSQHC/O2pwA3Gt JGCBeUEnbWzUZmJwUKbU4thvf3FVj/iyitFlMjXZSAjZQhdIRAzmkurxOq5ymCwhas b9gejmP3zUGx0UQCISQhG6XFST/xuQjLZG29iHWs= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MhWor-1nif6Q1Hgh-00ePd5; Sat, 13 Aug 2022 01:59:13 +0200 In-Reply-To: <878rntr49y.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 12 Aug 2022 15:16:09 +0200") X-Provags-ID: V03:K1:CCLvflEZ0x6EDmqJDYmwcQ/mguR63osuK1i8MBZFP65oTVxViHT NRNgdqPd3l12pwQ4o+7gOar8hZP68+3IvkG3s2s1NzY4xQCFwdsUciH4yuHF4AZOAqpLeUs h90kzQ3VpJ5m8V+R0HBLbS7mrC1fFJMnBlenGNZxzUqVv2s26/2hOZ4mSCnm/wrqZwqnRAO c97TkHxtGvk21cOmYPN0A== X-UI-Out-Filterresults: notjunk:1;V03:K0:AFv416cZQVk=:J97GGSCOjnrmGME6rtlDKo wrV0S/K1Zyui5yAC26/R9/1vexaqqrjXLArWq9LKEXjmTKV8VNr4l1jKVfm9LlNS0WMvhG3cP 8QMrfa5NbYJpcOvjmr7aACpaXBoFUjhBGuUSwCi/p3+0+zyVosXQOrMXCBf+9QK6ymcs9q4fV mjhXQIRsrEzOa2wUDsr8H/KLj4+/It048+LrLaUaGlHn7VXgsKoEMoF1sR2rOihEmakwKD+k8 WoxzDYO+zHuSoiCS7h5syrd5Wffc309oIvy6VxnKb1iqACzZFN13fRj1P7/aPHh5GDTXoFWic vDvYrIDjqKhpQkBIxbwJKqYYU2LcvFY7so7S64aK2AY3RtCQhAIikWYcRNiCnW4nwfGWZieMs Gju+J/7GeM78I1Vzm3XJW/XHcpCGdB7VXZfaYKgurf4KVjDZVz2tSzsoAFN54y8GGxTmuagB2 u0sJYu75/10ZLQhafqvHZYpohPS2FdMbepIvblMpuEVDTX15C2HqdQCzR5xetmuPvi2+Nrtom zecADbCG/1WrxZuhLeJQ+b1yt2DLoDB3sJH3H6mOC7Maz/6LexxiYemmWzFgsXHStCwntlQzY dTqJoQ35R0QfObGxZmo+UVKC578xtJv7fn99GRSa+oWjjf+4vLcLEvAT5+d+LRdTj5JbuM2AN 6Pd3800xePltfSW+ioaKdeP0jIYHLw/OjY6TwJqM44SAZ0+gIX4bHWV4m/+33EwXNx/RnKkN6 XYtgPO6IfBQ6H2eiCJZyceijqTUdgijd43UWgfLYOK4LxUTd022Lr+fsy9BA9DwuaKwomkNu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239471 Archived-At: Lars Ingebrigtsen writes: > > delete-dups is faster because its implementation uses the hash table. > > Good point. I've now made seq-uniq do the same, and this makes the test > case go from 1.7s to 0.07s. Good. I think a large amount of non-standard test functions is of the form (lambda (x y) (TEST (F x) (F y))) where TEST is a standard test function (equal or eq) and F some function that CL calls key function. This case can still be supported using hash tables. So I think it could make sense to add support for an additional optional KEY argument. Michael.