From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#57755: 29.0.50; [PATCH] Fallout 816106b Date: Tue, 13 Sep 2022 15:32:56 +0800 Message-ID: <87leqn20gn.fsf@yahoo.com> References: <87edwgib1y.fsf@dick> <87bkrki99p.fsf@dick> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18830"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: 57755@debbugs.gnu.org To: dick Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 13 09:34:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY0R6-0004lx-Mi for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Sep 2022 09:34:24 +0200 Original-Received: from localhost ([::1]:39902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oY0R5-0004Ej-NQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Sep 2022 03:34:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oY0Qk-00040n-UK for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2022 03:34:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59974) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oY0Qk-0003RG-K9 for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2022 03:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oY0Qk-0002hh-GX for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2022 03:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Sep 2022 07:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57755 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57755-submit@debbugs.gnu.org id=B57755.166305439610323 (code B ref 57755); Tue, 13 Sep 2022 07:34:02 +0000 Original-Received: (at 57755) by debbugs.gnu.org; 13 Sep 2022 07:33:16 +0000 Original-Received: from localhost ([127.0.0.1]:48667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY0Q0-0002gQ-78 for submit@debbugs.gnu.org; Tue, 13 Sep 2022 03:33:16 -0400 Original-Received: from sonic309-22.consmr.mail.ne1.yahoo.com ([66.163.184.148]:33991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY0Px-0002gC-VN for 57755@debbugs.gnu.org; Tue, 13 Sep 2022 03:33:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1663054386; bh=3JWWrq8Aq/wc917sMHFIqVTWTN4UFSuG4/2K32kRm1I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=ZRMwISu+K770M3nQpKf6zo2t4bU62FeWfFeRp1kmstAEpZ6766gXa54HgW915e1uMG02QmfBV49KKcWW2BcXao7M4aHXsob26NsBQxCTqWVq653Qy8Vt8GASYEaL2zE61f/VYjHI3aXyUDnVuLrKRQA8feoOh3Ht9ZsbX6fVQh0oReGfWNeuuXNK3hj7z6/aS0KO9ncMvrpVFU0dju8djhk2Td66qJD8/XosFMsPAUpNKvDXrSLxSeHOlNPvldH5bkqGlz2nX3S13jMCFlptPW9IuPefXhA9Bi/d6LP2mGHhELqBOv7b1DjcK640QJK/k0CnvdlLnSQ7Sh4A2K+5lg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1663054386; bh=feOUtuv05I4fs/Is5FpuULpNlslpA3RcQeIEdHxW2g9=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=c+SiNhyFochWJRn3yMUyL2Celq3+4IW+mztJ8mxCbpf9nJiwx/P1xma2tM2OJf/ibQOwnsL6qbqxvaS/ypcncwHOiRodAv/jvqurgly3pShZxDZQn9Gaqok6ym3P3yeF4/Vpl0Cu//LaPKqJJkS2fzBz1IhMC1BrzK6PZXHeTO4FEnrXM8h+wEoYdGPmiV16qocmVry4G55vy4NCopenSyhQePoR7UKsqsHlPemnJH7e9F1w526crRvLaPyCk0m19u3reiyqkWlanuTQAc5gaQ8Aes+ppEyK7xH80IWj8N3VlCbMgT7ultuwswa5vBr9rsDidKUG4nmkPLgFxbhb8A== X-YMail-OSG: PiYsuF4VM1kGyza0KN0Ew0ajuwL7_8N3tDF8ZOA0x.YafubUkGVA5y2nrATcwRX oHApfA47.9oxfBzs4u7xskWM49kBLPWsOy8QQYFigAUn6S2kuXH1UJUjaiyz9bdVHjPDOrkll6GY A4BFiEUYxg8c.04vYgiQTVNFBVXHQGvjJbDyrBlCHI6pLkzrBxehmxbNmYGqA2lG5sWNinlI1luX ptN6RFVhDJOmvRQKLL54lKnqVub4YpuWO4mmEhQknjtU8.k1WdxuL8IzqDHiaiGMh6AmyaJPgebm qoR0iENtP88v6Bckw6iWZ8hxysapxKOks518zZmb6ijvx9vU4zWXPKFM5tu3oC069XRj7uwK_hn1 UmSkIDQD0s6PXRkO3ukl.27RQ0EqrZIgglbwD4t9dUQ.eJ2ubUbbgmvTbb3xRAFldtrghn1QqCCV RQfF2.BXMVXUCdRcoP2jSzN0oCBCPQ6j5_BYZc8cL13WcXDda4N1_fBoitY0jqDhQZ2RR.9tXj05 da.SrQL7zjyT5STdzR7TezFUYJgL1gGdyw14CbwTbFFc.MbGP0OAeVhGUM01.wg23Uxyj_bfgRP6 p04YUIQLPecmGi2h0.TH62rgmuVaUx_n18t1rtWIOXgoq01f3LjWRj5N95AaV7p2PjV.fp7Cxgv2 BlGOwLuPSYyZXfbyUPQO95Ir3IG7kZmN6P3O2RpzSPOMT36AyiAd.RjmAFk6xgCa4GtWbMSHoT.i SeJ6ZuaI1tcFMU6l4NrzVcxsXcKLzJV38v3c_3H0yQY8SB20zUi74dyWba_l46ai_Ij_iY01rNuz l.kHhCTIa_xYuV8lKVFLhoizZey_VF_vATlI2VUmFo X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ne1.yahoo.com with HTTP; Tue, 13 Sep 2022 07:33:06 +0000 Original-Received: by hermes--canary-production-sg3-6bb8946c47-wlcqj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 64154758e83393d2f6266711cd916324; Tue, 13 Sep 2022 07:33:01 +0000 (UTC) In-Reply-To: <87bkrki99p.fsf@dick> (dick's message of "Mon, 12 Sep 2022 17:16:02 -0400") X-Mailer: WebService/1.1.20612 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242329 Archived-At: dick writes: > + call2 (intern ("string-trim-right"), build_string (err->message), What coding system is err->message? And calling intern with a static string is IMHO an anti-pattern that should not be introduced further into our code.