unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: dick <dick.r.chiang@gmail.com>
Cc: 57755@debbugs.gnu.org
Subject: bug#57755: 29.0.50; [PATCH] Fallout 816106b
Date: Tue, 13 Sep 2022 15:32:56 +0800	[thread overview]
Message-ID: <87leqn20gn.fsf@yahoo.com> (raw)
In-Reply-To: <87bkrki99p.fsf@dick> (dick's message of "Mon, 12 Sep 2022 17:16:02 -0400")

dick <dick.r.chiang@gmail.com> writes:

> +		   call2 (intern ("string-trim-right"), build_string (err->message),

What coding system is err->message?

And calling intern with a static string is IMHO an anti-pattern that
should not be introduced further into our code.





  reply	other threads:[~2022-09-13  7:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-12 20:37 bug#57755: 29.0.50; [PATCH] Fallout 816106b dick
2022-09-12 21:16 ` dick
2022-09-13  7:32   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-09-13 11:56     ` Eli Zaretskii
2022-09-13 11:59     ` Lars Ingebrigtsen
2022-09-13 11:57   ` Lars Ingebrigtsen
2022-09-13 12:11     ` Eli Zaretskii
2022-09-13 12:35       ` Lars Ingebrigtsen
2022-09-13 12:48       ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87leqn20gn.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=57755@debbugs.gnu.org \
    --cc=dick.r.chiang@gmail.com \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).