From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57856: 28.2; bookmark context strings in encrypted files Date: Mon, 19 Sep 2022 09:42:44 +0200 Message-ID: <87leqfzu6j.fsf@gnus.org> References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> <87czbv8od3.fsf@gnus.org> <87y1ujsbjp.fsf@gmx.de> <874jx56l2v.fsf@gnus.org> <87mtaxx8s7.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26780"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Gustavo Barros , 57856@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 19 09:43:34 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaBRF-0006ny-Vn for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 09:43:34 +0200 Original-Received: from localhost ([::1]:50280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaBRF-0000Mw-0Q for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 03:43:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaBQn-0000K2-BB for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 03:43:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53076) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaBQk-000375-5p for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 03:43:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oaBQk-00051W-1D for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 03:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Sep 2022 07:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57856 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 57856-submit@debbugs.gnu.org id=B57856.166357337819298 (code B ref 57856); Mon, 19 Sep 2022 07:43:02 +0000 Original-Received: (at 57856) by debbugs.gnu.org; 19 Sep 2022 07:42:58 +0000 Original-Received: from localhost ([127.0.0.1]:52154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaBQf-00051C-VV for submit@debbugs.gnu.org; Mon, 19 Sep 2022 03:42:58 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:47196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaBQb-00050s-Hy for 57856@debbugs.gnu.org; Mon, 19 Sep 2022 03:42:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QT8mLIaeDzhA13yinqgfLudelNtaggTGBZdr+9lfSVI=; b=Uliq+syKUgvApE2Omwhe7nCgZ3 LP0LLk9foiKYjsi4zmDR5unOU/CUWTCo5NA+X3X/67W+o0LqObh7yIAhkUgGsATp68H0wGkaEJr3S MWR5vIUXwMyFzvMgWdS7Uakl7XltzDyCoSpOCFFjx6t51JO0sorvPM4U57kD6F7DAaIU=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaBQS-0006pZ-Tb; Mon, 19 Sep 2022 09:42:46 +0200 In-Reply-To: <87mtaxx8s7.fsf@gmx.de> (Michael Albinus's message of "Sun, 18 Sep 2022 12:43:20 +0200") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEX83Lr94cKsqadv QmL///9urP2wAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YJEwcJFfolgRgAAAGBSURBVDjLdZSNlYQw CISDNgCxAQMNeKT/3m7Ij/HcPd7qc+eTZEKIKX0P+lD4PzBC3iMIL8AzvQn8PQOAFpDxSIkoMfGt UbuUJQkxRY6I3M6yUtNZSKSDHsePIvaiXZe5JD7cVLOplRuEQ6LdzVxN68pow3FRAH8BTrRBQgZC JmhVoN2KqSPgema0ZeyqVr1atTVUENorwuNWnnYpHXXGI6O5wvuRcPwFmigMmRb2k9MNckUNMa+i XvlUXwBvV9eqXnTD4wIeXq0C6Wm2wFYsEvCrmOcJrvBkbUCU5p6DMZJDgoY1ut92uXq2tnKN+7Xs 1hp6Y0gpiRaY4ftVC62Vj5etlly2ZzPki+HzzGdsBi6a+0GjZ6TrA7R2xY3ogRoIcfxdMZohvUHb b8ZBWBLz3QxoY/mIBehzjgAphn3yfohEsA3oN/XZ0z0DK8Dubmc0xCOD4ih9nbz561VZvttB/OJ2 zNErFK6iNiny0l2NKCVczC/EOPZzZ+j9ZRAaAk/wC8i0SPbmcZflAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIyLTA5LTE5VDA3OjA5OjIwKzAwOjAwZRHd3QAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0w OS0xOVQwNzowOToyMCswMDowMBRMZWEAAAAASUVORK5CYII= X-Now-Playing: DMX Krew's _Sound of the Street_: "Emerging Technology" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243037 Archived-At: Michael Albinus writes: >> Right... switching off bookmark context lines would go into >> `epa-file-insert-file-contents' in the gpg case, I think -- where would >> we do that in the Tramp case? > > There is `tramp-handle-insert-file-contents'. Since this is used for > several Tramp backends, we need a check, whether Tramp encryption is > active. Something like > > (when (tramp-crypt-file-name-p filename) > ...) > > OTOH, this would expose the "tramp-crypt-" namespace to tramp.el. Hmm, > maybe I will adapt the solution, but you could start with this. Looking at how to integrate this (which is always iffy when we're dealing with several packages), I think this has to be done the other way. That is, `bookmark-make-record' has to check whether the file is encrypted or not, becaues `*insert-file-contents' might not have been run at all (if this is a new encrypted file, for instance). So `tramp-crypt-file-name-p' is perfect for that, but there doesn't seem to be any `epa-file-name-p' (or something equivalent)? Hm... OK, that was trivial to add, so I've now done it this way in Emacs 29.