bug#58329: 29.0.50; [PATCH] Pass correct environment name to `reftex-label'

bug#58329: 29.0.50; [PATCH] Pass correct environment name to `reftex-label'

[Arash Esbati]

Hi all,

I'd like to install this small change in tex-mode.el:

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/textmodes/tex-mode.el b/lisp/textmodes/tex-mode.el
index 6dc2865dd9..bb8ea0d942 100644
--- a/lisp/textmodes/tex-mode.el
+++ b/lisp/textmodes/tex-mode.el
@@ -1557,7 +1557,7 @@ latex-block-body-alist
      '(if (and (boundp 'reftex-mode) reftex-mode) (reftex-label "table"))
      \n _)
     ("figure" nil  > _ \n "\\caption{" > (skeleton-read "Caption: ") "}" > \n
-     '(if (and (boundp 'reftex-mode) reftex-mode) (reftex-label "table"))))
+     '(if (and (boundp 'reftex-mode) reftex-mode) (reftex-label "figure"))))
   "Skeleton element to use for the body of particular environments.
 Every element of the list has the form (NAME . SKEL-ELEM) where NAME is
 the name of the environment and SKEL-ELEM is an element to use in
--8<---------------cut here---------------end--------------->8---

I'm asking because tex-mode isn't my home turf.

Best, Arash

bug#58329: 29.0.50; [PATCH] Pass correct environment name to `reftex-label'

[Lars Ingebrigtsen]

Arash Esbati <arash@gnu.org> writes:

> -     '(if (and (boundp 'reftex-mode) reftex-mode) (reftex-label "table"))))
> +     '(if (and (boundp 'reftex-mode) reftex-mode) (reftex-label "figure"))))

Your change look like the right thing to me.  This code was apparently
introduced in:

commit dd166d5fa1712b0dda35859c91d89666c2873471
Author:     Stefan Monnier <monnier@iro.umontreal.ca>
AuthorDate: Sun Oct 3 19:53:23 2004 +0000

It looks to me like a cut and paste error -- I've added Stefan to the
CCs; I'm sure he remembers this code.  It's just 18 years ago.

 (defvar latex-block-body-alist
   '(("enumerate" nil '(latex-insert-item) > _)
     ("itemize" nil '(latex-insert-item) > _)
-    ("table" nil "\\caption{" > - "}" > \n _)
-    ("figure" nil  > _ \n "\\caption{" > _ "}" >))
+    ("table" nil "\\caption{" > (skeleton-read "Caption: ") "}" > \n
+     '(if (and (boundp 'reftex-mode) reftex-mode) (reftex-label "table"))
+     \n _)
+    ("figure" nil  > _ \n "\\caption{" > (skeleton-read "Caption: ") "}" > \n
+     '(if (and (boundp 'reftex-mode) reftex-mode) (reftex-label "table"))))

bug#58329: 29.0.50; [PATCH] Pass correct environment name to `reftex-label'

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Lars Ingebrigtsen [2022-10-06 14:19:17] wrote:
> Arash Esbati <arash@gnu.org> writes:
>
>> -     '(if (and (boundp 'reftex-mode) reftex-mode) (reftex-label "table"))))
>> +     '(if (and (boundp 'reftex-mode) reftex-mode) (reftex-label "figure"))))
>
> Your change look like the right thing to me.  This code was apparently
> introduced in:
>
> commit dd166d5fa1712b0dda35859c91d89666c2873471
> Author:     Stefan Monnier <monnier@iro.umontreal.ca>
> AuthorDate: Sun Oct 3 19:53:23 2004 +0000
>
> It looks to me like a cut and paste error -- I've added Stefan to the
> CCs; I'm sure he remembers this code.  It's just 18 years ago.

Oh, so that's what it was.  I've noticed the problem but just lived with
the quirk thinking it was a problem in my own local changes since noone
else complained.
Thanks a lot Arash for fixing it!


        Stefan

bug#58329: 29.0.50; [PATCH] Pass correct environment name to `reftex-label'

[Arash Esbati]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Oh, so that's what it was.  I've noticed the problem but just lived with
> the quirk thinking it was a problem in my own local changes since noone
> else complained.
> Thanks a lot Arash for fixing it!

You're welcome.  Fixed with 0c65c9dfb3.  Closing.

Best, Arash