From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#59314: 29.0.50; EUDC and message-mode header completion Date: Wed, 16 Nov 2022 18:04:06 -0800 Message-ID: <87leoafiax.fsf@ericabrahamsen.net> References: <87a64q7p25.fsf@ericabrahamsen.net> <878rka1y4n.fsf@ericabrahamsen.net> <87zgcqzg7s.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="922"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Alexander Adolf , 59314@debbugs.gnu.org To: Thomas Fitzsimmons Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 17 03:05:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovUHP-000AU8-Br for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Nov 2022 03:05:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovUH3-000215-LO; Wed, 16 Nov 2022 21:05:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovUH0-00020s-Ol for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 21:05:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovUH0-0003Xo-Gq for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 21:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ovUH0-0003A9-8g for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2022 21:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Nov 2022 02:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59314 X-GNU-PR-Package: emacs Original-Received: via spool by 59314-submit@debbugs.gnu.org id=B59314.166865065712097 (code B ref 59314); Thu, 17 Nov 2022 02:05:02 +0000 Original-Received: (at 59314) by debbugs.gnu.org; 17 Nov 2022 02:04:17 +0000 Original-Received: from localhost ([127.0.0.1]:58598 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovUGH-000393-9x for submit@debbugs.gnu.org; Wed, 16 Nov 2022 21:04:17 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:58696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovUGE-00038p-GU for 59314@debbugs.gnu.org; Wed, 16 Nov 2022 21:04:15 -0500 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 30FD8FA59E; Thu, 17 Nov 2022 02:04:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1668650647; bh=BrBV/wtIfJeVEK6BvcsGvEvS/TpkubG7OgRkIZi2nTo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=dFVKv4TFWa41RLA7thjxSP+rMyZm1oMYXIv0bhuBNIbqTWbR2JB9W7foj8cFgy/DT Qkq1nN43XK97AkO3VitOucTz2fg23NUKZ1hJtmFI+8qClCusiQ4Tdic74HM5Ft18av ZRePCex7sVPngGu1xWJ8ZdEjigz1xQvbM17l0q5I= In-Reply-To: (Thomas Fitzsimmons's message of "Wed, 16 Nov 2022 20:34:31 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248068 Archived-At: On 11/16/22 20:34 PM, Thomas Fitzsimmons wrote: > Eric Abrahamsen writes: > >> Thomas Fitzsimmons writes: >> >>> Hi Eric, >>> >>> Eric Abrahamsen writes: >>> >>>> On 11/16/22 14:18 PM, Thomas Fitzsimmons wrote: >>>>> Hi Eric, >>>>> >>>>> Thanks for filing this. >>>>> >>>>> Eric Abrahamsen writes: >>>>> >>>>>> Address completion in message-mode has stopped working in master, >>>>>> possibly as a result of 0e25a39e69acca0324c326ea8e46b1725594bff5. This >>>>>> has been reported for several contact-management backends that expect to >>>>>> have their completions available with . >>>>>> >>>>>> `completion-at-point-functions' contains '(eudc-capf-complete >>>>>> message-completion-function t) at this point -- `eudc-capf-complete' >>>>>> returns no matches, and no other functions in the list are consulted. >>>>> >>>>> I just checked and I didn't think the recent patch I pushed, >>>>> 0e25a39e6..., should have affected completion-at-point-functions. It >>>>> did change the default of eudc-server-hotlist from `nil' to >>>>> `(("localhost" . ecomplete) ("localhost" . mailabbrev))". I thought >>>>> that should only affect EUDC users who have not customized >>>>> eudc-server-hotlist. >>>>> >>>>> `eudc-capf-complete' was added to `message-mode' in commit >>>>> 620ac6735... I'm pretty sure that commenting out this line in >>>>> message.el will restore prior behaviour, but I don't yet know what prior >>>>> behaviour should be (see below). >>>>> >>>>> (add-hook 'completion-at-point-functions #'message-completion-function nil t) >>>>> >>>>>> On gnus.general, someone using BBDB and corfu reported that this recipe >>>>>> fixed the problem: >>>>>> >>>>>> (setq eudc-server-hotlist '(("localhost" . bbdb))) >>>>>> >>>>>> (add-hook 'message-mode-hook >>>>>> (lambda () >>>>>> (setq-local completion-at-point-functions >>>>>> (delq 'message-completion-function >>>>>> completion-at-point-functions)))) >>>>>> >>>>>> Someone else *not* using corfu reported that that didn't work for them. >>>>>> Dunno. >>>>> >>>>> I'm not sure what the out-of-the-box behaviour here is meant to be. Can >>>>> you make a recipe starting from "emacs -Q" (including adding dummy email >>>>> addresses somewhere) that makes completion work how you want it to? For >>>>> me: >>>>> >>>>> emacs -Q >>>>> C-x m TAB >>>>> >>>>> inserts four spaces and prints in *Messages*: >>>>> >>>>> Loading eudcb-ecomplete...done >>>>> Loading eudcb-mailabbrev...done >>>>> >>>>> (Those are new, due to 0e25a39e6... but I thought should be harmless.) >>>> >>>> Yuck, it's been a long time since I looked at this... >>>> >>>> In emacs -Q, message-mode `completion-at-point-functions' is: >>>> >>>> (eudc-capf-complete message-completion-function t) >>>> >>>> Actually that's what it is in my regular Emacs, as well. All I'd need >>>> for EBDB (and BBDB and everything else) is for >>>> `message-completion-function' to get called, which it isn't. I believe >>>> you could allow this by having `eudc-capf-complete' return nil, or have >>>> `eudc-capf-message-expand-name' return a `(list beg end )' >>>> structure that includes the prop `:exclusive 'no' at the end of it. That >>>> would allow a fallthrough to the next function. >>> >>> Ah, OK, that's what happened then. The most recent patch I pushed made >>> `eudc-server-hotlist' non-nil by default, which makes >>> `eudc-capf-message-expand-name' do something other than return nil. >>> >>> Can you try just (setq eudc-server-hotlist nil) and confirm that avoids >>> the breakage? >>> >>> If it does, I'll revert that part of the patch for now. >> >> It does! Thanks. > > As I was considering reverting the default change, I figured that this > is likely a bug in `eudc-capf-message-expand-name'; it should return nil > if it gets no results from any EUDC backend, right? I pushed a fix for > that. Can you apply it to your tree and see if your completion setup > works again? Yes that worked, rebuilt Emacs with no additional changes.