From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#62157: More control over the mouse behaviour in eglot Date: Mon, 13 Mar 2023 16:59:50 +0100 Message-ID: <87lek0vdzd.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4206"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62157@debbugs.gnu.org, Pedro Andres Aranda Gutierrez To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 13 17:01:56 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbkcV-0000sb-QM for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Mar 2023 17:01:55 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pbkam-0006Iz-2P; Mon, 13 Mar 2023 12:00:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbkah-0006IC-Bc for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2023 12:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pbkah-00005N-1k for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2023 12:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pbkag-0003hZ-Oc for bug-gnu-emacs@gnu.org; Mon, 13 Mar 2023 12:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Mar 2023 16:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62157 X-GNU-PR-Package: emacs Original-Received: via spool by 62157-submit@debbugs.gnu.org id=B62157.167872320014173 (code B ref 62157); Mon, 13 Mar 2023 16:00:02 +0000 Original-Received: (at 62157) by debbugs.gnu.org; 13 Mar 2023 16:00:00 +0000 Original-Received: from localhost ([127.0.0.1]:35481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbkad-0003gX-WF for submit@debbugs.gnu.org; Mon, 13 Mar 2023 12:00:00 -0400 Original-Received: from mail-wm1-f46.google.com ([209.85.128.46]:45725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbkab-0003gJ-RB for 62157@debbugs.gnu.org; Mon, 13 Mar 2023 11:59:58 -0400 Original-Received: by mail-wm1-f46.google.com with SMTP id m18-20020a05600c3b1200b003ed2a3d635eso495942wms.4 for <62157@debbugs.gnu.org>; Mon, 13 Mar 2023 08:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678723191; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=3zg9Ysl223qYHdc8NtjgZTapvZYdEN890HA3i7l/Ldw=; b=U1MRABgdd1jWPfmhLo1ddNDhEdHN5z5JWcPZ9J+62pSlhSFhxwHnJbwxSpNsndojJI Zr88qCH9XSXGwKiXV2Z1tAEU4+kW1JLky+ASZl3FWKHqMKkil+i7QWE8U/pd+hF/pP9I YG+ssteo/uLhdEPe385a1fRBNB1SUGUSwDe1V4Kl+vcxIaC1dkHTgYYQCk1K0FBic1Kf p459KOeYEkmEio7EcIu2RreNEqrFBerIW4oXUcNt2W5eHruIfPYgalMlHejXOT+owtOg s4l7t8KcrQsgaNCKXG5qj+XK0xSTdJnsdTIrRoSYgxZDDhiVm1uj0L+NN9DFY376hFmC 8RYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678723191; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3zg9Ysl223qYHdc8NtjgZTapvZYdEN890HA3i7l/Ldw=; b=QnyXUjvUQdGPp4Sd2ebhp2ZzdK6Js1dgtsN0Wzo8rnps3mfrf0QY7PnbnCdsKcyvOc XmG/dWL8z+iSgxLiAnvbLlyrFUNgyySFEMOFiVVNMnemnfOjfKpnR+w9IrU3Rw5n9LEl NePZmBNNFjjxL/J3RkLQwAtGugVRVTgOXv+9pxZffLFqn1fyTaelpSEPwUVNkb112YFU N/A9LZloo5wvpHj2BradT1P6o/4zkk6GHEzYkkmvRkE9C3neGFo9rnEZrctPaeCgkArA ll+qRvXuCBbEisUvCatFwBx93Pn5uwq59m4xFD1Vd40BdTED2pSx0CpM2BG7ec+vw9El o4rQ== X-Gm-Message-State: AO0yUKULD1sekeXTrhd8HppUxPprXgRXzxJW4UNAZi8BjB4cP90bQn6i 0EWntz7tAvx49vQdpc6oVKQn5Ajg2sA= X-Google-Smtp-Source: AK7set/6ZyDeF7ab11YrQLZaN01H8l6U9wu+R53QYiX7BpvvTaDKDQ7NT+JajtNLUHLco/mr+7MGqA== X-Received: by 2002:a05:600c:4e4f:b0:3eb:2de8:b74e with SMTP id e15-20020a05600c4e4f00b003eb2de8b74emr11231767wmq.27.1678723191278; Mon, 13 Mar 2023 08:59:51 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id v6-20020a05600c444600b003df7b40f99fsm162411wmn.11.2023.03.13.08.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 08:59:50 -0700 (PDT) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Mon, 13 Mar 2023 15:47:38 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257911 Archived-At: >>>>> On Mon, 13 Mar 2023 15:47:38 +0000, Jo=C3=A3o T=C3=A1vora said: Jo=C3=A3o> Can you try this patch? It also changes the default binding= to Jo=C3=A3o> [mouse-2]. I think you meant 'mouse-2', but you typed 'mouse-1' in the patch. Jo=C3=A3o> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.= el Jo=C3=A3o> index 2491c86ea5b..256b4cd93ba 100644 Jo=C3=A3o> --- a/lisp/progmodes/eglot.el Jo=C3=A3o> +++ b/lisp/progmodes/eglot.el Jo=C3=A3o> @@ -2084,15 +2084,18 @@ eglot--mode-line-format Jo=C3=A3o> (defalias 'eglot--make-diag 'flymake-make-diagnostic) Jo=C3=A3o> (defalias 'eglot--diag-data 'flymake-diagnostic-data) Jo=C3=A3o> +(defvar eglot-diagnostics-map Jo=C3=A3o> + "Map active in Eglot-backed Flymake diagnostic overlays." Jo=C3=A3o> + (let ((map (make-sparse-keymap))) Jo=C3=A3o> + (define-key map [mouse-1] 'eglot-code-actions-at-mouse) Jo=C3=A3o> + map)) Jo=C3=A3o> + I=CA=BCm guessing eglot is not yet using `defvar-keymap' because of backwards compatibility? In any case, this doesn=CA=BCt make the binding easily changable, you have to manually unset/set the `eglot-code-actions-at-mouse' binding. My attempt to fix this descended into a circular dependency spiral between the keymap and the key defcustom, so I=CA=BCm hoping you know a good way to do it :-) Robert --=20