From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mohsin Kaleem Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH 1/3] Add face definitions for more underline styles Date: Fri, 21 Apr 2023 17:08:39 +0100 Message-ID: <87leil5ibc.fsf@kisara.moe> References: <20230421143448.339022-1-mohkale@kisara.moe> <20230421143448.339022-2-mohkale@kisara.moe> <83zg712pn4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36668"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62994@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 21 18:09:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pptKI-0009Hd-QF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Apr 2023 18:09:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pptJq-0003wP-AH; Fri, 21 Apr 2023 12:09:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pptJm-0003sp-VN for bug-gnu-emacs@gnu.org; Fri, 21 Apr 2023 12:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pptJm-0006H5-4D for bug-gnu-emacs@gnu.org; Fri, 21 Apr 2023 12:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pptJl-00051F-VJ for bug-gnu-emacs@gnu.org; Fri, 21 Apr 2023 12:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mohsin Kaleem Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Apr 2023 16:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.168209332219266 (code B ref 62994); Fri, 21 Apr 2023 16:09:01 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 21 Apr 2023 16:08:42 +0000 Original-Received: from localhost ([127.0.0.1]:41019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pptJR-00050g-Ud for submit@debbugs.gnu.org; Fri, 21 Apr 2023 12:08:42 -0400 Original-Received: from 119.ip-51-38-65.eu ([51.38.65.119]:54760 helo=mail.kisara.moe) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pptJQ-00050Y-Ef for 62994@debbugs.gnu.org; Fri, 21 Apr 2023 12:08:40 -0400 Original-Received: from mk-deck (unknown [146.70.132.151]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mail.kisara.moe (Postfix) with ESMTPSA id 3117BA0FB5; Fri, 21 Apr 2023 18:08:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kisara.moe; s=default; t=1682093319; bh=5kduxa1kXIdu6+crl/rJkOGFXOF08o9fTJaDuLZd3dE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=OZaAdc110SWP00rv65fayY61AjSaSxmoGftjHeCBME5tSMZeLJOhjkH0sHDvhATEk QTvOLeBGjIOQMyfd4R8syBR1hMjvaZ3BchHLQvlgO/EqoLG0eXnQ1wYtHzdmVHrNVK chwJtWw2kijMZNa+XNNjVW7NgKZhBzGR6l0mJau5OZLCPwiNsughPIVUFRhz9ptPxE p4CNIti5Y1VJI5l4Ce49b5ndq9i+gVxTcftEsH7fsFOBlrr+24jVTB0LAOlfr3eQte 5Ax/ytGfMy3U7JXh6HoA7v5k3wBMPenMv2KkP6SBrMeDF6ocg8WuGHu5ZN5b4UwA1p zBDNq0cKuHboQ== In-Reply-To: <83zg712pn4.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260401 Archived-At: Eli Zaretskii writes: > Is it really necessary to change the numerical value of > FACE_UNDER_WAVE? Can it be left at its original value? If consistency with Smulx is desirable then I think it is. Otherwise when we populate the escape sequence for the underline we'll need to map from the face underline style to the sequence underline style. Reordering like this makes them match so we don't have to do any extra processing later, but if preferable I can retain the original order and add a helper function to map to the sequence value. -- Mohsin Kaleem