From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thuna Newsgroups: gmane.emacs.bugs Subject: bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers Date: Mon, 01 May 2023 22:05:35 +0200 Message-ID: <87lei7es1c.fsf@gmail.com> References: <877cynrd8i.fsf@gmail.com> <875y9cqmtm.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10769"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60191@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 01 22:06:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptZmx-0002YN-Or for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 May 2023 22:06:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptZme-0001te-VE; Mon, 01 May 2023 16:06:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptZmd-0001tK-5c for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 16:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptZmc-0002Mc-U1 for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 16:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ptZmc-0004zA-Cm for bug-gnu-emacs@gnu.org; Mon, 01 May 2023 16:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thuna Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2023 20:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60191 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60191-submit@debbugs.gnu.org id=B60191.168297154819143 (code B ref 60191); Mon, 01 May 2023 20:06:02 +0000 Original-Received: (at 60191) by debbugs.gnu.org; 1 May 2023 20:05:48 +0000 Original-Received: from localhost ([127.0.0.1]:41131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptZmO-0004yg-Ge for submit@debbugs.gnu.org; Mon, 01 May 2023 16:05:48 -0400 Original-Received: from mail-ej1-f47.google.com ([209.85.218.47]:55380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptZmK-0004yP-G8 for 60191@debbugs.gnu.org; Mon, 01 May 2023 16:05:47 -0400 Original-Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-95316faa3a8so590525266b.2 for <60191@debbugs.gnu.org>; Mon, 01 May 2023 13:05:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682971537; x=1685563537; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=O87s3b5ubY9KvSE+YKYwjYf/8KesUqmCe7CcbEcAUcc=; b=RAxHzpQPIFVrXm0TAdVPW3sFPN/MHxhp9zVDBHxKbHIrZNh//Ynu+ecaEgwRcpSgFL 9wv62EGdtuU3xKjd3e8QBPT4jWIn/oQEiVqq9T3LDQPc30EYCeKAgKNzMiSXqdHnGHt2 DDUQCIOsQTGMHgma9InvgjJrvR2T0pRM4HSzLkyMu6yJ06nyRx+7Y6eYUK0XZYzhEQF8 AMBA9P9k/PddxJ8DZfVEH/8f1uRQqMvdpnbfWN1VGhzYpZ1IbLhTHW9PYiOMTCZUEPYw 2do8g9rHYCroLaIc8Fkf0wasb63v0WBPTn9SC9g2USQdO7WQ9RuDfFDEAeVNyq6y7ALZ 7aRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682971537; x=1685563537; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O87s3b5ubY9KvSE+YKYwjYf/8KesUqmCe7CcbEcAUcc=; b=a4hubjJUWaoBiZ2b2EVpRPY3vsafHg/l0pSLW8T7XqHe4XkckWQ5zR4dW7fEFXVTJO yBgfbEnMqcz/C+KI2JsOxXjxIcVYgnLYnoMI03XL3KsxJpwJWQBstp8ER+eAIP0W1itO pMhiXVSQSMfENreQkW0r8Ca3MC5HMp3VFmGPzB4WE49YiWg3RjVfyU5KcQhNlkRcyTS2 Gh5VqlcPcaMC8PZCKFVErQHUtR7LzVmx457o4MzVFagPsFuaP8yXHXicDeYwaO5TLXA8 jACJagvycAjN3eFEnx2Oqf0xEj2BFhKlwISXvgiRPtMZFZZ5YmX1jOzA1hmv5a9MrKue Rb/w== X-Gm-Message-State: AC+VfDytUBk/uaiwheifmaZZkA//WaWCwenns2gCIInnVTGfLfAvbTUp 15+WwF+pOVnysgnAJJ7yh/IwxknL2XY= X-Google-Smtp-Source: ACHHUZ6OmUY78A7rY5knyvXz7KQmHMbumY/3EWS/+dswZ/zZ5l2r5YgXpvoEHp15kG2agW54DbSyEQ== X-Received: by 2002:a17:906:fe45:b0:94a:4b7a:9886 with SMTP id wz5-20020a170906fe4500b0094a4b7a9886mr13819325ejb.12.1682971537021; Mon, 01 May 2023 13:05:37 -0700 (PDT) Original-Received: from thuna (eduroam-063.unibocconi.it. [90.147.70.63]) by smtp.gmail.com with ESMTPSA id dn1-20020a17090794c100b00953381ea1b7sm15118500ejc.90.2023.05.01.13.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 13:05:36 -0700 (PDT) In-Reply-To: <875y9cqmtm.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260891 Archived-At: > I do not understand what you mean by "not working" here, the code > appears to do the same thing pre- and post-patch, in the process and the > channel buffers. The problem is that when `rcirc-buffer-process' is explicitly called with a channel buffer it returns nil, as the local variable `rcirc-process' is set only in server buffers and the function checks the server buffer only if the BUFFER argument is nil. This leads to a situation where `(rcirc-buffer-process)' and `(rcirc-buffer-process (current-buffer))' do not behave in the same way when called from channel buffers.