From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#63236: 29.0.90; loaddefs-generate not 100% backwards compatible Date: Thu, 04 May 2023 10:45:37 +0200 Message-ID: <87lei4jxhq.fsf@gmail.com> References: <87cz3ill2x.fsf@gmail.com> <871qjxlseb.fsf@gmail.com> <83bkj1mzj2.fsf@gnu.org> <87wn1pjzme.fsf@gmail.com> <83354dmn2b.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33179"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63236@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 04 10:46:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puUbb-0008MY-8k for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 May 2023 10:46:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puUbE-0001Pz-0L; Thu, 04 May 2023 04:46:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puUbC-0001PX-Ca for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 04:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puUbB-0004a1-Va for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 04:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1puUbB-0001Kw-Qf for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 04:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 May 2023 08:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63236 X-GNU-PR-Package: emacs Original-Received: via spool by 63236-submit@debbugs.gnu.org id=B63236.16831899495117 (code B ref 63236); Thu, 04 May 2023 08:46:01 +0000 Original-Received: (at 63236) by debbugs.gnu.org; 4 May 2023 08:45:49 +0000 Original-Received: from localhost ([127.0.0.1]:48538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puUay-0001KS-OX for submit@debbugs.gnu.org; Thu, 04 May 2023 04:45:49 -0400 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:51499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puUav-0001KE-UG for 63236@debbugs.gnu.org; Thu, 04 May 2023 04:45:47 -0400 Original-Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-3f192c23fffso1307335e9.3 for <63236@debbugs.gnu.org>; Thu, 04 May 2023 01:45:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683189939; x=1685781939; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=1qidapiJEwWSASf3J6qP7LCt4NEN6nt2xxXqwNJT8XU=; b=hrMvTkS4alvjOv9H/OhxCeisXTeCawlD8UwemTz9cYq60icDgLWJojSkxJNV25LtxC 5dVvXKyzIl4uHII04Quh8BJIxMtKwgofWS3t9qQb9tSQFt+FBvwhAmMWVTohLFy7QfP4 g8JnVY/odf+HTfu59ALR5zzpdguZuLTjkjKUYqolaHNr9CH2aQyIr+OO13qCZcjID2sJ +TUsrLXTENV458/wmck5udIyXfKpDmxqJDIzuLW9WL7bBOZXRKnYw+sjrMym3Fu/lMwj 7/WFqHmfY5lOmviiaoRwdGVo//YD43KyM7zbUq6MowZ2wEDlpO2KhobAPd1e4R3CW54b LPFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683189939; x=1685781939; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1qidapiJEwWSASf3J6qP7LCt4NEN6nt2xxXqwNJT8XU=; b=gIyrlYvzc+NxtMLQLTknJEljbzlgM0lsZP0jlWnnYgKSwKj567pKNG+Y1yTmsp8biJ kVLpcwcfgi4LoHFxdmS2OmpCduZjej1rCUtvx/GJ5XDDTYJ8TM+/zG5SGkZOOUAAz6mR PlnMhP1XLnaZ28IWdtEl+itaV/MHIsLrDpA6XjmZAwPLzjw4YdX5uFnfi1u+7LknqpbL emF6gKdmcGxw+Nhm3eWwjF69C808xPkJ2uOVPTdJQ5lCkE5T4TbbOwyzEke2RpeJP/bF qOnpsijH/ldA9A3nLR7hoew2MnXXDMqgQlm+MuO63Ytq7nrk6QGIpGe3vwUMGhPSBzZZ W8aw== X-Gm-Message-State: AC+VfDzm7nRD2ghzKgUKcLWvYF+qWHlpcTZnw+76ed9No0rFE1FZJICW Y29OC1gIfdEKnMLMWYcrEIDbWzrRaFM= X-Google-Smtp-Source: ACHHUZ4whZnR0pMm7dFudazKoNHfARZPOJL1Gvc+dFQMQLreLO0DmPKYzaBEBfYsZRoaKlgkQsOEdQ== X-Received: by 2002:a7b:cd18:0:b0:3f1:6fe2:c4b2 with SMTP id f24-20020a7bcd18000000b003f16fe2c4b2mr16479282wmj.23.1683189938550; Thu, 04 May 2023 01:45:38 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id c10-20020adffb0a000000b00306344eaebfsm7677123wrr.28.2023.05.04.01.45.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 01:45:37 -0700 (PDT) In-Reply-To: <83354dmn2b.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 03 May 2023 18:50:20 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261004 Archived-At: >>>>> On Wed, 03 May 2023 18:50:20 +0300, Eli Zaretskii said: Eli> But if the search for "\n\f\n;;;" fails, why should we assume that= the Eli> search for "\n\f\n;;" will succeed? A broken autoloads file can be Eli> broken in a much worse manner, no? Is even a form-feed guaranteed? Nothing is guaranteed, but in the only example in the wild I=CA=BCve found = where the emacs-29 code fails, searching for only two ';' works. Eli> Maybe we should assume, if the search for the canonical last line Eli> fails, that there's no canonical last line, and just insert it Eli> ourselves? Yes, but the issue here is that the code is deciding where to end the region that it=CA=BCs deleting from an existing autoloads file. If we don= =CA=BCt do the deletion, we get duplicate entries (or maybe even a broken autoloads file). Eli> What did the old code do in these cases? I=CA=BCm not sure. A quick read of emacs-lisp/autoloads.el in emacs-28 seems to indicate it=CA=BCs looking for ';', but I haven=CA=BCt actually te= sted it. >> Looking at the history, the autoloads generation was rewritten for >> emacs-29, so this looks like a minor regression. Eli> Yes, loaddefs-gen.el is new, so we must fix it on the emacs-29 bra= nch. Then the easiest fix would be to search for two ';' instead of three. Robert --=20