From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#63260: 29.0.90; Regression installing/activating packages without autoloads Date: Fri, 05 May 2023 08:36:51 +0200 Message-ID: <87lei3nv24.fsf@gmail.com> References: <87ild8tnbg.fsf@tcd.ie> <87ttwsnn59.fsf@gmail.com> <87zg6kysao.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6144"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63260@debbugs.gnu.org, Philip Kaludercic To: Basil Contovounesios Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 05 08:38:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pup5C-0001NB-9k for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 May 2023 08:38:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pup52-0004sd-AM; Fri, 05 May 2023 02:38:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pup4u-0004rr-7b for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 02:38:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pup4s-00071y-4p for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 02:38:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pup4r-00085L-W9 for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 02:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 May 2023 06:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63260 X-GNU-PR-Package: emacs Original-Received: via spool by 63260-submit@debbugs.gnu.org id=B63260.168326862430938 (code B ref 63260); Fri, 05 May 2023 06:38:01 +0000 Original-Received: (at 63260) by debbugs.gnu.org; 5 May 2023 06:37:04 +0000 Original-Received: from localhost ([127.0.0.1]:52988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pup3v-00082w-NS for submit@debbugs.gnu.org; Fri, 05 May 2023 02:37:04 -0400 Original-Received: from mail-wm1-f53.google.com ([209.85.128.53]:60580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pup3q-00082D-TR for 63260@debbugs.gnu.org; Fri, 05 May 2023 02:37:01 -0400 Original-Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-3f4000ec6ecso13901135e9.0 for <63260@debbugs.gnu.org>; Thu, 04 May 2023 23:36:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683268613; x=1685860613; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=muMVkuDjUJnbCXQ5xzbwGDFZqnkk6JiTlkjExwWCLMw=; b=AxkcA66k9SOlYjRJ84HV9yuPMfuL6WICmh3Wr18jE6F+8H2NoSC61oUSnPVELv6lbM pNhMqXuetbxPbpC8EZ6P3DoVWyb8c2MOEsJNFoq7Hn7J1HayVfxk1VSopMuuvU6HLRUg 53I73iBw/TEsJSJ+eA2nz8DhyDyB5VcLCa9Xn/4/JhiDq7awuK4tZQcmutIH3Y8Bep0r 5pzU7VHmaaZn/IZiQja28yHaAcPp4q6H/oIrvpf3On0ZZmY7FDkIJxTjWWtQnr30N+Ab 94c0+S6GtOIP2GOmrl5nDBmAtlEO+RzGWJmrpmtyCcQTrMYLDrmOqyBfDXD4ingV/5Ru 7Wog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683268613; x=1685860613; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=muMVkuDjUJnbCXQ5xzbwGDFZqnkk6JiTlkjExwWCLMw=; b=QoQb2DcltwQbZZaA7yOg6XTj5v5+m+JHgKtN9GvM4v4bGeSzYMwHiuTOeIHAnYX0ow L8VUzwaxRAHJ2/erBhxpIl/XdDtWEynQO07ZY9366YELt7xCCWvhiMmQ/2GCWsFvDm4f k6iX6izbgTM0H0IVQ6sQHU0URUsjSU7qv9GeAp7FirUn8CQFY3dii0L/nYvvTjWUbD3Z qY/ju8gvD/ecZpill5SHABBriOy44m+sNJRNCajzM9ZsYtKYMHg2AcXSpR8aTDfc3dTV iFM+9bDZVY4MsNpeXzRfjd90J8XyTSKKUJntTIhJUpPAlqyY9z6G+jaZzA3nBBHV+T6a 3twQ== X-Gm-Message-State: AC+VfDwK9PEsdzTlFJyc30ruPL86z18OQ0RfLGQt7/DgppG+O7Pev9ER AyaQi8W3+p0m2wLx2H0D7qs= X-Google-Smtp-Source: ACHHUZ6fAI/Yu3QvoTa3Ne8VU53uhtcGvJKVgbG/j/75XzKyQI/uLdNUZYp60YXWMXO1b5HLt0Y3Kw== X-Received: by 2002:a5d:4a86:0:b0:306:2aea:3dff with SMTP id o6-20020a5d4a86000000b003062aea3dffmr626231wrq.31.1683268612804; Thu, 04 May 2023 23:36:52 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id s7-20020a1cf207000000b003e91b9a92c9sm6996773wmc.24.2023.05.04.23.36.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 23:36:52 -0700 (PDT) In-Reply-To: <87zg6kysao.fsf@tcd.ie> (Basil Contovounesios's message of "Thu, 04 May 2023 18:28:47 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261066 Archived-At: >>>>> On Thu, 04 May 2023 18:28:47 +0200, Basil Contovounesios said: Basil> Robert Pluim [2023-05-04 17:15 +0200] wrote: >>>>>>> On Thu, 04 May 2023 12:15:15 +0200, Basil Contovounesios via "B= ug reports for GNU Emacs, the Swiss army knife of text editors" said: >>=20 Bug> This change: >>=20 Basil> Prevent generating empty autoload files Basil> dd21003878d 2023-04-30 18:42:58 +0200 Basil> https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3Ddd21003878d >>=20 Basil> seems to have reintroduced the following issue: >>=20 Basil> https://lists.gnu.org/r/emacs-devel/2022-06/msg00563.html >>=20 Basil> First start Emacs 29 (or 30) with a clean slate: >>=20 Basil> $ cd "$(mktemp --directory)" Basil> $ export HOME=3D"${PWD}" XDG_CONFIG_HOME=3D"${PWD}/.config" Basil> $ emacs >>=20 Basil> Then try to install the sicp package (which lacks autoloads) fro= m MELPA: >>=20 Basil> 0. C-x b RET Basil> 1. (setq package-archives '(("melpa" . "https://melpa.org/packag= es/"))) Basil> C-x C-e Basil> 2. M-x package-install RET sicp RET Basil> 3. C-h e Basil> 4. C-M-S-v >>=20 >> Only when `package-quickstart' is non-nil, right? Basil> No, this is in an empty user-emacs-directory, i.e. with the defa= ult Basil> package-quickstart =3D nil. Besides, package-quickstart does no= t come Basil> into play during package-install AFAICT. Right. My testing was faulty Basil> This does not address the file-missing error during package acti= vation, Basil> but it allows a subsequent package-quickstart-refresh to complete Basil> (albeit with a warning in a *Compile-Log*): The file-missing error is expected, no? That=CA=BCs why the autoloads loading is wrapped in `with-demoted-errors'. Although if the message bothers you, I guess we could check `file-exists-p' for it. Basil> Compiling file /tmp/tmp.6cdF8paE0K/.emacs.d/package-quickstart= .el Basil> at Thu May 4 18:24:07 2023 Basil> Entering directory =E2=80=98/tmp/tmp.6cdF8paE0K/.emacs.d/=E2= =80=99 Basil> package-quickstart.el:4:2: Warning: Empty let body Basil> due to the following generated contents of package-quickstart-fi= le: Basil> (let ((load-true-file-name nil)(load-file-name nil)) Basil> ) I=CA=BCd claim ENOCOFFEE for the last patch, but it was not the morning :-) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 0919ce34448..4b488281b78 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -4491,11 +4491,11 @@ package-quickstart-refresh (insert ";;; Quickstart file to activate all packages at startup -*= - lexical-binding:t -*-\n") (insert ";; =C2=A1=C2=A1 This file is autogenerated by `package-quic= kstart-refresh', DO NOT EDIT !!\n\n") (dolist (pkg package--quickstart-pkgs) - (let* ((file - ;; Prefer uncompiled files (and don't accept .so files). - (let ((load-suffixes '(".el" ".elc"))) - (locate-library (package--autoloads-file-name pkg)))) - (pfile (prin1-to-string file))) + (when-let* ((file + ;; Prefer uncompiled files (and don't accept .so file= s). + (let ((load-suffixes '(".el" ".elc"))) + (locate-library (package--autoloads-file-name pkg))= )) + (pfile (prin1-to-string file))) (insert "(let ((load-true-file-name " pfile ")\ \(load-file-name " pfile "))\n") (insert-file-contents file) Robert --=20