From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63337: [PATCH] package-vc--build-documentation: Fix relative @include statements Date: Fri, 12 May 2023 22:47:11 -0700 Message-ID: <87lehs93q2.fsf@breatheoutbreathe.in> References: <87fs89qg9y.fsf@breatheoutbreathe.in> <87cz3cea4k.fsf@posteo.net> <87pm7c7zfs.fsf@breatheoutbreathe.in> <83zg6gc5yp.fsf@gnu.org> <87sfc8gd9s.fsf@posteo.net> <87fs877tgz.fsf@breatheoutbreathe.in> <875y936iec.fsf@posteo.net> <87y1lyhbfy.fsf@breatheoutbreathe.in> <83sfc6azol.fsf@gnu.org> <87bkitgj3c.fsf@breatheoutbreathe.in> <87lehwfzli.fsf@posteo.net> <87a5ybsjum.fsf@breatheoutbreathe.in> <87y1luvxzv.fsf@posteo.net> Reply-To: Joseph Turner Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34982"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63337@debbugs.gnu.org, Eli Zaretskii To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 13 07:54:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pxiCo-0008v2-Ui for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 May 2023 07:54:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxiCh-0007Ft-Uo; Sat, 13 May 2023 01:54:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxiCg-0007Fg-B1 for bug-gnu-emacs@gnu.org; Sat, 13 May 2023 01:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pxiCg-00033I-28 for bug-gnu-emacs@gnu.org; Sat, 13 May 2023 01:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pxiCf-0000Dy-UE for bug-gnu-emacs@gnu.org; Sat, 13 May 2023 01:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 May 2023 05:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63337 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63337-submit@debbugs.gnu.org id=B63337.1683957229843 (code B ref 63337); Sat, 13 May 2023 05:54:01 +0000 Original-Received: (at 63337) by debbugs.gnu.org; 13 May 2023 05:53:49 +0000 Original-Received: from localhost ([127.0.0.1]:35424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxiCT-0000DX-4c for submit@debbugs.gnu.org; Sat, 13 May 2023 01:53:49 -0400 Original-Received: from out-61.mta0.migadu.com ([91.218.175.61]:39820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxiCQ-0000DO-Ig for 63337@debbugs.gnu.org; Sat, 13 May 2023 01:53:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1683957225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IcjmeB0Vy1B58XPZBRDvnbLIDQ3QehBzvZcox8rO630=; b=hyDjBzPE2YzaP+GmhLVwh2uh209ctNKipTwvrJ9/VvtxGg8mHdLadETfEoWOucrnLtNaXU fJraeiRSTNYgVgiA0xhM8L3QjTtvoNLKreMTksoDv8XAkkoI0hah5Nvkd0m04QT07bPiLf NELPSWWKrtG97ccqzU+ifh++NBInvdc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <87y1luvxzv.fsf@posteo.net> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261661 Archived-At: Philip Kaludercic writes: > Oh, and a big problem is that the "dir" file is written into the wrong > directory. It has to be located in the root directory of the package, > not in docs/ (in the case of org-transclusion). Sadly adjusting the > second argument doesn't fix the issue: > > diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el > index e9794eac783..9876705e57f 100644 > --- a/lisp/emacs-lisp/package-vc.el > +++ b/lisp/emacs-lisp/package-vc.el > @@ -369,7 +369,8 @@ package-vc--build-documentation > (message "Failed to build manual %s, see buffer %S" > file (buffer-name))) > ((/=3D 0 (call-process "install-info" nil t nil > - output (expand-file-name "dir"))) > + output > + (expand-file-name "dir" (package-desc-dir pk= g-desc)))) > (message "Failed to install manual %s, see buffer %S" > output (buffer-name))) > ((kill-buffer)))) > > > While the entry does appear in (dir) Top, the file cannot be opened: > > Info-find-file: Info file =E2=80=98org-transclusion=E2=80=99 does not e= xist; consider installing it IIUC, you're saying that default-directory needs to be (package-desc-dir pk= g-desc) when install-info runs, right? Perhaps we should revisit the first patch I sent: - leave default-directory as-is - pass "-I docs-directory" to makeinfo If makeinfo starts including more directory besides the working directory in the future, I think it will still make sense to append the docs-directory to the search path.