From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#62762: 'make' often errors with "Org version mismatch" after pulling a new version of the code Date: Tue, 27 Jun 2023 10:59:57 +0000 Message-ID: <87leg5i30y.fsf@localhost> References: <17b74a48-94e1-9106-cc79-d31972313910@gutov.dev> <87pm7vt0mx.fsf@localhost> <87cz3k8i27.fsf@localhost> <87sfcfdldt.fsf@localhost> <87bkj1g10g.fsf@localhost> <1c5d0ff0-5bae-1123-d2f7-64d9013fbc0f@gmail.com> <6070e598-7dee-1b7a-7f97-26a90618cb7a@gmail.com> <5603ba14-8120-cf38-05ba-4435c1bece3f@gmail.com> <03d0e4f4-3855-fa3e-d502-bee77ea53b74@gmail.com> <875y93kujy.fsf@localhost> <2e6ea8c1-19fb-298a-1336-27b09925d8a0@gmail.com> <871qi2mlnc.fsf@localhost> <0c4df525-8192-86d2-ece4-564c6726ec82@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9496"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62762@debbugs.gnu.org, bzg@gnu.org, dmitry@gutov.dev, Stefan Monnier , Alan Mackenzie , Eli Zaretskii To: Max Nikulin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 27 12:56:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qE6Ms-0002Ce-Vo for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Jun 2023 12:56:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qE6Mf-0003Mu-Bn; Tue, 27 Jun 2023 06:56:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qE6Md-0003MR-3m for bug-gnu-emacs@gnu.org; Tue, 27 Jun 2023 06:56:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qE6Mc-0008SK-RY for bug-gnu-emacs@gnu.org; Tue, 27 Jun 2023 06:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qE6Mc-0007gv-DU for bug-gnu-emacs@gnu.org; Tue, 27 Jun 2023 06:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Jun 2023 10:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62762 X-GNU-PR-Package: emacs Original-Received: via spool by 62762-submit@debbugs.gnu.org id=B62762.168786331129502 (code B ref 62762); Tue, 27 Jun 2023 10:56:02 +0000 Original-Received: (at 62762) by debbugs.gnu.org; 27 Jun 2023 10:55:11 +0000 Original-Received: from localhost ([127.0.0.1]:47731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qE6Lm-0007fl-ON for submit@debbugs.gnu.org; Tue, 27 Jun 2023 06:55:11 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:46551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qE6Lk-0007fR-5b for 62762@debbugs.gnu.org; Tue, 27 Jun 2023 06:55:09 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 9F34E240104 for <62762@debbugs.gnu.org>; Tue, 27 Jun 2023 12:55:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1687863302; bh=828KHW9oI5Y8MILk/teyiA2+9PQbtCUs4Bylhf2jREI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=ecegc3/PZfGq3qlyNtbLEo3n+pjbL6+de/x5xYQZSjU0gGyu9pOLfTGfXA9qRK52M 5EEuBQy4JUwy6vnzKOkODg/DBf13gta2pokVB7gRl1jjyPv+LcGgppfFvxyp4D/q/m /QyscxchAojvfXnl9eaX1DL439NyXObaOhgIMzWcCRxC84fgmS9JU9G46lY+F5iYKy COojmjqGYC29/weBwATB1Y340araQemrSRsUzbkcxZa2t3FzCRTWHAYngCfWeHQiOw BdElPh2egGbZf+PT1eUhaYqpG01R0N+mq7U8qq9+8/CY1lenxdnnBsX0unGuWkd2Tj SZyO4P+zWcoHw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Qr1nd1TgWz9rxN; Tue, 27 Jun 2023 12:55:00 +0200 (CEST) In-Reply-To: <0c4df525-8192-86d2-ece4-564c6726ec82@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264142 Archived-At: Max Nikulin writes: > On 23/06/2023 19:02, Ihor Radchenko wrote: >> 1. Use `org-reload' instead of load-dir test. > > Just a reminder: directory test may catch the case with shadowing by Ort > that is not compiled. Version comparison is unable to detect it. Yeah, you are right. We may need to combine both the approaches with shadow require and version check. I will look further into this. >> I do not think that we should throw and error. `org-reload' approach >> should hopefully solve the problem with mixed versions. > > Have you tested compilation with Org already loaded to Emacs <= 28? Do you know how to do it? Our previous reproducers involved M-x package-install, but I am not sure how to test it without ELPA release. >> P.S. I am not sure how to approach this patch in a view of the Emacs >> release process. > Are there other consequences of your changes for incremental rebuilds in > Emacs source tree besides converting error to warning? There are no consequences at all. The whole check is completely bypassed in Emacs tree. Even the warning is suppressed. See `org--inhibit-version-check'. > My impression is that the most wide spread case is installing the Org > ELPA package should just work in Emacs-29. I am unsure concerning > precise scenario for spacemacs. I have not idea if shadowing by > correctly compiled Org is a frequent issue. Are there other cases > affecting significant number of users and what is behavior for them? Installing is not the concern. My concern is introducing major changes right ahead for the release. My question was aimed at the Emacs devs here. > Current warning is so long that it may confuse users who sees only its > final part. You are right. I will think how to approach this. I am considering: 1. Move most the warning to dedicated manual section. 2. Display additional short warning at the bottom. I am now leaning towards (1). -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at