From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.bugs Subject: bug#64406: [PATCH] Improve commands to manage Python imports Date: Fri, 07 Jul 2023 19:46:00 +0200 Message-ID: <87lefr399j.fsf@gmail.com> References: <874jmnbd5v.fsf@gmail.com> <87pm534puk.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36809"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64406@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 07 19:47:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHpYG-0009HX-Vx for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Jul 2023 19:47:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHpXv-0002S1-I4; Fri, 07 Jul 2023 13:47:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHpXr-0002Rh-0w for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 13:47:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qHpXq-00085J-M0 for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 13:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qHpXq-0005GZ-0D for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 13:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jul 2023 17:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64406 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64406-submit@debbugs.gnu.org id=B64406.168875197520192 (code B ref 64406); Fri, 07 Jul 2023 17:47:01 +0000 Original-Received: (at 64406) by debbugs.gnu.org; 7 Jul 2023 17:46:15 +0000 Original-Received: from localhost ([127.0.0.1]:43699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHpX4-0005Fc-LM for submit@debbugs.gnu.org; Fri, 07 Jul 2023 13:46:14 -0400 Original-Received: from mail-wr1-f43.google.com ([209.85.221.43]:57704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHpWy-0005FL-Bx for 64406@debbugs.gnu.org; Fri, 07 Jul 2023 13:46:12 -0400 Original-Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3143b88faebso2367740f8f.3 for <64406@debbugs.gnu.org>; Fri, 07 Jul 2023 10:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688751962; x=1691343962; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=TatL8UlyHndUnFKxVQFZbkqk3iqUrHRWwiZI9o8faug=; b=OWVuh1D2OSh5nY1wtarImZpJC86UbILsdrm8ps2jKiimVDZrfsaJgJHP3DkpK/poMC pYjMvswOy4UXiovet9YnBSwK2VXRt3Vnqd2nJWm0rT0lEw7kVgxr41ZHmqJWqgw0Mcui Dqh4c35KAd7uQo2T9GxZPMbRTY4oRmYh3psNfPFpvnCurJbSeC6OVyAamG7S60ibhcXh vGkJzbkiFHahl9qyrUn83auCArBCieqgu9CkCEC1eWnBAz9cEwoHFdYZK6e65kNpuy8A IQ+v8pZ6tfq7ExK0hI/BAa/83iSeaKIHXs91OjeNx/kVjyQloKOIlhKlY7bftAAIJp49 1wlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688751962; x=1691343962; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TatL8UlyHndUnFKxVQFZbkqk3iqUrHRWwiZI9o8faug=; b=WPk5cvz0xumb6trFu2l8usoIrElHSX6NbudzTLQ981M5TqvI48PyPYNQTHTfR4qsnD Q0NZwz+5xuJGEwApBlGaILuMcm39+dxjHQIclf6UhabHGC5Zy1FQkI7VM5jvzXoH9D1U bQx1zL9rYnKxxeiGvIQBqUTMjjRKekFiCvExHe8AW6MQo5cCd2NJkiNZsLzYmVEe8IpV YYbp/aHwLx6hoK7qB2tBV97znMkDI/2ktZfgpsPzi9Ah+ULoWcGXbtBlE9Q1j53oLltb TO5zCjPfaVmR0sdHI8gSEJCKVJy9JfNksn2YU+AAJI/vPrdFf3OiaeuunZcGUv5oQuey f7zw== X-Gm-Message-State: ABy/qLZU9qiNWXC5Mkpc7uL1AqIr4MaygZVEMbnNwWxq60jWNpuhjDHJ EcODg3RhiF50k92OllqVXs0hKs5NfND8TQ== X-Google-Smtp-Source: APBJJlGfXuzyErVNrH/byOQoDqndmBN96nnZAzg2F25gEHFZrsLN3OP8Ufi9W4kDiebZqbvdN3visg== X-Received: by 2002:adf:ec90:0:b0:314:545f:6e94 with SMTP id z16-20020adfec90000000b00314545f6e94mr4722895wrn.65.1688751962005; Fri, 07 Jul 2023 10:46:02 -0700 (PDT) Original-Received: from carbon.localdomain ([2a01:e0a:245:c850:98f5:429a:aa8e:95bb]) by smtp.gmail.com with ESMTPSA id s15-20020a5d510f000000b00304adbeeabbsm4944193wrt.99.2023.07.07.10.46.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 10:46:01 -0700 (PDT) In-Reply-To: <87pm534puk.fsf@gmail.com> (Augusto Stoffel's message of "Fri, 07 Jul 2023 19:02:27 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264739 Archived-At: Augusto Stoffel writes: > On Sat, 1 Jul 2023 at 22:16, Matthias Meulien wrote: > >> -from sys import argv, stdin >> +from sys import argv, exit, stdin > > FWIW, exit is already in the global namespace. Yes but it isn't meant for use in programs; The documentation says: The *note site module (which is imported automatically during startup, except if the -S command-line option is given) adds several constants to the built-in namespace. They are useful for the interactive interpreter shell and should not be used in programs. >> - (unless (eq 0 status) >> + (cond >> + ((eq 1 status) >> (error "%s exited with status %s (maybe isort is missing?)" >> python-interpreter status)) >> + ((eq 2 status) >> + (error "%s exited with status %s (maybe isort version is <5.7.0?)" >> + python-interpreter status))) > > This change implies that the "success" branch may run if the exit code > is nonzero (without knowing all the isort internals, it can't be > excluded that an exit code > 2 is used somewhere). I suggest instead a > (pcase status ...) to construct the " (maybe... ?)" segment of the error > message. Thanks, I'll fix this. > We could also take this opportunity to distinguish between random > exceptions happening in the script (which likely leads to exit code 1) > and the ModuleNotFoundError case. Good point, I'll improve this too. -- Matthias