From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64686: 30.0.50; Tar mode @PaxHeader bug Date: Fri, 28 Jul 2023 12:04:27 +0200 Message-ID: <87lef0fj2s.fsf@epfl.ch> References: <83fs59n406.fsf@gnu.org> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13104"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Devon Sean McCullough , 64686@debbugs.gnu.org, Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 28 12:43:52 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPKwp-0003Hp-U0 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Jul 2023 12:43:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qPKLH-0003Ab-Uj; Fri, 28 Jul 2023 06:05:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPKLG-0003AQ-CE for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 06:05:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qPKLG-0000uP-4E for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 06:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qPKLF-0006gR-P3 for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 06:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jul 2023 10:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64686 X-GNU-PR-Package: emacs Original-Received: via spool by 64686-submit@debbugs.gnu.org id=B64686.169053867825661 (code B ref 64686); Fri, 28 Jul 2023 10:05:01 +0000 Original-Received: (at 64686) by debbugs.gnu.org; 28 Jul 2023 10:04:38 +0000 Original-Received: from localhost ([127.0.0.1]:43736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPKKs-0006fo-6h for submit@debbugs.gnu.org; Fri, 28 Jul 2023 06:04:38 -0400 Original-Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:62873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPKKp-0006fa-LC for 64686@debbugs.gnu.org; Fri, 28 Jul 2023 06:04:36 -0400 Original-Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-51e28cac164so6658939a12.1 for <64686@debbugs.gnu.org>; Fri, 28 Jul 2023 03:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1690538670; x=1691143470; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=1ntpYx7q0xB1w5cmRZzYIfmL1zF0wu9LRoGq6aomYKk=; b=cC6zJlNcnnjUSRJfMDwMk9G/pHAJss5RdL5NUrOmGfQzIzTBhEwAJNpz4VlzVME2Y2 80hvGGxq+djAJd1tvYltK0SvlQ49hViTE+ntCn5Okldw9KzKKgv/5vgzXJ2Eqq6OtMlX ZRmu8IgfMCVNkE17XVtCWx27S4hhzyoqeWia1TbiIYYYiL0WymvC+OURL+fGkJaU52X6 LGQh8B9HOC0UFMEckA0MsIKGjHXfn5c+VijoKgxd3o/anmSz+n2eTX9OE3Oama2AKjds wRxCrjB9uvPce0jIx7uZSFVS9mazJXprh/rPB4dquUC5d3OiS1WAYFRK3djDXaaxjZY6 KKQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690538670; x=1691143470; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1ntpYx7q0xB1w5cmRZzYIfmL1zF0wu9LRoGq6aomYKk=; b=NbtJyN4O3Qh61lMJFTocrWal5ptsoEmjyCmRS5JpR6gNtJtlbvf1sJ3Zzvsu7nVm8n zDKVcMmD+02xoTe5UT99VlM8pMqT8E2QX7gJ0THqUDrK9WPYd+EMJ4s9X4ofYxMO5Kmd 1+p0ICuiO7uBbxlacEJwB6Hf/IWFTOkx6VVGCuywhHQbpu24bKnYFMwYJQXA/glJJf+N lGIRYDF/CkcpyATPonDTn3VSbfyooOmbyPjzcUwZYIHeZMVvn3e4bJ6i9kgsvhsHMlr0 Mx5SBhtmExTRWfWoi23f2HlHki2mgw7rDXN16sU/n4Bt5sI3WBPUjC9FwaVsNH23+Xh+ 9E/g== X-Gm-Message-State: ABy/qLZUggR13oi1QJHXKX4UuF6QqyOrZdRzpkvT4XpTvzhTyLypC/eR pBhA0lNGOzwxkAMJUTXBkHMoZg== X-Google-Smtp-Source: APBJJlHrOCOos5Jpe/QvKXx+w1fn8W7t5+CpYXWzd9f/xJ8sN7t61iD7ufbJX6RWuJYTVJnvmrc1zA== X-Received: by 2002:aa7:d446:0:b0:521:d2ab:e4df with SMTP id q6-20020aa7d446000000b00521d2abe4dfmr1975420edr.19.1690538669844; Fri, 28 Jul 2023 03:04:29 -0700 (PDT) Original-Received: from localhost ([2001:620:618:590:2:80b3:0:e5c]) by smtp.gmail.com with ESMTPSA id z19-20020aa7cf93000000b005223f398df1sm1585521edx.91.2023.07.28.03.04.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 03:04:29 -0700 (PDT) In-Reply-To: <83fs59n406.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 Jul 2023 11:38:17 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266254 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii [2023-07-27 11:38 +0300] wrote: > Should be fixed now on the master branch. Thanks, but doesn't tar-parse-pax-extended-header mutate tar-attr-vector, which is initialised with a constant vector? E.g. (aset [nil] 0 nil) would normally result in: Warning: =E2=80=98aset=E2=80=99 on constant vector (arg 1) Is this a welcome change? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=tar.diff diff --git a/lisp/tar-mode.el b/lisp/tar-mode.el index e4ea95343e0..2b6329fecc3 100644 --- a/lisp/tar-mode.el +++ b/lisp/tar-mode.el @@ -255,15 +255,14 @@ pax-decode-string (decode-coding-string str coding) str)) -(defvar tar-attr-vector '[nil nil nil nil nil nil nil nil]) +(defvar tar-attr-vector (make-vector 8 nil)) (defun tar-parse-pax-extended-header (pos) "Parse a pax external header of a Posix-format tar file." (let ((end (+ pos 512)) (result tar-attr-vector) (coding 'utf-8-unix) attr value record-len value-len) - (dotimes (i 8) - (aset result i nil)) + (fillarray result nil) (goto-char pos) (while (and (< pos end) (re-search-forward pax-extended-attribute-record-regexp --=-=-= Content-Type: text/plain Thanks, -- Basil --=-=-=--