unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: LdBeth <andpuke@foxmail.com>, 64977@debbugs.gnu.org
Subject: bug#64977: 29.1; `auth-source-macos-keychain-search' handles :user key incorrectly
Date: Sat, 12 Aug 2023 13:39:56 +0200	[thread overview]
Message-ID: <87leegqyk3.fsf@gmx.de> (raw)
In-Reply-To: <831qg8g37f.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 12 Aug 2023 09:55:00 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

Hi Eli,

>> Finally I get some time looking at this issue.
>>
>> I think the bug is caused by `auth-source-macos-keychain-search-items'
>> forget the fact that :users can be a list of string instead of a string.
>>
>> The `auth-source-macos-keychain-search-items' also did
>> not handle the protocol argument correctly. The `security' command
>> needs the "-r" argument to be a string of 4 characters. This is also
>> fixed in the patch attached.
>
> Michael, any comments to the problem and the patch?

The change in :user seems to be OK. I cannot comment the change in
:port, because I don't use macOS, and cannot test anything.

Best regards, Michael.





  reply	other threads:[~2023-08-12 11:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-31 15:46 bug#64977: 29.1; `auth-source-macos-keychain-search' handles :user key incorrectly LdBeth
2023-08-02 13:22 ` J.P.
2023-08-08 22:20 ` LdBeth
2023-08-12  6:55   ` Eli Zaretskii
2023-08-12 11:39     ` Michael Albinus [this message]
2023-08-12 12:55       ` LdBeth
2023-08-12 13:14         ` Michael Albinus
2023-08-12 15:40           ` LdBeth
2023-08-12 16:02             ` Michael Albinus
2023-08-12 19:02               ` LdBeth
2023-08-13 16:34                 ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87leegqyk3.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=64977@debbugs.gnu.org \
    --cc=andpuke@foxmail.com \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).