From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#62812: [PATCH] Re: bug#62812: 29.0.60; Persistent article cache not working properly Date: Wed, 23 Aug 2023 09:47:17 -0700 Message-ID: <87lee1hfje.fsf@ericabrahamsen.net> References: <87cz4814gs.fsf@gmx.net> <87y1mmdex6.fsf_-_@gmx.net> <87v8d57uc0.fsf@gmx.net> <833509svzg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28783"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Andrew G Cohen , 62812@debbugs.gnu.org, James Thomas To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 23 18:48:33 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qYr1w-00074R-JO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Aug 2023 18:48:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qYr1k-0007KM-In; Wed, 23 Aug 2023 12:48:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYr1T-0006Yc-3J for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 12:47:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qYr1S-0005p0-Qr for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 12:47:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qYr1V-00017G-UH; Wed, 23 Aug 2023 12:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Wed, 23 Aug 2023 16:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62812 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 62812-submit@debbugs.gnu.org id=B62812.16928092524162 (code B ref 62812); Wed, 23 Aug 2023 16:48:01 +0000 Original-Received: (at 62812) by debbugs.gnu.org; 23 Aug 2023 16:47:32 +0000 Original-Received: from localhost ([127.0.0.1]:35025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYr11-000152-NR for submit@debbugs.gnu.org; Wed, 23 Aug 2023 12:47:32 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:44074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYr0y-00014p-CI for 62812@debbugs.gnu.org; Wed, 23 Aug 2023 12:47:30 -0400 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id CEE93FA07E; Wed, 23 Aug 2023 16:47:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1692809239; bh=2qiS73JTB1gwvGSpcQvA1SWJe6IXnFILZ9I/7gVHXIA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=G5K1P5P++CeAprVpwC8Ut4T62M8o0zpAavuYzrPMda1j254lXV+azPkZbhbSsS144 edD54kMWcHaSWIfxi4sMQIPjF2BHtLKQz7NreD+zFbyOXUIOPTrtv+740DslAsYFfX sT9aFOFKWsXVHOhpwvaO5oCWW/c6+LCPO8srNNwE= In-Reply-To: <833509svzg.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 23 Aug 2023 16:56:35 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268259 Archived-At: Eli Zaretskii writes: >> From: James Thomas >> Date: Wed, 23 Aug 2023 19:07:51 +0530 >> >> James Thomas wrote: >> >> > Turned out to be a trivial fix: >> > >> > diff --git a/lisp/gnus/nnmail.el b/lisp/gnus/nnmail.el >> > index e8f157392d4..904b564409a 100644 >> > --- a/lisp/gnus/nnmail.el >> > +++ b/lisp/gnus/nnmail.el >> > @@ -667,7 +667,9 @@ nnmail-parse-active >> > (cond ((symbolp group) >> > (symbol-name group)) >> > ((numberp group) >> > - (number-to-string group)))) >> > + (number-to-string group)) >> > + ((stringp group) >> > + group))) >> > (if (and (numberp (setq max (read buffer))) >> > (numberp (setq min (read buffer)))) >> > (push (list group (cons min max)) >> >> And it'll merely make it the same as this already-existing code >> elsewhere: >> >> diff -u --label ./lisp/gnus/gnus-start.el --label \#\ ./lisp/gnus/gnus-start.el /tmp/buffer-content-IYvzRp >> --- ./lisp/gnus/gnus-start.el >> +++ # >> @@ -2149,8 +2149,6 @@ >> (number-to-string group)) >> ((symbolp group) >> (symbol-name group)) >> - ((stringp group) >> - group))))) >> (numberp (setq max (read cur))) >> (numberp (setq min (read cur))) >> (null (progn >> >> -- > > Eric, Andrew: any comments? Yes! This looks like a correct fix to me.