From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#64799: [PATCH] Add 'project-prompt-key' face Date: Wed, 23 Aug 2023 21:05:51 +0530 Message-ID: <87lee13h60.fsf@gmail.com> References: <87zg3nqbuc.fsf@protesilaos.com> <87wmyqhhig.fsf@posteo.net> <874jluspp4.fsf@protesilaos.com> <87sf9ehgoi.fsf@posteo.net> <874jlt7t4f.fsf@protesilaos.com> <0e8dbebf-c0cb-01db-8a01-c7c7a165b826@gutov.dev> <87sf9cmr4x.fsf@posteo.net> <4e277440-3c96-549e-2daf-07ecf6ea9bee@gutov.dev> <87jzun5l9p.fsf@protesilaos.com> <81b2c1d6-506e-0b9b-53fd-66658e70aa44@gutov.dev> <87ttsq2gil.fsf@gmail.com> <87pm3d3kzl.fsf@gmail.com> <355df502-0c6d-a070-119d-19daae961588@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16887"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Philip Kaludercic , 64799@debbugs.gnu.org, Protesilaos Stavrou To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 23 17:37:46 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qYpvW-0004Ev-1t for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Aug 2023 17:37:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qYpvD-00080u-5E; Wed, 23 Aug 2023 11:37:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYpul-00077v-85 for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 11:37:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qYpuk-0000M9-Pc for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 11:36:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qYpuo-0007bD-2X for bug-gnu-emacs@gnu.org; Wed, 23 Aug 2023 11:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Aug 2023 15:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64799-submit@debbugs.gnu.org id=B64799.169280496529136 (code B ref 64799); Wed, 23 Aug 2023 15:37:02 +0000 Original-Received: (at 64799) by debbugs.gnu.org; 23 Aug 2023 15:36:05 +0000 Original-Received: from localhost ([127.0.0.1]:34921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYptt-0007Zs-7a for submit@debbugs.gnu.org; Wed, 23 Aug 2023 11:36:05 -0400 Original-Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:44422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYptr-0007ZP-HU for 64799@debbugs.gnu.org; Wed, 23 Aug 2023 11:36:04 -0400 Original-Received: by mail-pl1-x644.google.com with SMTP id d9443c01a7336-1bbc87ded50so38823335ad.1 for <64799@debbugs.gnu.org>; Wed, 23 Aug 2023 08:35:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692804954; x=1693409754; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+K2ZAAZMdPjZJ27VyoFTvwHqr1c0L06BXafm8rUfpLM=; b=T4iAxrifCopM+Q+swKdt1IXvQDSix700J2C6ceIqvmQkj2EmR5pKKKUQxeI0V85L82 5h7GRFm+iJrq7C+SRY0rARwK9XM1rEuiv5GMuV1/gyX6BJ34zNZ2eseF/9Euxu+ru/66 4loBT7S3qPSTF0wCaTEBv19S6+8Fm6drN6Nl/WAvXPI8/xZcag57kw6++JSSUozfn3l2 qhL/pEMVpc7JVbikhOR7I6viUccxymU7K2DHGElVJaXo07b1eO75ypRudZCjACfUXEmS daSWT1plBp9pMHfIKS2b9qE9EIAldPPgrUwzyeMuUueMqn4mn6mN2NyPtg68ekxFfzYG klVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692804954; x=1693409754; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+K2ZAAZMdPjZJ27VyoFTvwHqr1c0L06BXafm8rUfpLM=; b=Ph1oL3aURlbTTCiVdvxaIHkTIdXkeVQiBS+mGrXm0ImnTtzgEUBl+Y7onpSHbe4MfT bvWcW/LvSdsOGqDZXJ8WAflPzyIKQp3q8+yvAq0uuWt9SxTqSr1byU5e+vLofGTw/2RM tFW/79lyOYSt5eg0GtjoxQkJdNRhdgX7oez6BgNCTA56MF6/rtc4pafoZDwdyxpWNNUR ZcEvq7IxycTExSoAWlgRfAyhmAwzVya3R3wY3NULM2RRAxRDvw5orNDRJuei1Ndy/bcm novVy/boQsb/P7Hu6dvRK+GOqixDEd4lLg6eXDJgIT/Nkxnl9GJRUEh0tEp4lOCScZ6a hS5Q== X-Gm-Message-State: AOJu0YzryIWguqc+zQeJi4ss2dobmKXAkf3LvDLoQWY2RHDrs6NQ5tHo yrxAe3W4VIVoJhk89I47TMo= X-Google-Smtp-Source: AGHT+IFBtWs72Nwv//kCAiCp9MxF4/V7heJf+GQcSv9vM38rKMNB4nYrDz40ET1y63486KtqxVRSqA== X-Received: by 2002:a17:902:6b47:b0:1b8:b3f0:3d57 with SMTP id g7-20020a1709026b4700b001b8b3f03d57mr9491013plt.31.1692804954278; Wed, 23 Aug 2023 08:35:54 -0700 (PDT) Original-Received: from localhost ([118.185.152.162]) by smtp.gmail.com with ESMTPSA id t8-20020a170902bc4800b001bbfa86ca3bsm11071623plz.78.2023.08.23.08.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 08:35:53 -0700 (PDT) In-Reply-To: <355df502-0c6d-a070-119d-19daae961588@gutov.dev> (Dmitry Gutov's message of "Wed, 23 Aug 2023 18:24:52 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268252 Archived-At: [=E0=AE=AA=E0=AF=81=E0=AE=A4=E0=AE=A9=E0=AF=8D =E0=AE=86=E0=AE=95=E0=AE=B8= =E0=AF=8D=E0=AE=9F=E0=AF=8D 23, 2023] Dmitry Gutov wrote: > On 23/08/2023 17:13, Visuwesh wrote: >> [=E0=AE=AA=E0=AF=81=E0=AE=A4=E0=AE=A9=E0=AF=8D =E0=AE=86=E0=AE=95=E0=AE= =B8=E0=AF=8D=E0=AE=9F=E0=AF=8D 23, 2023] Dmitry Gutov wrote: >>=20 >>> On 23/08/2023 15:18, Philip Kaludercic wrote: >>>> Would remapping help-key-binding to bold be a possible solution? >> I hope not globally. >>=20 >>> In one specific buffer? Through a hook or something? >> I was first thinking of writing an advice project--keymap-prompt to >> temporarily advice facep to return nil always in my init.el... > > We can add an option, no problem. Thanks! >>> It seems to me Visuwesh wants the brackets back as well. As user >>> option could do that. >> I would like to have it, yes. I am so bad at picking up different >> typefaces _and_ colours that if I don't have extra characters around, I >> fail to recognise the emphasis. It is embarrassing, really. > > Could you explain, then, why you customized help-key-binding to look > like default? I simply think it makes the text look too busy. I find it unnecessary to distinguish keys in *Help* buffers (and most other places), for example. > For example, the below customization would make it relatively close to > how brackets look (but of course not exactly the same): > > (set-face-attribute 'help-key-binding nil > :box '(:color "blue" :style released-button > :line-width (6 . 0))) > > And the two places where this face is most prominently used (the one > under discussion, and 'M-x describe-bindings' output) seem to use the > face fairly similarly, so it seems to make sense, no? See above. C-h b IMHO is too ugly with such a setting. > Anyway, if you want the option, can you suggest how it will be called? > Will it be just boolean? A boolean option will be fine. The facep condition can then be changed to (and NEW-OPTION (facep 'help-key-binding)).