From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#64855: 30.0.50; ERC 5.6: Make scrolltobottom less erratic Date: Mon, 30 Oct 2023 06:46:28 -0700 Message-ID: <87lebkussr.fsf__8827.49191239185$1698673678$gmane$org@neverwas.me> References: <87h6psyurb.fsf@neverwas.me> <87o7h5euo8.fsf@neverwas.me> <871qdy9hbz.fsf@neverwas.me> <87r0lja1lw.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8670"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org To: 64855@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 30 14:47:52 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qxScR-00024K-CH for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Oct 2023 14:47:51 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxSc9-0002Be-5A; Mon, 30 Oct 2023 09:47:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxSc6-0002Aq-HB for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2023 09:47:32 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qxSc5-0007x0-A3 for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2023 09:47:30 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qxScc-0004rr-73 for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2023 09:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Oct 2023 13:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64855-submit@debbugs.gnu.org id=B64855.169867363118644 (code B ref 64855); Mon, 30 Oct 2023 13:48:02 +0000 Original-Received: (at 64855) by debbugs.gnu.org; 30 Oct 2023 13:47:11 +0000 Original-Received: from localhost ([127.0.0.1]:44579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxSbm-0004qe-Tf for submit@debbugs.gnu.org; Mon, 30 Oct 2023 09:47:11 -0400 Original-Received: from mail-108-mta234.mxroute.com ([136.175.108.234]:41887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxSbl-0004qW-6V for 64855@debbugs.gnu.org; Mon, 30 Oct 2023 09:47:09 -0400 Original-Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta234.mxroute.com (ZoneMTA) with ESMTPSA id 18b80d60655000190b.001 for <64855@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 30 Oct 2023 13:46:31 +0000 X-Zone-Loop: 1e6f6bcbc27f5fda24c42ad34dbbd215e9a22a744f57 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Wh06acddRaiyoPAEkLJXZlYaM0X9KnPMl94MiaIQoxQ=; b=WVZiDWrl6hAYIOgWAgswnfWaT2 F6bm5Wp45ZO53zAT7LTMbnRSkYZyA0ZCAKQa6oXIMOk0OFdOukjJiFIEWv43meJ/GKlgVSLmgo9fp GL5X3tcsvWSsYd2/nYYssZXILNTjZj9n0xLd8k9YiL/iDRMarMjD+AD8ZIw1eCwdwObbqGHdYuupA yPXil4txKxp1GVHkFexifCFz8I9ZnRvNkPuZrEK4cK6+E27ErexN3xmdZXtD4R+hhuYQlo30yGgyj ha1LI0RRw6Cx9DF9BfKzoR/jPrkbBAOEwLrYjQD8Fcwt9DK9oeyV3HxXPqlvu25tEfPwVhBMqzjO3 xEKe193Q==; In-Reply-To: <87r0lja1lw.fsf@neverwas.me> (J. P.'s message of "Tue, 24 Oct 2023 19:15:55 -0700") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273549 Archived-At: "J.P." writes: > It seems I went a little overboard in reigning in the frequency of > scroll attempts. This has been walked back slightly in the attached > changes. > > There's also a subtle quirk that's come to light involving `point-max' > and (recenter -1) where Emacs calculates point as having drifted off > screen. We could try tackling this with something kludgey, like > decrementing point temporarily during `recenter' attempts. But that > fails if the current input ends in a newline. I've instead decided to > address this by taking a page from other Emacs libraries and setting > `scroll-step' locally to 1 if a user hasn't customized > `scroll-conservatively'. See attached. This followup was installed as e9205323e15 * Be slightly more aggressive with erc-scrolltobottom-all The bug is already closed.