From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#66908: Exposing more public nadvice API Date: Sat, 04 Nov 2023 09:58:47 +0000 Message-ID: <87lebdyh48.fsf@posteo.net> References: <878r7fw802.fsf@posteo.net> <87msvufz8n.fsf@gmail.com> <875y2ifd2c.fsf@gmail.com> <87wmuydobs.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10619"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66908@debbugs.gnu.org, Visuwesh To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 04 10:59:41 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qzDRM-0002ZY-Ni for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Nov 2023 10:59:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzDRA-0005eQ-Vh; Sat, 04 Nov 2023 05:59:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzDR9-0005eD-9g for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 05:59:27 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzDR9-0005Xc-1J for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 05:59:27 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qzDRi-0001ok-O1 for bug-gnu-emacs@gnu.org; Sat, 04 Nov 2023 06:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Nov 2023 10:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66908 X-GNU-PR-Package: emacs Original-Received: via spool by 66908-submit@debbugs.gnu.org id=B66908.16990919746920 (code B ref 66908); Sat, 04 Nov 2023 10:00:02 +0000 Original-Received: (at 66908) by debbugs.gnu.org; 4 Nov 2023 09:59:34 +0000 Original-Received: from localhost ([127.0.0.1]:32913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzDRF-0001nX-JA for submit@debbugs.gnu.org; Sat, 04 Nov 2023 05:59:33 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:51675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzDRD-0001nH-6Z for 66908@debbugs.gnu.org; Sat, 04 Nov 2023 05:59:32 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 9BE05240103 for <66908@debbugs.gnu.org>; Sat, 4 Nov 2023 10:58:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1699091928; bh=dGaEAgRCfdXVgSJ4SYUdg/zYHcEZIefU+QnhOBAA18Q=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=Qbhmg7WNmUWU9KwP2BicCiK7WYCH2VtxJubzwia3QJXM8NKQpkK56Dx2N7EVZMLpz dGI0B7baOTs6uZZV5CSb3LNSL2HDZ8kRROj16ioz1F1SQFge16efKS5PLWBCo6QDth zSXwSsk7OzJZVHCCwVSUQy8leGRgeMfCz4tjCkPEUmJS2lL+d0qYRcGLGWKhfPzMSb Do8PXxEs34yVFfUGifhraSTrLc5eHTYL4UIc7tw3nNkc67p3gWn3PM3A/vFLPeXi9B 400nrLE/50YBFFsvJduCq5mR+9V9JnPxI/0oFVRU6OjGCz6cA1d9FNrWpEir7XNH58 FH+19uxyWZBHQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SMtNl4x9vz6tsb; Sat, 4 Nov 2023 10:58:47 +0100 (CET) In-Reply-To: (Stefan Monnier's message of "Sat, 04 Nov 2023 04:13:51 -0400") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273766 Archived-At: Stefan Monnier writes: >> Sure, in Philip's package do-at-point, a function defined to "act" on >> the `thing' at point are given different arguments depending on the >> minimum number of arguments required by the function: > > Ah :-( > > So a kind of "unimplementable semantics" for DWIM purposes. > >> (pcase (car (func-arity func)) >> ^^^^^^^^^^^^^^^^^ >> (0 (funcall func)) >> (1 (funcall func (buffer-substring (car bound) (cdr bound)))) >> (2 (funcall func (car bound) (cdr bound))) >> (_ (error "Unsupported signature: %S" func))))) > > I recommend: > > (condition-case nil > (funcall func (car bound) (cdr bound)) > (wrong-number-of-arguments > (condition-case nil > (funcall func (buffer-substring (car bound) (cdr bound))) > (wrong-number-of-arguments > (funcall func))))) > > :-) > > Works with advice and other wrappers without having to worry about > `indirect-function`, autoloading, etc... The main issue here is that this checks if a function accepts up to two arguments, but we are interested in the minimal number of arguments. I guess that turning this around should work, right: (condition-case nil (funcall func) (wrong-number-of-arguments (condition-case nil (funcall func (buffer-substring (car bound) (cdr bound))) (wrong-number-of-arguments (funcall func (car bound) (cdr bound)))))) ? >>>> (func-arity (advice--cd*r (indirect-function 'xref-find-definition= s))) ;; =E2=87=92 (1 . 1) >>>> which is the right return value. It might be nice to not have to call >>>> `indirect-function' here for the "global" function but you can be a >>>> better judge of that. >>> Don't know what you mean by "global" function. >> By "global", I mean the new global function advice-cd*r or somesuch that >> might eventually be added from this discussion. > > Ah, I see. I don't think `advice-cd*r` should follow aliases in > general. But indeed, you may have an `advice` object whose > `advice-cd*r` is a symbol, whose definition is another advice object, > etc... > > Another good reason to prefer the `condition-case` approach :-) > >>> By "autoloaded" do you mean "setup to be loaded on demand but not yet >>> loaded", or do you mean "had been setup to be loaded on demand and has >>> been loaded already"? >> The former obviously. > > In that case, `indirect-function` would not see the advice, then > `func-arity` would cause the target to be (auto)loaded, during which > a previously pending advice could be installed and it would return the > dreaded (0 . many) from the advice it sees in the definition. > > Again, using `condition-case` side steps the issue. > > > Stefan