bug#67388: 30.0.50; Unintended man page buffer-name change?

bug#67388: 30.0.50; Unintended man page buffer-name change?

[Stephen Berman]

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

0. emacs -Q
1. M-x man RET cat RET
2. M-: (buffer-name)
=> "*Man cat *"

If you do the same in emacs-29, the result is:
"*Man cat*"

AFAICS this change is due to this commit:

commit 861ac933dd8aed1028edc4b9142400e3702874d5
Author:     Michael Albinus <michael.albinus@gmx.de>
Commit:     Michael Albinus <michael.albinus@gmx.de>
CommitDate: Wed Nov 1 16:54:31 2023 +0100

    Run `man' also on remote systems

If the change was intended, it should be called out in NEWS.  If it was
unintended, this patch restores the previous behavior, at least when
calling man locally (I currently can't test a remote call):


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Man-getpage-in-background patch --]
[-- Type: text/x-patch, Size: 584 bytes --]

diff --git a/lisp/man.el b/lisp/man.el
index f18e2f50b7c..3efa29d7aad 100644
--- a/lisp/man.el
+++ b/lisp/man.el
@@ -1191,8 +1191,8 @@ Man-getpage-in-background
          (man-args topic)
 	 (bufname
           (if (file-remote-p default-directory)
-              (format "*Man %s %s *" (file-remote-p default-directory) man-args)
-            (format "*Man %s *" man-args)))
+              (format "*Man %s %s*" (file-remote-p default-directory) man-args)
+            (format "*Man %s*" man-args)))
 	 (buffer (get-buffer bufname)))
     (if buffer
 	(Man-notify-when-ready buffer)

[-- Attachment #3: Type: text/plain, Size: 732 bytes --]



In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.18.0) of 2023-11-22 built on strobelfs2
Repository revision: f50e54c01e84323e2689d79864dd9d65974d4429
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101008
System Description: Linux From Scratch r12.0-63

Configured using:
 'configure -C --with-xwidgets 'CFLAGS=-Og -g3'
 PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER
PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11
XDBE XIM XINPUT2 XPM XWIDGETS GTK3 ZLIB

bug#67388: 30.0.50; Unintended man page buffer-name change?

[Stephen Berman]

On Wed, 22 Nov 2023 23:02:25 +0100 Stephen Berman <stephen.berman@gmx.net> wrote:

> 0. emacs -Q
> 1. M-x man RET cat RET
> 2. M-: (buffer-name)
> => "*Man cat *"
>
> If you do the same in emacs-29, the result is:
> "*Man cat*"
>
> AFAICS this change is due to this commit:
>
> commit 861ac933dd8aed1028edc4b9142400e3702874d5
> Author:     Michael Albinus <michael.albinus@gmx.de>
> Commit:     Michael Albinus <michael.albinus@gmx.de>
> CommitDate: Wed Nov 1 16:54:31 2023 +0100
>
>     Run `man' also on remote systems
>
> If the change was intended, it should be called out in NEWS.  If it was
> unintended, this patch restores the previous behavior, at least when
> calling man locally (I currently can't test a remote call):
>
> diff --git a/lisp/man.el b/lisp/man.el
> index f18e2f50b7c..3efa29d7aad 100644
> --- a/lisp/man.el
> +++ b/lisp/man.el
> @@ -1191,8 +1191,8 @@ Man-getpage-in-background
>           (man-args topic)
>  	 (bufname
>            (if (file-remote-p default-directory)
> -              (format "*Man %s %s *" (file-remote-p default-directory) man-args)
> -            (format "*Man %s *" man-args)))
> +              (format "*Man %s %s*" (file-remote-p default-directory) man-args)
> +            (format "*Man %s*" man-args)))
>  	 (buffer (get-buffer bufname)))
>      (if buffer
>  	(Man-notify-when-ready buffer)

Given no reponse in a week, perhaps this fell under the radar, in
particular that of Michael Albinus (added to Cc:).  Michael, if you
confirm this was just a typo, I can install the patch to save you the
effort.  If it's not a typo, then you're in a better position than me to
decide what to do.

Steve Berman

bug#67388: 30.0.50; Unintended man page buffer-name change?

[Michael Albinus]

Stephen Berman <stephen.berman@gmx.net> writes:

Hi Stephen,

> Given no reponse in a week, perhaps this fell under the radar, in
> particular that of Michael Albinus (added to Cc:).

I'm very sorry, I've overlooked this, indeed.

> Michael, if you
> confirm this was just a typo, I can install the patch to save you the
> effort.  If it's not a typo, then you're in a better position than me to
> decide what to do.

Yep, it's a typo. Please install your patch. And thanks for catching this!

> Steve Berman

Best regards, M ichael.

bug#67388: 30.0.50; Unintended man page buffer-name change?

[Stephen Berman]

On Wed, 29 Nov 2023 18:21:30 +0100 Michael Albinus <michael.albinus@gmx.de> wrote:

> Stephen Berman <stephen.berman@gmx.net> writes:
>
> Hi Stephen,
>
>> Given no reponse in a week, perhaps this fell under the radar, in
>> particular that of Michael Albinus (added to Cc:).
>
> I'm very sorry, I've overlooked this, indeed.
>
>> Michael, if you
>> confirm this was just a typo, I can install the patch to save you the
>> effort.  If it's not a typo, then you're in a better position than me to
>> decide what to do.
>
> Yep, it's a typo. Please install your patch. And thanks for catching this!

Done in commit e87644baa32 on master and closing the bug.  Thanks.

Steve Berman