From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jens Schmidt via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67005: 30.0.50; improve nadivce/comp/trampoline handling Date: Thu, 23 Nov 2023 22:36:41 +0100 Message-ID: <87leaob192.fsf@sappc2.fritz.box> References: <874jhv9921.fsf@sappc2.fritz.box> <875y24zrt1.fsf@sappc2.fritz.box> <87ttpmwuxi.fsf@sappc2.fritz.box> <877cmct4a1.fsf@sappc2.fritz.box> <87bkbmiwpf.fsf@sappc2.fritz.box> <87leap8n1z.fsf@sappc2.fritz.box> Reply-To: Jens Schmidt Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23967"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: Andrea Corallo , 67005@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 23 22:37:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6HNm-00064K-8X for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Nov 2023 22:37:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6HNc-0000rB-Uo; Thu, 23 Nov 2023 16:37:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6HNa-0000qj-ME for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 16:36:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6HNa-00064Q-ET for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 16:36:58 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r6HNe-00012J-4s for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 16:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jens Schmidt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Nov 2023 21:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67005 X-GNU-PR-Package: emacs Original-Received: via spool by 67005-submit@debbugs.gnu.org id=B67005.17007754193972 (code B ref 67005); Thu, 23 Nov 2023 21:37:02 +0000 Original-Received: (at 67005) by debbugs.gnu.org; 23 Nov 2023 21:36:59 +0000 Original-Received: from localhost ([127.0.0.1]:35249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6HNb-00011y-9q for submit@debbugs.gnu.org; Thu, 23 Nov 2023 16:36:59 -0500 Original-Received: from mr6.vodafonemail.de ([145.253.228.166]:49932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6HNY-00011g-Ui for 67005@debbugs.gnu.org; Thu, 23 Nov 2023 16:36:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-23sep; t=1700775407; bh=+JcZK/npr5H8jnBDRABwlGxRARPCWlkqqlJUCehpzLA=; h=From:To:Subject:References:Date:In-Reply-To:Message-ID:User-Agent: Content-Type:From; b=NpwyN2z0GkpcS/FUUepueudo62pU3FHia2JnGxqfg5YCv2a0G/qdKV5hxVpAhjjOk ZKQRRj2VULd1XU7rNcwZvXMAa7a23GmEWFZhdWWSeC9zPHL01jD6kQ26cJ9dCG9Xju qUNVZy/G/TkRCRMGthlR/p7lQ8tbEsfBaH0OONN4= Original-Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr6.vodafonemail.de (Postfix) with ESMTPS id 4SbrzM2JKjz1xqD; Thu, 23 Nov 2023 21:36:47 +0000 (UTC) Original-Received: from sappc2 (port-92-196-82-109.dynamic.as20676.net [92.196.82.109]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4SbrzG4ndzzHnHd; Thu, 23 Nov 2023 21:36:42 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Thu, 23 Nov 2023 11:24:59 -0500") X-purgate-type: clean X-purgate: clean X-purgate-size: 1436 X-purgate-ID: 155817::1700775403-8CFEC18D-38661951/0/0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274833 Archived-At: Stefan Monnier writes: > But this reminds me that some people do their own preload/dump, > sometimes with a crapload of extra packages, in which case the > probability that some of them use advice-add is rather high. Ok. > IIUC the the above `error` is not technically indispensable (the code > will still work mostly right, beside some issues about the docstrings > that affect only actual C-code subrs and not native-compiled subrs), so > it would be better to demote the above `error` to a warning. Eh, just used the first function that came to my mind, `warn', with the following result: Error: error ("Attempt to autoload warn while preparing to dump") mapbacktrace(#[1028 "\1\4\203\24\0\301\302!\210\300\4!\210\301\303!\210\202\35\0\301\304!\210\3\3B\262\1\211\2035\0\300\1@!\210\211A\211\262\2\2035\0\301\305!\210\202!\0\301\306!\207" [prin1 princ " " "(" " (" " " ")\n"] 7 "\n\n(fn EVALD FUNC ARGS FLAGS)"]) debug-early-backtrace() debug-early(error (error "Attempt to autoload warn while preparing to dump")) warn("Invalid pre-dump advice on %s" emacs-lisp-byte-compile) advice-add(emacs-lisp-byte-compile :before ignore) load("progmodes/elisp-mode") load("loadup.el") How would one warn during bootstrap? And would this be noticed? Or do we have a chance to distinguish Emacs-only builds from those with extra packages? Thanks.