From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66187: read-file-name unexpected behavior when MUSTMATCH is a function Date: Sat, 25 Nov 2023 22:49:48 -0800 Message-ID: <87lealm1lt.fsf@breatheoutbreathe.in> References: <87r0mni6m1.fsf@breatheoutbreathe.in> <87bkdq3nw6.fsf@web.de> <875y3yx221.fsf@breatheoutbreathe.in> <87pm260wh9.fsf@web.de> <87v8bx48ww.fsf@breatheoutbreathe.in> <87msx8sbpv.fsf@web.de> <87bkdoh1gy.fsf@breatheoutbreathe.in> <87h6ngs85e.fsf@web.de> <87ttr7nzyj.fsf@breatheoutbreathe.in> <83pm1u6f8l.fsf@gnu.org> <83fs2o2wb0.fsf@gnu.org> <83v8bj2794.fsf@gnu.org> <83r0m70zwp.fsf@gnu.org> <83sf6mzcz6.fsf@gnu.org> <878r72odzs.fsf@breatheoutbreathe.in> Reply-To: Joseph Turner Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39683"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Monnier , Eli Zaretskii , michael_heerdegen@web.de, philipk@posteo.net, 66187@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 26 08:11:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r79IY-000A9i-VV for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Nov 2023 08:11:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r79IA-0006uf-QU; Sun, 26 Nov 2023 02:10:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r79I9-0006uV-Bf for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2023 02:10:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r79I9-00028S-3s for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2023 02:10:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r79IE-0001GW-BD for bug-gnu-emacs@gnu.org; Sun, 26 Nov 2023 02:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Nov 2023 07:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66187 X-GNU-PR-Package: emacs Original-Received: via spool by 66187-submit@debbugs.gnu.org id=B66187.17009826374823 (code B ref 66187); Sun, 26 Nov 2023 07:11:02 +0000 Original-Received: (at 66187) by debbugs.gnu.org; 26 Nov 2023 07:10:37 +0000 Original-Received: from localhost ([127.0.0.1]:40647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r79Hp-0001Fh-4X for submit@debbugs.gnu.org; Sun, 26 Nov 2023 02:10:37 -0500 Original-Received: from out-180.mta0.migadu.com ([2001:41d0:1004:224b::b4]:17535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r79Hm-0001FT-2A for 66187@debbugs.gnu.org; Sun, 26 Nov 2023 02:10:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1700982626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x/GxKBnQy/r0e1fSqEODHRlS9WREa2lAspoSfH3lMiQ=; b=MNZl8Rtks/meprff8bJTjWasLTe57Tp/EeDtg7vLsKltZOCKn+hdE6vyiAMoNm0qrxJpgH 9YUyuof/0iWPB1AtAbwCHAuAALbaAP4ox7tfel4T/2/IG+Wczc+nzdwybqTDQjRgYr3L41 L7tXdZa/EvP9jDm3OJ2X72IgMbxviw0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <878r72odzs.fsf@breatheoutbreathe.in> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275037 Archived-At: Joseph Turner writes: > Stefan Monnier writes: > >>> Then I think we should install your patch on the emacs-29 branch, >>> thanks. >> >> Thanks for the vote of confidence, but as Joseph points out, the patch >> isn't actually doing what it says on the tin, so we first have to fix >> it :-) > > Here's another potential solution. While the attached patch seems to > work, I'm not sure that minibuffer-completion-confirm should be checked > in completion--do-completion instead of completion--complete-and-exit. > > Thoughts? I just ran the tests in /test/lisp/minibuffer-tests.el with this patch, and they all still pass. > Thanks! > > Joseph > > [2. text/x-diff; 0001-Fix-completing-read-functional-REQUIRE-MATCH-behavio.patch]...