From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mohsin Kaleem Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v5] Add support for colored and styled underlines on tty frames Date: Sun, 10 Mar 2024 18:10:13 +0000 Message-ID: <87le6qez5m.fsf@kisara.moe> References: <20240211180501.695192-1-mohkale@kisara.moe> <749abb29-48ab-0d72-3031-3b87fe1fce54@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16977"; mail-complaints-to="usenet@ciao.gmane.io" To: Jim Porter , 62994@debbugs.gnu.org, Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 10 19:10:47 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rjNdH-0004DC-BW for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Mar 2024 19:10:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjNd2-0000UT-9X; Sun, 10 Mar 2024 14:10:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjNcz-0000UF-CR for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 14:10:29 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rjNcz-0008Fp-4V for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 14:10:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rjNdW-0000hK-Fv for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 14:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mohsin Kaleem Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Mar 2024 18:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.17100942542667 (code B ref 62994); Sun, 10 Mar 2024 18:11:02 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 10 Mar 2024 18:10:54 +0000 Original-Received: from localhost ([127.0.0.1]:37862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjNdN-0000gt-Mh for submit@debbugs.gnu.org; Sun, 10 Mar 2024 14:10:54 -0400 Original-Received: from 119.ip-51-38-65.eu ([51.38.65.119]:52196 helo=mail.kisara.moe) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjNdH-0000ge-RS for 62994@debbugs.gnu.org; Sun, 10 Mar 2024 14:10:52 -0400 Original-Received: from mk-desktop (05408574.skybroadband.com [5.64.133.116]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mail.kisara.moe (Postfix) with ESMTPSA id D3143A2796; Sun, 10 Mar 2024 19:10:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kisara.moe; s=default; t=1710094213; bh=noCpsFik1fp9NtYc//hjlz/6h+9G8bIhiWh+7oaui8w=; h=From:To:Subject:In-Reply-To:References:Date:From; b=liuoVYhVF+TlHVwWJbt1c4SUvGTG1CNHeV6NEethQMvg/+RDFQUpBQWQ5iZucz49H 1CAfHk5qDmTVA6PHHJE3QbinBUkJKQQtVQkcSlP/9todPw5eRjqIzQ5ge913lZ+2kz +1ymMovH8CuNkaMbaDpPby7xO/q7lVvmHWjZvYlZp2ovy8b6jCtHLFtUjl+bIYNWD7 PZ6Qp1Ot5rJQpgvbA+NtFMc3CPDoA63wyqSfDHXCTGW+HjjvuT01SrlaxBJMvHuKcW h9VxpzRYqXHy81yEFxnR8Tj7BmJRUOyeZB4Ojp+BOh55HLzzY07XHzPU0XJUzhokAO h1vJiFUpZIuQg== In-Reply-To: <749abb29-48ab-0d72-3031-3b87fe1fce54@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281425 Archived-At: Jim Porter writes: > On 2/11/2024 10:05 AM, mohkale@kisara.moe wrote: >> @@ -7229,6 +7343,9 @@ syms_of_xfaces (void) >> DEFSYM (QCposition, ":position"); >> DEFSYM (Qline, "line"); >> DEFSYM (Qwave, "wave"); >> + DEFSYM (Qdouble, "double"); >> + DEFSYM (Qdotted, "dotted"); >> + DEFSYM (Qdashed, "dashed"); >> DEFSYM (Qreleased_button, "released-button"); >> DEFSYM (Qpressed_button, "pressed-button"); >> DEFSYM (Qflat_button, "flat-button"); > > This is very minor, but for consistency with the existing styles ("line" > and "wave"), maybe we should use a noun form for the new styles. For > example "dots", "dashes", and maybe "double-line"? That would hopefully > be easier for programmers to remember, and leaves the door open for some > other kind of doubled underline in the future too (e.g. a double wave). The current names were just what kitty decided to call the related underline styles [1] but no reason to stick to that. I'll update as suggested. Just to clarify wave will stay wave (instead of wavy) but the remaining will be converted to nouns. [1]: https://sw.kovidgoyal.net/kitty/underlines/ -- Mohsin Kaleem