From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69517: [PATCH] Make gnus cache work with group names having '/' Date: Sat, 16 Mar 2024 05:52:30 +0530 Message-ID: <87le6jowjd.fsf@outlook.com> References: <87wmqkcc9u.fsf@outlook.com> <86wmqbyews.fsf@gnu.org> <8734szul14.fsf@gmx.net> <874jde7j2c.fsf@ericabrahamsen.net> <87v85u5448.fsf@ericabrahamsen.net> <8734sttrxr.fsf@gmx.net> <87zfuzcscp.fsf@dsemy.com> Reply-To: James Thomas Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36934"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eric Abrahamsen , Eli Zaretskii , 69517@debbugs.gnu.org To: Daniel Semyonov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 16 01:23:39 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rlHpr-0009V4-Q8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Mar 2024 01:23:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlHpi-0008E1-MQ; Fri, 15 Mar 2024 20:23:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlHpg-0008De-Ub for bug-gnu-emacs@gnu.org; Fri, 15 Mar 2024 20:23:28 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rlHpd-0008QA-9a for bug-gnu-emacs@gnu.org; Fri, 15 Mar 2024 20:23:28 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rlHqD-0005Hw-RN for bug-gnu-emacs@gnu.org; Fri, 15 Mar 2024 20:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: James Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Mar 2024 00:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69517 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69517-submit@debbugs.gnu.org id=B69517.171054861520281 (code B ref 69517); Sat, 16 Mar 2024 00:24:01 +0000 Original-Received: (at 69517) by debbugs.gnu.org; 16 Mar 2024 00:23:35 +0000 Original-Received: from localhost ([127.0.0.1]:53910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlHpn-0005H3-0U for submit@debbugs.gnu.org; Fri, 15 Mar 2024 20:23:35 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:47577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlHpl-0005Gp-5w for 69517@debbugs.gnu.org; Fri, 15 Mar 2024 20:23:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1710548559; x=1711153359; i=jimjoe@gmx.net; bh=feNsrcWdgnSjl1o8JYNTOtkkUBmIZSqDiA06yR+TjxA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:Date: References; b=G/nsWOxHrnISd93mpSo9JYDfo+ZOnxuLoeYaMUWopXs9cDHCyVO3otj5OwL5kc41 CdvcU0kfuF1+eZsmyjXBRCQyQQKq8YnmmjXmRCQhmRoabay4SCOnIJ1b9H58kp+u+ c3iCZJtdcQunYnY1ki/JAkEnSv5gL72kRFc7baMEWxdJun0jjkwY2lFGbjfBLIOZM +Dz6XCbOhMfHeB/4zBf3Ljm2kcd76z2ngr5LxW2oNmIW6ZTO1qnWFpR/z/Ltk53Jn b7e6ajrzLaRFRe3CgixviP84MiptcNcZ4KdXco3ILLltKUgyZ/Js3vJ7LdGqwg2C3 dbxg8r3nnotG3tVp6A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from user-Inspiron-15-5518 ([59.182.112.198]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MmDIu-1r37Ne3tFw-00iBvl; Sat, 16 Mar 2024 01:22:39 +0100 In-Reply-To: <87zfuzcscp.fsf@dsemy.com> (Daniel Semyonov's message of "Fri, 15 Mar 2024 19:33:42 +0200") X-Provags-ID: V03:K1:kc2QYPIiJRprLLp/oygXfA1cU31U8avAE35WHqwFkYpq64rG+bd aicKVuAVcgz3VscwUbdxWdktN9Lbw4eCnnHOVn6XpSbhm676KfVs0qUS0ZXb7EN3+aQPmMZ Es8R6339MhM6tIPtaTCkE+z0Ykc1IDgo/SIXUQt2Mv702DkzzRY9pSFyHXKHTQ5rZaEteIp FCs+oUe9qhfN6hFfBHK0g== UI-OutboundReport: notjunk:1;M01:P0:2a1uRFs9bWk=;qvLO6aobJdnJK0lkWZbKmlvSpxG jxc9w6f6NVtnF06r+514MNFNPwZWpBq9wOYTXXIROHnE/8wToYuorZQ6iIIG3XE1LeIHi5K8e +9DvBnR+3tcN7bLf2OL6slDUdN6orRcsjMfnFcQOxC5cwE9FyWjzCl0/4822lbpMEpzaLXYEz mIG7gA/myfYsVgxl+doiaokW8nGkhpn0wVXEyrZZrGGIntbyU9slIPzDdRABcuLqJyw06EUpS 1IZ/rdt0+UQ7anLcEt0YX4gDRY0tdRdZCFS5dbFlqkHtSwlM9qTzvMsPvcXYpmdXhIP7pPyJL g2uhypvgPQcwEeMEAnP3XHzjRKNVnhgm8rdcya3UmSAvbPFuKVQqlkcaibZiO+342oOFMTaRr /sPJEjF1A1FSAp1DiHYS80AdWDDOWs5Mik2BC8HBTwaznx5pT+ibmj7H/K5V8kXEJy1gIV02V aEN/i32k/o5VV2plte1F0B3gHuHicI8rxgGJ+0wfjOjkq/W9wC+mXd19p2VKmCBsQboJF2qv9 VmzyQ8HKwr85zAdOpzEKAsdtuwxVw/Sz7VBQM+l5vLOh/Hy92iKLMKp8BFVcviM7n0ppeJt0A Sd7cQlGhvD3L9fA+q5mbWoClcv5AIiBJwATclIo3lu+bH0HJSZtBaeWcqNz3XAAM0q/x603RO XoAdsKrlUNXxjLlWc3zQGq3I9Hb0Xh5YCHAaU90TmaqWRgUCHFdLF/M3VmFlEa+P62epEfNg7 3QMprInyX0q557f7oUr+u7+NdIjW3/ond54/h9zWHl0ZYUbeyz2ZsPo1dzSsAy4gqeoHWdi3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281699 Archived-At: Daniel Semyonov wrote: >>>>>> James Thomas writes: > > > James Thomas wrote: > > >> + (if (not nnmail-use-long-file-names) > >> + (nnheader-replace-chars-in-string group ?. ?/) > >> + group)) > > > Since directory names cannot have '/' they used to be replaced by '_' in > > group names before conversion. But this makes it impossible, when > > generating (non-existent) active files to know whether a '_' in the > > directory name was _ or / originally. > > > The above patch tries a possible solution inspired from [1] but would > > break existing users of the cache or agent (xref-find-references > > "nnmail-group-pathname") who have groups with % or / in their names. > > > Seems to work in my limited testing. WDYT? > > I tested it and it seems to work, but I'm pretty sure it will also break > existing groups with % or / in their names in several backends. > For example, the `nnmh' and `nndiary' backends use this function to > locate groups on disk, which will fail for those groups (unless users > rename the files manually). I think only one of these combinations is likely to be a problem in practice: groups such as [Gmail]/Drafts. I've never seen a % in a group name. The cache wouldn't work for one with / anyway (this bug) and as far as the agent is concerned, none of the Gmail groups with spaces in them work anyway (bug#65467: note that the patch on this is also needed for the agent to work on these groups with /). I haven't used nnmh or nndiary but I don't think they normally use group names with '/'. Regards, James