From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70368: [PATCH] Use a dedicated type to represent interpreted-function values Date: Mon, 29 Apr 2024 11:05:26 +0200 Message-ID: <87le4wlesp.fsf@web.de> References: <86il0ko6f9.fsf@gnu.org> <86h6g4m29n.fsf@gnu.org> <86sezmlvht.fsf@gnu.org> <86cyqqlqkw.fsf@gnu.org> <86mspqd3a7.fsf@gnu.org> Reply-To: Michael Heerdegen Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38350"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: monnier@iro.umontreal.ca To: 70368@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 29 11:05:54 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s1MxN-0009k4-JO for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 29 Apr 2024 11:05:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s1MxD-0000Xu-Ej; Mon, 29 Apr 2024 05:05:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1MxC-0000Xk-Ao for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2024 05:05:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s1MxC-0000oy-2J for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2024 05:05:42 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s1MxV-0005Ah-Tk for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2024 05:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2024 09:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70368 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70368-submit@debbugs.gnu.org id=B70368.171438151819866 (code B ref 70368); Mon, 29 Apr 2024 09:06:01 +0000 Original-Received: (at 70368) by debbugs.gnu.org; 29 Apr 2024 09:05:18 +0000 Original-Received: from localhost ([127.0.0.1]:56049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1Mwo-0005AM-FA for submit@debbugs.gnu.org; Mon, 29 Apr 2024 05:05:18 -0400 Original-Received: from mout.web.de ([212.227.15.14]:54401) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s1Mwm-0005AC-ON for 70368@debbugs.gnu.org; Mon, 29 Apr 2024 05:05:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1714381486; x=1714986286; i=michael_heerdegen@web.de; bh=4bIZf4h0IzbeHU2nqc3WSO2au3S+FXINqlzdeyxD7QQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=vf773lg7MIRXlioYTlQq8Z0fovxCYFatdTq+jgcjcKOTbxrSdqWX7pBTv9CbTF2v wklMciHdnxgpFGBN2L6cdCN/CaO2DEwE4HzwFj2kZ6kkyhBaD32sPDp6oixIieisP rTN7UsH9ChSL+QPDd3QZLQTgJ2LzB0g9JsWgxbwNU2jTus/M8A0b8rNq2MlYqHJ94 +x/oLCfi1eKdbklumJ+rcRp1O734arg5h1ND9y0fpoJOHhAroUcPHjzuba1v8/xty Tis7XaM2++6sAisONeEmurZA6vhgWVcQ46F+23Mf3QiV4Ue4KZ1mODpMkrRA6HHqT ikXlbKAQzhyp3Uss4A== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([84.57.248.23]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M2xrs-1ry59G3804-00GOoC; Mon, 29 Apr 2024 11:04:46 +0200 In-Reply-To: (Stefan Monnier via's message of "Sun, 28 Apr 2024 12:05:58 -0400") X-Provags-ID: V03:K1:lE4OsNX8FxKa0EF0v/E5QGM7Zao88gsb5wku15sV0MJ2MGjL/ch ltiR7DMZ1YYAfXEnXYmzCmGVS1aMGKcAtEsesO+AUqZSAJvrsP8jtA7PEWp8iNKCiU3kRge RMuccCOPkAbnHaev6TaJOmitswArubkLIcr7DnIQH8a/wWfNYgbRs44kfNvqP2rZwmWLBhm AqdQNSsjTUxZG0u5mHQnw== UI-OutboundReport: notjunk:1;M01:P0:tjB7KmwElhY=;UHAJJ7WLzXVCu+Cd5s535m03Oai pnN0sNB5tZ2SgwjEgUpypmLBMu/92rwQm+SqcL7ob6MQ5t76c1lAwlBJJ/e7nQUjAqh9oO8Jb Y6B7aODckfH6AfTe9C6NOyMxvHzAWQbQudHl2XryFuXnbb3OL/kvDnHmQu6nOINogBI6CriQw aVXyULoaXPFy7nI9jr4MkDqgaVgk55qQXu+/0XYNz030JK3SMiexXA/X1cxB1tPqq+mCA2B82 N+MVQCzmxxG9lXq7BbxRTQ5M0/vHheRsAPGgRgSXQ9UaJ+rbuEZr1lXxbFbcwO1s0TfrhadKM xNdBwvR34LeNrnKp5pYw/LrKiKV+plh5m3WiwmsjbBd5mmGg1+D9kA8QvS5IL/263n4AEw4nv k4e7VnDZAaapzxrO02b50pvoOQ0GEhCDCXYkW05Yt2T+5TU36bW3Owy2nTFwMcfV1pYua02R/ s5htH3fIgY2OrIb19gsuwPRnyJHmN/gEwpBq2/8R3Zg6JCd2IIL0e/LEd/STwC1B/ezczxLHE iUzbtBxHWNYeorg+QrdzcYbL3D8jopCTpDCCNF8/V4Ip7vDivi8S20u1UjZx33cTqUqLNW75E OAK8WLqAg2bL/YgLRwOLepnVg2BM84aDY9Wq7mhEmCFrfZpaq9nbbfYUH1EnKc7REYLOMQLL3 jGfIk9iEnxBE5H+kjYcNlQshqpwHj4p+LAOBXA0ayJFcfn3duZbbTdFbyFcRUQf683iWZeMF/ qElVBfUwPc1jqT9C/fZhwiNGFF/ONxVK/WFHA64M7/MkCamgFLx25cC7zuoUDSn6Ys6avEZv X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284129 Archived-At: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Thanks, and pushed. Closing, Thanks - but seems you broke some use cases of the old defadvice - I am greeted with this *Compile Log* when starting Emacs: | Error (bytecomp): Wrong type argument: arrayp, (lambda | (ad--addoit-function &optional nopush edit) (let (ad-return-value) (setq | ad-return-value (with-no-warnings (funcall ad--addoit-function nopush | edit))) (setq ring-bell-function isearchp-orig-ring-bell-fn) | ad-return-value)) | | Error (bytecomp): Wrong type argument: arrayp, (lambda | (ad--addoit-function &optional nopush edit) (let (ad-return-value) (setq | ad-return-value (with-no-warnings (funcall ad--addoit-function nopush | edit))) (if isearchp-auto-keep-filter-predicate-flag (setq | isearchp-kept-filter-predicate isearch-filter-predicate) (setq | isearch-filter-predicate isearchp-kept-filter-predicate)) (setq | ring-bell-function isearchp-orig-ring-bell-fn) ad-return-value)) | | Error (bytecomp): Wrong type argument: arrayp, (lambda | (ad--addoit-function symbol type library) (let (ad-return-value) (prog1 | (setq ad-return-value (with-no-warnings (funcall ad--addoit-function | symbol type library))) (when (symbolp symbol) (unless (cdr | ad-return-value) (with-current-buffer (find-file-noselect library) (let | ((sn (symbol-name symbol))) (when (and (null type) (string-match | "\\`\\(hydra-[a-z-A-Z0-9]+\\)/\\(.*\\)\\'" sn) (re-search-forward | (concat "(defhydra " (match-string 1 sn)) nil t)) (goto-char | (match-beginning 0))) (cons (current-buffer) (point))))))) | ad-return-value)) | | Error (bytecomp): Wrong type argument: arrayp, (lambda | (ad--addoit-function line &optional buffer relative) (let | (ad-return-value) (let nil (setq ad-return-value (with-no-warnings | (funcall ad--addoit-function line buffer relative))) (if (and | folding-mode (or (folding-point-folded-p (point)) (<=3D (point) | (point-min-marker)) (>=3D (point) (point-max-marker)))) (let ((line line= )) | (if folding-shift-in-on-goto (progn (folding-show-all) (goto-char 1) | (and (< 1 line) (not (folding-use-overlays-p)) (re-search-forward "[ | .]" nil 0 (1- line))) (let ((goal (point))) (while (prog2 | (beginning-of-line) (if folding-shift-in-on-goto (progn | (folding-show-current-entry t t) (folding-point-folded-p goal)) | (folding-shift-in t)) (goto-char goal))) (folding-narrow-to-region (and | folding-narrow-by-default (point-min)) (point-max) t))) (if (or | folding-stack (folding-point-folded-p (point))) | (folding-open-buffer)))))) ad-return-value)) These pop up even when just loading the .el sources of libraries, e.g. folding.el or isearch+. Could you please have a look? Thx, Michael.