From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#72241: 31.0.50; [PATCH] Use a dedicated buffer for `doc-view-open-text' Date: Tue, 23 Jul 2024 14:16:24 +0200 Message-ID: <87le1sl2w7.fsf@gnu.org> References: <87jzhd4ysy.fsf@ledu-giraud.fr> <87v80xwb3d.fsf@gnu.org> <86le1t9t5p.fsf@gnu.org> <87r0blw9s5.fsf@gnu.org> <87a5i8jzpj.fsf@ledu-giraud.fr> <87ttggl7dk.fsf@gnu.org> <87frs0b9oc.fsf@ledu-giraud.fr> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35459"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 72241@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 23 14:17:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sWESP-0008xN-Mm for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Jul 2024 14:17:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWERw-0003l6-Dx; Tue, 23 Jul 2024 08:17:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWERu-0003kl-7U for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 08:16:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sWERt-0003yr-Qc for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 08:16:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sWERy-00054n-5b for bug-gnu-emacs@gnu.org; Tue, 23 Jul 2024 08:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Jul 2024 12:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72241 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72241-submit@debbugs.gnu.org id=B72241.172173700419483 (code B ref 72241); Tue, 23 Jul 2024 12:17:02 +0000 Original-Received: (at 72241) by debbugs.gnu.org; 23 Jul 2024 12:16:44 +0000 Original-Received: from localhost ([127.0.0.1]:59395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWERg-00054B-70 for submit@debbugs.gnu.org; Tue, 23 Jul 2024 08:16:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWERd-00053x-DN for 72241@debbugs.gnu.org; Tue, 23 Jul 2024 08:16:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWERS-0003wf-Ib; Tue, 23 Jul 2024 08:16:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=E68U7Qzyj4X0zs8PVwUKy/aCWgtoi8hFjPs1EH6/Z1Y=; b=kxaUjLBtexwVuU2szMOA p9nrvJs4izuTKTjxxMSwPh7W1umepFV50ns6qqPO3cR5xfaHfGTizrGk5MeYjGG35qeF5YcWvNB/b seBT/1lpuaojhWK1Dp9lfGD2BVzgw2qjuD+zzK7EKe/gh4B3Kp4sKnbuTrkA7qJ8DbibQXzGaRU9Q GbWnt2ufOq6Ra3/hOuwG6c7ZDmzX5L9o7Z3nOsrAZMxARgszXMia1RjRgQvB/OpXkcI5SuVWG4loB XYcNXuXMHvZw1jvIXd2q1VnUEm0AxRkHfpXIl2LMVv2WqpSTJcRgmvreuOrXhT4TW1Zsc8qHL4fqe zqP6R29iqtI3MA==; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrheelgdehtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfggtgesthdtredttddttdenucfhrhhomhepvfgrshhsihhl ohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrhhnpeetle dtgeehfffhteekkeevkeekvefggeekteeuffelieehkefhgfffueeugeeiffenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnodhmvg hsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedvleek qdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhmpdhnsggprhgtphhtth hopedt X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail In-Reply-To: <87frs0b9oc.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Tue, 23 Jul 2024 14:00:03 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289161 Archived-At: Manuel Giraud writes: >> Here's a state machine describing the current behavior. >> >> display <-- C-c C-c --> edit >> \ ^ >> \ \ >> C-c C-t C-c C-c >> \ \ >> `> text > > I think the current behavior is more like this (I suck at ASCII art): > > display <-- C-c C-c --> edit > \ ^ > \ /-- > C-c C-t C-c C-c > \ /-- > `> text You are right. >> However, that now one can switch between foo.pdf and foo.pdf/text >> independently, there is no guarantee that C-c C-c in the foo.pdf/text >> buffer will return to foo.pdf in "display" state. One could have >> toggled to edit state there or even killed the foo.pdf buffer, so >> there's nothing to return to. > > Yes, you're right. In the latter case (the foo.pdf buffer was killed > otherwise), a C-c C-c in the foo.pdf/text buffer just kill it, go to > another buffer and the document is not open anywhere in any form. > Maybe it is a not so bad behavior. No, I think that's ok. >> So I'd say: right now it is a state machine with 3 states but with >> Manuel's patch the current "text" state becomes an auxiliary view. > > Yes. So I'm going to try to fix my patch with your remarks (maybe fix > the info also) and come up with a NEWS entry. Thanks. Great, thanks! Bye, Tassilo