unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 73004@debbugs.gnu.org
Subject: bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems
Date: Tue, 03 Sep 2024 15:26:55 +0200	[thread overview]
Message-ID: <87le083m1s.fsf@ledu-giraud.fr> (raw)

[-- Attachment #1: Type: text/plain, Size: 712 bytes --]

Tags: patch

Hi,

Here is a patch to make `dired-do-open' work on some non GNU/Linux
systems.  I have tested it on OpenBSD with "xdg-open" installed.

Thanks,

In GNU Emacs 31.0.50 (build 19, x86_64-unknown-openbsd7.6) of 2024-09-02
 built on computer
Repository revision: 92ea393a16e5c99a8860dab368c6ca3ca6abc3c5
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101013
System Description: OpenBSD computer 7.6 GENERIC.MP#294 amd64

Configured using:
 'configure CC=egcc CPPFLAGS=-I/usr/local/include
 LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs
 --bindir=/home/manuel/bin --with-x-toolkit=no --without-cairo
 --without-compress-install'


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Make-dired-do-open-work-on-non-GNU-Linux-systems.patch --]
[-- Type: text/patch, Size: 910 bytes --]

From ab26a89395b5745c8e3d87a8907344ba774a5ca1 Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Tue, 3 Sep 2024 15:13:51 +0200
Subject: [PATCH] Make `dired-do-open' work on non GNU/Linux systems

* lisp/dired-aux.el (dired-do-open): Permit this function to
work on some non GNU/Linux systems.
---
 lisp/dired-aux.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index cd948bd7dd9..97b1e28a4ff 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -1472,7 +1472,7 @@ dired-do-open
     (when command
       (dolist (file files)
         (cond
-         ((memq system-type '(gnu/linux))
+         ((memq system-type '(gnu/linux berkeley-unix))
           (call-process command nil 0 nil file))
          ((memq system-type '(ms-dos))
           (shell-command (concat command " " (shell-quote-argument file))))
-- 
2.46.0


[-- Attachment #3: Type: text/plain, Size: 18 bytes --]

-- 
Manuel Giraud

             reply	other threads:[~2024-09-03 13:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03 13:26 Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-09-05 10:26 ` bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems Philip Kaludercic
2024-09-05 13:48   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-05 14:02     ` Eli Zaretskii
2024-09-05 14:35       ` Philip Kaludercic
2024-09-05 16:49         ` Juri Linkov
2024-09-06  7:50           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-14  7:48             ` Eli Zaretskii
2024-09-18 16:51               ` Juri Linkov
2024-09-19  3:52                 ` Howard Melman
2024-09-19  6:15                   ` Juri Linkov
2024-09-05 14:36       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87le083m1s.fsf@ledu-giraud.fr \
    --to=bug-gnu-emacs@gnu.org \
    --cc=73004@debbugs.gnu.org \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).