From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73855: [PATCH] * lisp/autorevert.el: Avoid reverting buffer in short time Date: Sat, 19 Oct 2024 11:06:41 +0200 Message-ID: <87ldyko40u.fsf@gmx.de> References: <871q0dx31n.fsf@gmx.de> Reply-To: Michael Albinus Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32378"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73855@debbugs.gnu.org To: Lin Sun Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 19 11:07:57 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t25RF-0008Ka-8x for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Oct 2024 11:07:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t25Qz-0005pp-C1; Sat, 19 Oct 2024 05:07:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t25Qx-0005oG-0u for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 05:07:39 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t25Qw-0000gB-Od for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 05:07:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=DSBS/WxIDZyGkCWbbXMuZFj8nmuR2rYyE8eJySrXVdk=; b=AmmLb6unSuxzm93JZmYdTzI8GZo9FCqFhJW1LRsMAIRFcsv2rzfDYW7yVT3i2pZ8upyLCHqFQihjq0vRMBBu+6AwI4jZRgtm4UEaKxpJFafl1jHBiysibKlMX2Z7XzD3EcpG05EV4h5iSYDz7n+nvEBOwYAK5dlgdJTbhczqTntjSXHLEiR4p0ejah5YoqtZaANoFpZjmmEqWwqDHvfAnrd7zojY5LI/HUPY+rz/DH4iCa9eYvT+1il0rR9ipmXjEHsrCDAUhFi3OCUnQjAkTTBM9hh+ksgRZ2fro1bBB7OOOXCa5DoWToaR43TEQ8LRfv/WiA2uaTRXVAezB1dfCg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t25RJ-0004S0-W9 for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 05:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Oct 2024 09:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73855-submit@debbugs.gnu.org id=B73855.172932883917051 (code B ref 73855); Sat, 19 Oct 2024 09:08:01 +0000 Original-Received: (at 73855) by debbugs.gnu.org; 19 Oct 2024 09:07:19 +0000 Original-Received: from localhost ([127.0.0.1]:41411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t25Qd-0004Qw-3l for submit@debbugs.gnu.org; Sat, 19 Oct 2024 05:07:19 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:47533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t25QX-0004Qb-IT for 73855@debbugs.gnu.org; Sat, 19 Oct 2024 05:07:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1729328803; x=1729933603; i=michael.albinus@gmx.de; bh=DSBS/WxIDZyGkCWbbXMuZFj8nmuR2rYyE8eJySrXVdk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=YjgNwGGo9N797CJUzVRHpRjtzlRiSQB8eLfLX20mINKfh9LQm2hsAMvpR0TtwtOB KxL60VG1gD1Y3c+9aaHn51C/MO6iYaDTvP475vBXgfq/i8BsIM7avX0Hd82W9vzle NGI6tW07WRhqKdqBXLCG7QsFfLe2/AvEkFoTXO3PQojoOHpBT35/cPWcupw0j/ar8 4yUlXFDh6zTIHlK0homQzeL9F+mkll3YUNlBOYGwcyVcw1QhvsUQQCh6tKKlw+Wby W/uI43bTGm3k1GOhbOWbgrdIMsaD3/sSkXZcSTmZJ8L6JxrzGLdK5jW5Rzrg43/ZA OXCyiCaArFDmjHeEfQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M8ykW-1syDH3238g-001IpY; Sat, 19 Oct 2024 11:06:43 +0200 In-Reply-To: (Lin Sun's message of "Sat, 19 Oct 2024 05:58:14 +0000") X-Provags-ID: V03:K1:PMU+JUAZw1TKof4hQhcHRFFPdmb3zp5DXVlvNw1XsdnuXxnEYLv UZ20ql/ZL1WlXJ9HbF5hkmNHpxq2z2ugN9dxVeIvjSxJzMmIGeRA+LozNlOYdNXBRl18rKc cFvSGBS1TTuq+Z6TJvxfdaztXnEPIgQJSgmAQLDShWwppKdJdsbM3wCXBfuZR+Gyc7WeRwj Ch+Gco6TGewAd4WGw28sA== UI-OutboundReport: notjunk:1;M01:P0:eTWwzDTGa+4=;VevzU+408W1cApSI8FrxHAqLAWm DoYRxGA991Sj2Jkxeo7cGvBetuoD0njCzqcapiAQn/KIqkLXE4HXboxcvsMdYi50vAGCLIq6y y6j9FSZgvovbl7RduXbtzKsrTnujtFtKTdrmLbfBn3h5ejpDuSaNFYkH6jNPFUbwbFEWn94z6 mV/LJQVBp0ORY5GQO5vGAw9ArzPblM6TqNM32XZx0HdUWBCsOueROKaFmI3TmAOO+yiSrRsSJ zTKMD+MhuTcKna43/EzuOcbK+90Rgh+2SNXLdzuYxodjcA5xd5/Wksy+jclDYVDET/PMEwbTl 0+81OcXx/EN/FRQp55mkEnOEytbV/XKnIIyCW+wzR+R/XlFqRjKir5JX09hPlFnJ1GsdeACqS vngIH3MLk6t4YGB0+a8ZPnQbRd7AF4AfnO+Ft52HUjcQW0GskEcIYRfl8rT2BVBikCyAxRO66 Bhf2aFBoggu8rnzW5CPh6X8ehlu48TswDx16EdEmOVNAQAb4Rnz93G9cY40bP4Lf7PIK57NlD HHbKgfUmQ85G9dTlQTVmRWwyB9zn9ulRINVsAmd6jZQJ0qk7nK7e94302vvb1l7cganfBN4gh Sy630T/p0PKC1Q3fYuWMHQlJueGU6saPdJ2Otucxs/4nIkJ5UayEH0m2uhlhV6cRSpvkPTtUz kFAfX/MZcQg6KPn4eM1JjPR6DFMomOLo/7ohZowZHsICbUJgSIu8fz3pBDHGrFYrh+LW1iC2J YBu3DiLJ2UiEXj+pktJSdsVOv3QmnTkJqcl+oUjmMhqtkXUYh9pBTlgsEUI4+11XwDUsBjum X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293859 Archived-At: Lin Sun writes: Hi Lin, > Let's look at this case: the auto-revert-interval is 5, a writing > happened 1 write / second, total 20 writings (in 20 seconds). The > revert-handler run on: first time (T0), and then locks for 5 seconds; > then T5 lock done, revert the buffer; then T6 reverts the and locks it > again... The revert happened as below: > > T0...T5,T6...T11,T12...T17,T18...T23 > > The T5,T6 are nearby, similar happened on T11,T12, and after each lock > end, there is a revert executed nearby. > > This patch try to enhance the lock, then makes the revert happened on: > > T0...T5...T10...T15... > > That reduced loading on my local. Thanks for explanation, now I understand the scenario. Your patch makes sense. However, autorevert-tests fail now: =2D-8<---------------cut here---------------start------------->8--- # make -C test autorevert-tests make: Entering directory '/home/albinus/src/emacs/test' make[1]: Entering directory '/home/albinus/src/emacs/test' GEN lisp/autorevert-tests.log Running 7 tests (2024-10-19 11:02:58+0200, selector `(not (tag :unstable))= ') Reverting buffer `emacs-test-zzmdD8-autorevert' passed 1/7 auto-revert-test00-auto-revert-mode (3.554035 sec) (Shell command succeeded with no output) Reverting buffer `auto-revert-testenE8rY-autorevert' Reverting buffer `auto-revert-testOJVaub-autorevert' passed 2/7 auto-revert-test01-auto-revert-several-files (0.172674 sec= ) Reverting buffer `emacs-test-IIR73t-autorevert' passed 3/7 auto-revert-test03-auto-revert-tail-mode (2.527101 sec) Reverting buffer `tmp' Reverting buffer `tmp' passed 4/7 auto-revert-test04-auto-revert-mode-dired (0.457824 sec) Reverting buffer `emacs-test-i5RWpJ-autorevert' Test auto-revert-test05-global-notify backtrace: signal(ert-test-failed (((should (equal (auto-revert-test--buffer-st ert-fail(((should (equal (auto-revert-test--buffer-string buf-2) "2- (if (unwind-protect (setq value-171 (apply fn-169 args-170)) (setq f (let (form-description-173) (if (unwind-protect (setq value-171 (app (let ((value-171 'ert-form-evaluation-aborted-172)) (let (form-descr (let* ((fn-169 #'equal) (args-170 (condition-case err (list (auto-re (progn (setq buf-1 (find-file-noselect file-1)) (auto-revert-test--i (unwind-protect (progn (setq buf-1 (find-file-noselect file-1)) (aut (let* ((auto-revert-use-notify t) (auto-revert-avoid-polling t) (was (progn (let* ((auto-revert-use-notify t) (auto-revert-avoid-polling (unwind-protect (progn (let* ((auto-revert-use-notify t) (auto-rever (let* ((coding-system-for-write nil) (temp-file (identity (make-temp (progn (let* ((coding-system-for-write nil) (temp-file (identity (ma (unwind-protect (progn (let* ((coding-system-for-write nil) (temp-fi (let* ((coding-system-for-write nil) (temp-file (identity (make-temp (progn (let* ((coding-system-for-write nil) (temp-file (identity (ma (unwind-protect (progn (let* ((coding-system-for-write nil) (temp-fi (let* ((coding-system-for-write nil) (temp-file (identity (make-temp (progn (customize-set-variable 'auto-revert-interval 0.1) (let* ((co (unwind-protect (progn (customize-set-variable 'auto-revert-interval (let ((auto-revert-interval-orig auto-revert-interval)) (unwind-prot #f(lambda () [t] (let ((value-147 (gensym "ert-form-evaluation-abort #f(compiled-function () #)() handler-bind-1(#f(compiled-function () # ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name auto-revert-test05-global-notify :doc ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type ert-run-tests-batch((not (tag :unstable))) ert-run-tests-batch-and-exit((not (tag :unstable))) eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t) command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l command-line() normal-top-level() Test auto-revert-test05-global-notify condition: (ert-test-failed ((should (equal (auto-revert-test--buffer-string buf-2) "2-a")) :form (equal "" "2-a") :value nil :explanation (arrays-of-different-length 0 3 "" "2-a" first-mismatch-at 0))) FAILED 5/7 auto-revert-test05-global-notify (1.020224 sec) at lisp/au= torevert-tests.el:451 Reverting buffer `emacs-test-cjR4uH-autorevert-2' passed 6/7 auto-revert-test06-write-file (0.136182 sec) Reverting buffer `emacs-test-EnNjg7-autorevert' Reverting buffer `emacs-test-EnNjg7-autorevert-0' Reverting buffer `emacs-test-EnNjg7-autorevert-1' Reverting buffer `emacs-test-EnNjg7-autorevert-2' Reverting buffer `emacs-test-EnNjg7-autorevert-3' Reverting buffer `emacs-test-EnNjg7-autorevert-4' Reverting buffer `emacs-test-EnNjg7-autorevert-5' Reverting buffer `emacs-test-EnNjg7-autorevert-6' Reverting buffer `emacs-test-EnNjg7-autorevert-7' Reverting buffer `emacs-test-EnNjg7-autorevert-8' Reverting buffer `emacs-test-EnNjg7-autorevert-9' passed 7/7 auto-revert-test07-auto-revert-several-buffers (5.077571 s= ec) Ran 7 tests, 6 results as expected, 1 unexpected (2024-10-19 11:03:12+0200= , 14.040452 sec) 1 unexpected results: FAILED auto-revert-test05-global-notify make[1]: *** [Makefile:185: lisp/autorevert-tests.log] Error 1 make[1]: Leaving directory '/home/albinus/src/emacs/test' make: *** [Makefile:251: lisp/autorevert-tests] Error 2 make: Leaving directory '/home/albinus/src/emacs/test' =2D-8<---------------cut here---------------end--------------->8--- Could you pls check what's up? > Best Regards, Lin Best regards, Michael.