From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#74786: [PATCH] Add custom args to test compile step Date: Mon, 16 Dec 2024 18:41:55 -0800 Message-ID: <87ldwfhvyk.fsf@neverwas.me> References: <86wmg62pfs.fsf@gnu.org> <87wmg643g4.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37778"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Randy Taylor , Robert Pluim , Eli Zaretskii , 74786@debbugs.gnu.org To: "O'Brien, Will" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 17 03:43:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tNNYX-0009gS-5y for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Dec 2024 03:43:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNNYE-0006IS-2D; Mon, 16 Dec 2024 21:43:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNNY7-0006IA-5Z for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 21:43:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNNY6-0000w3-St for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 21:43:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=EKNO4SD4tuo13Dhoh82oQXNAeU9bZw91uvhPUKSICYc=; b=oaKHusoYUzXorrTOJ7KIYpNW48Ue86WbW3zSTKZHagguwi6KOB6DtpAF10FfzqjdxxTyUOHwCi8Lra+RVSsxzS5//5D8Rd+Rr6NWBP30Yr91s6fNGWKb6dN4sGHzKH+mjpCiMv0/iyaS3CwoNQ8P3aIxRbR/3paHCYH0ufKpDH1CggQYXRIeCfee4pBZUshnNwdQQNrokGmiMRvRvyvRNniJfJeUuJD80AVQAuJIUQkdwOq756VuD9zi4cZcwW4VF+WkQg2TbR3Yqi8rGOEEIWhUB9SW9EXsaktlhc+jEFI62UpCbzSjqC3sVzYZ86WuHY6nVkobxKWFFhj4EssOgQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tNNY5-00021Q-OA for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 21:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Dec 2024 02:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74786 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74786-submit@debbugs.gnu.org id=B74786.17344033267681 (code B ref 74786); Tue, 17 Dec 2024 02:43:01 +0000 Original-Received: (at 74786) by debbugs.gnu.org; 17 Dec 2024 02:42:06 +0000 Original-Received: from localhost ([127.0.0.1]:56952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNNXC-0001zp-9K for submit@debbugs.gnu.org; Mon, 16 Dec 2024 21:42:06 -0500 Original-Received: from mail-108-mta103.mxroute.com ([136.175.108.103]:41437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNNX7-0001zR-NK for 74786@debbugs.gnu.org; Mon, 16 Dec 2024 21:42:04 -0500 Original-Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta103.mxroute.com (ZoneMTA) with ESMTPSA id 193d27e6331000310e.001 for <74786@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 17 Dec 2024 02:41:58 +0000 X-Zone-Loop: ae42c307b37e4aff73570d400f74221cb386731d5362 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=EKNO4SD4tuo13Dhoh82oQXNAeU9bZw91uvhPUKSICYc=; b=LPmqxVWhDywDDUYRTnriET2IJu o9+oVEyFrL2pS4LQlq/DtbJ0Pdwn+v5ZaXXkYFf5FE/HPe6wANmomJtHo8axU3Xaja7VzKR4FgmJn 3I58R2LsiUgROo4tMYSu90HPj8JvGLtWFNzxo+GyNwKP/d/nTE9UfwCKWVL/v0YaruJVoNZN/rVnt jQ6PDJc/7RCUeNNq2c2erin4n+Qj6yX8ICwHw/cHvaYI/mn2yiVTsRIf8BVZkiaUrnZP6Aq44oCLO hKMzw8xtqkbTpTboIvfNMm23kPCYA7R7un/06x8b4v/bPTjM/c2Z/ms2m0U+WYT8uFd9Ab3Dn7I23 joCbkJjA==; In-Reply-To: (Will O'Brien's message of "Wed, 11 Dec 2024 16:31:49 +0000") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297244 Archived-At: Hi, Hope you don't mind my butting in. "O'Brien, Will" writes: > Ah, thanks! I've attached a new patch with the simplification. > [...] > @@ -396,7 +402,8 @@ specifying build tags." > "Compile the tests matching REGEXP. > This function respects the `go-ts-mode-build-tags' variable for > specifying build tags." > - (compile (format "go test -v %s -run '%s'" > + (compile (format "go test %s -v %s -run '%s'" > + (string-join go-ts-mode-test-args) ^ Should this specify a separator argument? Or, since $ go help testflag lists a few options that take a regexp argument, maybe something like (mapconcat #'shell-quote-argument go-ts-mode-test-args " ") would make more sense? If that's just nonsense, please pardon the noise. J.P.