unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "J.P." <jp@neverwas.me>
To: "O'Brien, Will" <will.08rien@gmail.com>
Cc: Randy Taylor <dev@rjt.dev>, Robert Pluim <rpluim@gmail.com>,
	Eli Zaretskii <eliz@gnu.org>,
	74786@debbugs.gnu.org
Subject: bug#74786: [PATCH] Add custom args to test compile step
Date: Mon, 16 Dec 2024 18:41:55 -0800	[thread overview]
Message-ID: <87ldwfhvyk.fsf@neverwas.me> (raw)
In-Reply-To: <m2r06edvuy.fsf@gmail.com> (Will O'Brien's message of "Wed, 11 Dec 2024 16:31:49 +0000")

Hi,

Hope you don't mind my butting in.

"O'Brien, Will" <will.08rien@gmail.com> writes:

> Ah, thanks!  I've attached a new patch with the simplification.
>
[...]
> @@ -396,7 +402,8 @@ specifying build tags."
>    "Compile the tests matching REGEXP.
>  This function respects the `go-ts-mode-build-tags' variable for
>  specifying build tags."
> -  (compile (format "go test -v %s -run '%s'"
> +  (compile (format "go test %s -v %s -run '%s'"
> +                   (string-join go-ts-mode-test-args)
                                                       ^

Should this specify a separator argument?

Or, since

  $ go help testflag

lists a few options that take a regexp argument, maybe something like

  (mapconcat #'shell-quote-argument go-ts-mode-test-args " ")

would make more sense? If that's just nonsense, please pardon the noise.

J.P.





  parent reply	other threads:[~2024-12-17  2:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-11 10:18 bug#74786: [PATCH] Add custom args to test compile step O'Brien, Will
2024-12-11 15:45 ` Eli Zaretskii
2024-12-11 15:58   ` Robert Pluim
2024-12-11 16:31     ` O'Brien, Will
2024-12-15  2:17       ` Randy Taylor
2024-12-17  2:41       ` J.P. [this message]
2024-12-11 16:30   ` O'Brien, Will
2024-12-11 17:10     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ldwfhvyk.fsf@neverwas.me \
    --to=jp@neverwas.me \
    --cc=74786@debbugs.gnu.org \
    --cc=dev@rjt.dev \
    --cc=eliz@gnu.org \
    --cc=rpluim@gmail.com \
    --cc=will.08rien@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).