* in dired hit v on a .zip archive
@ 2004-04-08 21:54 Dan Jacobson
0 siblings, 0 replies; 4+ messages in thread
From: Dan Jacobson @ 2004-04-08 21:54 UTC (permalink / raw)
In dired hit v on a .zip archive.
Now both view mode and zip-archive mode are in effect.
I say only zip-archive mode should be now in effect, just as if we hit RET.
Just as when we hit v on a subdirectory, are we put into view mode?
No, we are put into dired mode.
^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <mailman.427.1081466848.23317.bug-gnu-emacs@gnu.org>]
* Re: in dired hit v on a .zip archive
[not found] <mailman.427.1081466848.23317.bug-gnu-emacs@gnu.org>
@ 2004-04-09 22:01 ` Kevin Rodgers
2004-04-12 19:54 ` Dan Jacobson
0 siblings, 1 reply; 4+ messages in thread
From: Kevin Rodgers @ 2004-04-09 22:01 UTC (permalink / raw)
Dan Jacobson wrote:
> In dired hit v on a .zip archive.
> Now both view mode and zip-archive mode are in effect.
> I say only zip-archive mode should be now in effect, just as if we hit RET.
I say Emacs is behaving correctly and as documented:
| v runs the command dired-view-file
| which is an interactive compiled Lisp function in `dired'.
| (dired-view-file)
|
| In dired, examine a file in view mode, returning to dired when done.
> Just as when we hit v on a subdirectory, are we put into view mode?
> No, we are put into dired mode.
But we _should_ be put in View mode. Here's a patch:
*** emacs-21.3/lisp/dired.el.orig Fri Feb 7 04:48:13 2003
--- emacs-21.3/lisp/dired.el Fri Apr 9 09:53:54 2004
***************
*** 1396,1402 ****
(if (file-directory-p (dired-get-filename))
(or (and (cdr dired-subdir-alist)
(dired-goto-subdir (dired-get-filename)))
! (dired (dired-get-filename)))
(view-file (dired-get-filename))))
(defun dired-find-file-other-window ()
--- 1396,1403 ----
(if (file-directory-p (dired-get-filename))
(or (and (cdr dired-subdir-alist)
(dired-goto-subdir (dired-get-filename)))
! (let ((find-file-run-dired t))
! (view-file (dired-get-filename))))
(view-file (dired-get-filename))))
(defun dired-find-file-other-window ()
--
Kevin Rodgers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: in dired hit v on a .zip archive
2004-04-09 22:01 ` Kevin Rodgers
@ 2004-04-12 19:54 ` Dan Jacobson
2004-04-13 23:02 ` Kevin Rodgers
0 siblings, 1 reply; 4+ messages in thread
From: Dan Jacobson @ 2004-04-12 19:54 UTC (permalink / raw)
>> Just as when we hit v on a subdirectory, are we put into view mode?
>> No, we are put into dired mode.
K> But we _should_ be put in View mode. Here's a patch:
Oh great, looks like dired but it's in view mode, just what us with
few cells to spare left upstairs need.
Anyway, when I hit v on a .deb here on debian, I like how it also
doesn't turn on view mode at the same time. etc. No patches please
this time.
hitting v on a tar.gz does turn on tar and view mode.
Well, what is it going to be for all of these, yoo hoo, oh father of
free software? Strict RET and v divided, like Kevin wants, or v=RET
muddled, like I seem to maybe still want?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: in dired hit v on a .zip archive
2004-04-12 19:54 ` Dan Jacobson
@ 2004-04-13 23:02 ` Kevin Rodgers
0 siblings, 0 replies; 4+ messages in thread
From: Kevin Rodgers @ 2004-04-13 23:02 UTC (permalink / raw)
Dan Jacobson wrote:
> Well, what is it going to be for all of these, yoo hoo, oh father of
> free software? Strict RET and v divided, like Kevin wants, or v=RET
> muddled, like I seem to maybe still want?
Here's what RMS wrote to me regarding my patch:
| This change would not achieve its aim. view-file on a Dired buffer
| does nothing except switch-to-buffer, because Dired mode is a special
| mode:
|
| (interactive "fView file: ")
| (unless (file-exists-p file) (error "%s does not exist" file))
| (let ((had-a-buf (get-file-buffer file))
| (buffer (find-file-noselect file)))
| (if (eq (with-current-buffer buffer
| (get major-mode 'mode-class))
| 'special)
| (progn
| (switch-to-buffer buffer)
| (message "Not using View mode because the major mode is special"))
|
| This recognizes that using view-mode on a directory listing is not
| very useful. The code should do what it does now.
--
Kevin Rodgers
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-04-13 23:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-08 21:54 in dired hit v on a .zip archive Dan Jacobson
[not found] <mailman.427.1081466848.23317.bug-gnu-emacs@gnu.org>
2004-04-09 22:01 ` Kevin Rodgers
2004-04-12 19:54 ` Dan Jacobson
2004-04-13 23:02 ` Kevin Rodgers
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).