From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#2553: *vc-diff* buffers are read-only, but M-k works Date: Wed, 04 Mar 2009 10:41:46 -0500 Message-ID: <87k575jnwl.fsf__14445.0806234547$1236182789$gmane$org@cyd.mit.edu> Reply-To: Chong Yidong , 2553@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1236182706 18441 80.91.229.12 (4 Mar 2009 16:05:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Mar 2009 16:05:06 +0000 (UTC) Cc: David Reitter , 2553@emacsbugs.donarmstrong.com To: emacs-devel@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 04 17:06:22 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LetbM-00039t-0c for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Mar 2009 17:05:57 +0100 Original-Received: from localhost ([127.0.0.1]:37925 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Leta0-0004ea-KT for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 Mar 2009 11:04:20 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LetZR-0004Qv-6s for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2009 11:03:45 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LetZP-0004Pt-Gl for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2009 11:03:44 -0500 Original-Received: from [199.232.76.173] (port=37568 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LetZP-0004Pp-6y for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2009 11:03:43 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:35541) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LetZO-0002FN-3m for bug-gnu-emacs@gnu.org; Wed, 04 Mar 2009 11:03:42 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n24G3doW000648; Wed, 4 Mar 2009 08:03:39 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n24Fj348028046; Wed, 4 Mar 2009 07:45:03 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Chong Yidong Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 04 Mar 2009 15:45:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2553 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2553-submit@emacsbugs.donarmstrong.com id=B2553.123618124127878 (code B ref 2553); Wed, 04 Mar 2009 15:45:03 +0000 Original-Received: (at 2553) by emacsbugs.donarmstrong.com; 4 Mar 2009 15:40:41 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n24FecYM027872 for <2553@emacsbugs.donarmstrong.com>; Wed, 4 Mar 2009 07:40:39 -0800 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 4354257E1FC; Wed, 4 Mar 2009 10:41:46 -0500 (EST) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 04 Mar 2009 11:03:44 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:25973 Archived-At: David Reitter wrote: > M-k works just fine in read-only *vc-diff* buffers. > > However, undoing an M-k command is impossible, as is cutting, pasting, > or all the other things that I did all the time in *vc-diff* buffers > in Emacs 22. > > The M-k thing is a bug, the read-only (default?) setting is annoying. The purpose of making the vc-diff buffer read-only (2007-11-10 change to vc.el) was so that people can use the read-only diff-mode bindings like "k" and "p". However, it's counter-intuitive that undo does not work. Probably the easiest fix is to define a diff-undo command that lifts the read-only restriction temporarily. Any thoughts?