From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#5474: 23.1.91.1; describe-mode does not offer link to the .el Date: Mon, 25 Jan 2010 19:54:09 +0200 Organization: JURTA Message-ID: <87k4v6jcji.fsf@mail.jurta.org> References: <87bpgim7bo.fsf@jidanni.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1264443020 27698 80.91.229.12 (25 Jan 2010 18:10:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 25 Jan 2010 18:10:20 +0000 (UTC) Cc: 5474@debbugs.gnu.org To: jidanni@jidanni.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 25 19:10:12 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NZTO8-0006fJ-1w for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Jan 2010 19:10:12 +0100 Original-Received: from localhost ([127.0.0.1]:39559 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZTO9-0004Tu-5w for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Jan 2010 13:10:13 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZTNq-0004CB-F7 for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2010 13:09:54 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZTNl-00043o-KX for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2010 13:09:53 -0500 Original-Received: from [199.232.76.173] (port=41956 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZTNl-00043f-Hh for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2010 13:09:49 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53771) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NZTNl-0008RZ-7G for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2010 13:09:49 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NZTCM-0005lz-L5; Mon, 25 Jan 2010 12:58:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Jan 2010 17:58:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5474 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5474-submit@debbugs.gnu.org id=B5474.126444224722164 (code B ref 5474); Mon, 25 Jan 2010 17:58:02 +0000 Original-Received: (at 5474) by debbugs.gnu.org; 25 Jan 2010 17:57:27 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZTBm-0005lR-54 for submit@debbugs.gnu.org; Mon, 25 Jan 2010 12:57:26 -0500 Original-Received: from smtp-out4.starman.ee ([85.253.0.6] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NZTBk-0005lK-2C for 5474@debbugs.gnu.org; Mon, 25 Jan 2010 12:57:25 -0500 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Original-Received: from mail.starman.ee (82.131.30.13.cable.starman.ee [82.131.30.13]) by mx2.starman.ee (Postfix) with ESMTP id 316773F4108; Mon, 25 Jan 2010 19:57:13 +0200 (EET) In-Reply-To: <87bpgim7bo.fsf@jidanni.org> (jidanni@jidanni.org's message of "Tue, 26 Jan 2010 01:18:35 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (x86_64-pc-linux-gnu) X-Spam-Score: -3.0 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -3.0 (---) Resent-Date: Mon, 25 Jan 2010 12:58:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34704 Archived-At: > We hit C-h m. We see the following: > > XXXX mode: > Major mode for editing XXXX. > > key binding > --- ------- > > C-c Prefix Command > ESC Prefix Command > > C-M-x XXXX-eval-defun > > Nowhere is there a link to XXXX.el. > We have to hit XXXX-eval-defun to get a link to XXXX.el. > > It should say at top > XXXX mode: > Major mode for editing XXXX. Defined in XXXX.el <---clickable. > > Or > XXXX mode (... XXXX-mode, defined in XXXX.el): > Major mode for editing XXXX. This can be implemented after feature freeze with the following patch that adds links to the major/minor mode names for `C-h m': Index: emacs/lisp/help.el =================================================================== RCS file: /sources/emacs/emacs/lisp/help.el,v retrieving revision 1.327 diff -u -r1.327 help.el --- emacs/lisp/help.el 21 Mar 2007 16:15:45 -0000 1.327 +++ emacs/lisp/help.el 5 May 2007 17:01:30 -0000 @@ -815,7 +815,12 @@ (princ "\n\f\n") (push (point-marker) help-button-cache) ;; Document the minor modes fully. - (insert pretty-minor-mode) + (insert-button pretty-minor-mode + 'action `(lambda (button) + (describe-function ',mode-function)) + 'follow-link t + 'help-echo (format "mouse-2, RET: show information about %S" + mode-function)) (princ (format " minor mode (%s):\n" (if (zerop (length indicator)) "no indicator" @@ -833,10 +838,15 @@ (princ "\n(Information about these minor modes follows the major mode info.)\n\n")) ;; Document the major mode. - (let ((mode mode-name)) + (let ((major-mode-function major-mode) (mode mode-name)) (with-current-buffer standard-output (let ((start (point))) - (insert (format-mode-line mode)) + (insert-button (format-mode-line mode) + 'action `(lambda (button) + (describe-function ',major-mode-function)) + 'follow-link t + 'help-echo (format "mouse-2, RET: show information about %S" + major-mode-function)) (add-text-properties start (point) '(face bold))))) (princ " mode:\n") (princ (documentation major-mode))) -- Juri Linkov http://www.jurta.org/emacs/