From: Stephen Berman <stephen.berman@gmx.net>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Stefan Monnier <monnier@IRO.UMontreal.CA>, 7307@debbugs.gnu.org
Subject: bug#7307: 24.0.50; Mode line had more than just dashes removed
Date: Sat, 06 Nov 2010 00:08:58 +0100 [thread overview]
Message-ID: <87k4kr5px1.fsf@escher.home> (raw)
In-Reply-To: <m262wbobh9.fsf@igel.home> (Andreas Schwab's message of "Fri, 05 Nov 2010 19:45:54 +0100")
On Fri, 05 Nov 2010 19:45:54 +0100 Andreas Schwab <schwab@linux-m68k.org> wrote:
> Stephen Berman <stephen.berman@gmx.net> writes:
>
>> --- 19342,19362 ----
>> case '-':
>> {
>> register int i;
>> ! int fill_len;
>> ! int lots_of_filler = 140 * sizeof (char);
>
> What is the point of sizeof (char)?
Oops, I was just confused. Thanks.
>
>> ! /* Make a string of mode_line_filler characters. */
>> ! fill_len =
>> ! (mode_line_target == MODE_LINE_NOPROP
>> ! || mode_line_target == MODE_LINE_STRING)
>> ! ? 2
>> ! : ((field_width <= 0 || field_width > lots_of_filler)
>> ! ? FRAME_MESSAGE_BUF_SIZE (f) - 1
>> ! : lots_of_filler);
>> ! for (i = 0; i < fill_len; ++i)
>> ! decode_mode_spec_buf[i] = mode_line_filler;
>
> What happens if mode_line_filler is a non-ASCII character?
The mode line gets filled with a string of raw bytes :-(. What is the
right thing to do here?
Steve Berman
next prev parent reply other threads:[~2010-11-05 23:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 23:05 bug#7307: 24.0.50; Mode line had more than just dashes removed Stephen Berman
2010-10-30 6:51 ` Eli Zaretskii
2010-10-30 13:27 ` Stephen Berman
2010-10-30 13:49 ` Eli Zaretskii
2010-10-30 15:23 ` Stephen Berman
2010-10-31 3:54 ` Stefan Monnier
2010-11-01 18:11 ` Stephen Berman
2010-11-01 19:32 ` Eli Zaretskii
2010-11-01 23:35 ` Stephen Berman
2010-11-02 5:35 ` Eli Zaretskii
2010-11-02 6:31 ` Eli Zaretskii
2010-11-02 14:32 ` Stefan Monnier
2010-11-05 16:18 ` Stephen Berman
2010-11-05 18:45 ` Andreas Schwab
2010-11-05 23:08 ` Stephen Berman [this message]
2010-11-08 18:28 ` Stefan Monnier
2010-11-21 0:37 ` Stephen Berman
2010-10-31 0:49 ` James Cloos
2010-11-01 18:11 ` Stephen Berman
2012-06-03 9:05 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k4kr5px1.fsf@escher.home \
--to=stephen.berman@gmx.net \
--cc=7307@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).