From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 9438@debbugs.gnu.org
Subject: bug#9438: grep regressions
Date: Thu, 08 Sep 2011 23:18:05 +0300 [thread overview]
Message-ID: <87k49irdoi.fsf@mail.jurta.org> (raw)
In-Reply-To: <87mxeg4kqz.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 07 Sep 2011 15:09:24 +0300")
> Beside `grep-error-screen-columns', I discovered two more unused defcustoms
> in grep.el:
>
> (defcustom grep-window-height nil
> "*Number of lines in a grep window. If nil, use `compilation-window-height'."
> :type '(choice (const :tag "Default" nil)
> integer)
> :version "22.1"
> :group 'grep)
>
> (defcustom grep-scroll-output nil
> "*Non-nil to scroll the *grep* buffer window as output appears.
> Setting it causes the grep commands to put point at the end of their
> output window so that the end of the output is always visible rather
> than the begining."
> :type 'boolean
> :version "22.1"
> :group 'grep)
>
> IIUC, since the docstring says "If nil, use `compilation-window-height'"
> they should be used in `grep-mode' only when the value is non-nil like:
>
> (when grep-window-height
> (set (make-local-variable 'compilation-window-height)
> grep-window-height))
> (when grep-scroll-output
> (set (make-local-variable 'compilation-scroll-output)
> grep-scroll-output))
According to bzr logs, before revno:54335 this used to be:
(if grep-window-height
(set (make-local-variable 'compilation-window-height)
grep-window-height))
(set (make-local-variable 'compilation-scroll-output)
grep-scroll-output)
So either we should restore this code in `grep-process-setup' to use
the customized values of defcustoms, or remove unused defcustoms.
I have no settled opinion what would be better to do.
prev parent reply other threads:[~2011-09-08 20:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 8:34 bug#9438: grep regressions Juri Linkov
2011-09-07 1:22 ` Stefan Monnier
2011-09-07 12:09 ` Juri Linkov
2011-09-08 20:18 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k49irdoi.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=9438@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).