From: Juri Linkov <juri@jurta.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 10040@debbugs.gnu.org
Subject: bug#10040: 24.0.91; isearch.el - binding of user options
Date: Tue, 15 Nov 2011 21:17:06 +0200 [thread overview]
Message-ID: <87k471p559.fsf@mail.jurta.org> (raw)
In-Reply-To: <6857C0631DA84C638B3B9FA7F89B90D6@us.oracle.com> (Drew Adams's message of "Sun, 13 Nov 2011 11:26:45 -0800")
> 3. And yet you do it, so perhaps you would like to consider code where
> you do it as bugs. Assuming that, let me help by pointing out that you
> do it in each of the Isearch help commands: isearch-help-for-help,
> isearch-describe-bindings, and isearch-describe-key. The user options
> you let-bind are `same-window-names' and `same-window-regexps'.
As discussed recently in bug#3419, they should be replaced with
`inhibit-same-window':
=== modified file 'lisp/isearch.el'
--- lisp/isearch.el 2011-11-15 14:33:18 +0000
+++ lisp/isearch.el 2011-11-15 19:14:07 +0000
@@ -378,7 +378,7 @@ (make-help-screen isearch-help-for-help-
(defun isearch-help-for-help ()
"Display Isearch help menu."
(interactive)
- (let (same-window-buffer-names same-window-regexps)
+ (let ((display-buffer-overriding-action '(nil (inhibit-same-window . t))))
(isearch-help-for-help-internal))
(isearch-update))
@@ -386,7 +386,7 @@ (defun isearch-describe-bindings ()
"Show a list of all keys defined in Isearch mode, and their definitions.
This is like `describe-bindings', but displays only Isearch keys."
(interactive)
- (let (same-window-buffer-names same-window-regexps)
+ (let ((display-buffer-overriding-action '(nil (inhibit-same-window . t))))
(with-help-window "*Help*"
(with-current-buffer standard-output
(princ "Isearch Mode Bindings:\n")
@@ -395,14 +395,14 @@ (defun isearch-describe-bindings ()
(defun isearch-describe-key ()
"Display documentation of the function invoked by isearch key."
(interactive)
- (let (same-window-buffer-names same-window-regexps)
+ (let ((display-buffer-overriding-action '(nil (inhibit-same-window . t))))
(call-interactively 'describe-key))
(isearch-update))
(defun isearch-describe-mode ()
"Display documentation of Isearch mode."
(interactive)
- (let (same-window-buffer-names same-window-regexps)
+ (let ((display-buffer-overriding-action '(nil (inhibit-same-window . t))))
(describe-function 'isearch-forward))
(isearch-update))
next prev parent reply other threads:[~2011-11-15 19:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-13 19:26 bug#10040: 24.0.91; isearch.el - binding of user options Drew Adams
2011-11-15 19:17 ` Juri Linkov [this message]
2011-11-22 18:53 ` Juri Linkov
2011-11-22 22:36 ` Stefan Monnier
2012-11-04 3:26 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k471p559.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=10040@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).