From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#7017: url-retrieve seems busted Date: Tue, 08 May 2012 13:25:10 +0800 Message-ID: <87k40n9rd5.fsf@gnu.org> References: <87zk9jacda.fsf@edgecast.com> <87obpz9swe.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1336454770 24953 80.91.229.3 (8 May 2012 05:26:10 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 8 May 2012 05:26:10 +0000 (UTC) Cc: 7017@debbugs.gnu.org To: Seth Mason Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 08 07:26:09 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SRcvz-0003qI-0J for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 May 2012 07:26:03 +0200 Original-Received: from localhost ([::1]:35026 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRcvy-0006m6-AM for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 May 2012 01:26:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRcvv-0006m1-OB for bug-gnu-emacs@gnu.org; Tue, 08 May 2012 01:26:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRcvu-0003QP-0g for bug-gnu-emacs@gnu.org; Tue, 08 May 2012 01:25:59 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRcvt-0003QL-TE for bug-gnu-emacs@gnu.org; Tue, 08 May 2012 01:25:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SRcxu-0001Ik-5a for bug-gnu-emacs@gnu.org; Tue, 08 May 2012 01:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 May 2012 05:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7017 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 7017-submit@debbugs.gnu.org id=B7017.13364548464958 (code B ref 7017); Tue, 08 May 2012 05:28:02 +0000 Original-Received: (at 7017) by debbugs.gnu.org; 8 May 2012 05:27:26 +0000 Original-Received: from localhost ([127.0.0.1]:40299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SRcxK-0001Hu-82 for submit@debbugs.gnu.org; Tue, 08 May 2012 01:27:26 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:39772 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SRcxH-0001Hn-Il for 7017@debbugs.gnu.org; Tue, 08 May 2012 01:27:24 -0400 Original-Received: from [155.69.17.96] (port=54387 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SRcvF-0000QC-1d; Tue, 08 May 2012 01:25:17 -0400 In-Reply-To: <87obpz9swe.fsf@gnu.org> (Chong Yidong's message of "Tue, 08 May 2012 12:52:01 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.96 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59855 Archived-At: Chong Yidong writes: > Applying url-hexify-string on the entire URL, as the previous patch did, > is wrong. We musn't hexify reserved characters that are being used in > their special role. Unfortunately, figuring out when those characters > are being used in their special role requires an implementation of > RFC2396, which I don't think we currently have in Emacs. Actually, I think we could use url-generic-parse-url for this.