From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#14390: 24.3.50; (wrong-type-argument stringp t) from `read-regexp' Date: Wed, 15 May 2013 02:40:50 +0300 Organization: JURTA Message-ID: <87k3n1yvst.fsf@mail.jurta.org> References: <5C8F1D9AC91F44D8B2802A79E962581C@us.oracle.com> <874ne9qf7y.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1368575053 26887 80.91.229.3 (14 May 2013 23:44:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 14 May 2013 23:44:13 +0000 (UTC) Cc: 14390-done@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 15 01:44:07 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UcOt5-0001VY-51 for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 May 2013 01:44:07 +0200 Original-Received: from localhost ([::1]:43273 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcOt4-0003hv-Pw for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 May 2013 19:44:06 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcOt0-0003hn-LE for bug-gnu-emacs@gnu.org; Tue, 14 May 2013 19:44:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcOsz-0000IG-Pb for bug-gnu-emacs@gnu.org; Tue, 14 May 2013 19:44:02 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcOsz-0000I7-KL for bug-gnu-emacs@gnu.org; Tue, 14 May 2013 19:44:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UcOt0-00012t-Gs for bug-gnu-emacs@gnu.org; Tue, 14 May 2013 19:44:02 -0400 Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 May 2013 23:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 14390 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 14390@debbugs.gnu.org, juri@jurta.org, drew.adams@oracle.com Original-Received: via spool by 14390-done@debbugs.gnu.org id=D14390.13685749933886 (code D ref 14390); Tue, 14 May 2013 23:44:02 +0000 Original-Received: (at 14390-done) by debbugs.gnu.org; 14 May 2013 23:43:13 +0000 Original-Received: from localhost ([127.0.0.1]:44806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UcOsC-00010b-Ja for submit@debbugs.gnu.org; Tue, 14 May 2013 19:43:13 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:47756 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UcOsA-00010K-PM for 14390-done@debbugs.gnu.org; Tue, 14 May 2013 19:43:11 -0400 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id ECC03258B9E91C; Tue, 14 May 2013 16:43:06 -0700 (PDT) In-Reply-To: <874ne9qf7y.fsf@mail.jurta.org> (Juri Linkov's message of "Sun, 12 May 2013 02:17:05 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74280 Archived-At: > === modified file 'lisp/subr.el' > --- lisp/subr.el 2013-04-27 23:07:46 +0000 > +++ lisp/subr.el 2013-05-11 23:16:36 +0000 > @@ -2715,7 +2715,7 @@ (defun find-tag-default-as-regexp () > (get major-mode 'find-tag-default-function) > 'find-tag-default)) > (tag (funcall tagf))) > - (cond ((not tag)) > + (cond ((not tag) "") After looking more at this, I think it should return nil because its accompanying function `find-tag-default' returns nil, not an empty string, if there is no default tag at point. This is fixed now. > BTW, the same commit revno:111971 introduced the function > `hi-lock-read-regexp-defaults'. I think this is a good thing, > and I propose to improve it by adding `read-regexp-defaults-tag' > and `read-regexp-defaults-history' as we were discussing a month ago. I'll create a separate request for this.